Bugged

[Moatassem]

Hi there,

I see multiple issues - in makeRequest method, there is no argument for message body, yet it adds a Content-Length, but without a Content-Type for multiple modules.

Did you ever validate it against SIP RFC 3261 before attempting to implement cases for RFC 4475?

BR,
MT

[Moatassem]

Another issue:

It initially determines the reachability to the SIP UAS by initiating a dummy TCP connection. Although all SIP messages sent are over UDP! This is incorrect approach, even if it is just for the sake of checking the reachability. Usually SIP UAs do not listen for both TCP and UDP, it is either or at least it is configurable.

[Moatassem]

Feel free to reach out to discuss and fix issues in SIPTorch SIP Stack.

I've 17+ years experience in SIP/SDP/RTP & VoIP also implemented a carrier grade B2BUA SIP server called SIP Engine - details here