fix: semantic search

Author: ankit-v2-3

videodb/collection.py

@@ -101,8 +101,8 @@ def search(
         query: str,
         search_type: Optional[str] = SearchType.semantic,
         result_threshold: Optional[int] = None,
-        score_threshold: Optional[int] = None,
-        dynamic_score_percentage: Optional[int] = None,
+        score_threshold: Optional[float] = None,
+        dynamic_score_percentage: Optional[float] = None,
     ) -> SearchResult:
         search = SearchFactory(self._connection).get_search(search_type)
         return search.search_inside_collection(

videodb/search.py

@@ -110,8 +110,8 @@ def search_inside_video(
         video_id: str,
         query: str,
         result_threshold: Optional[int] = None,
-        score_threshold: Optional[int] = None,
-        dynamic_score_percentage: Optional[int] = None,
+        score_threshold: Optional[float] = None,
+        dynamic_score_percentage: Optional[float] = None,
         **kwargs,
     ):
         search_data = self._connection.post(
@@ -123,6 +123,8 @@ def search_inside_video(
                 or SemanticSearchDefaultValues.score_threshold,
                 "result_threshold": result_threshold
                 or SemanticSearchDefaultValues.result_threshold,
+                "dynamic_score_percentage": dynamic_score_percentage,
+                **kwargs,
             },
         )
         return SearchResult(self._connection, **search_data)
@@ -132,8 +134,8 @@ def search_inside_collection(
         collection_id: str,
         query: str,
         result_threshold: Optional[int] = None,
-        score_threshold: Optional[int] = None,
-        dynamic_score_percentage: Optional[int] = None,
+        score_threshold: Optional[float] = None,
+        dynamic_score_percentage: Optional[float] = None,
         **kwargs,
     ):
         search_data = self._connection.post(
@@ -145,6 +147,8 @@ def search_inside_collection(
                 or SemanticSearchDefaultValues.score_threshold,
                 "result_threshold": result_threshold
                 or SemanticSearchDefaultValues.result_threshold,
+                "dynamic_score_percentage": dynamic_score_percentage,
+                **kwargs,
             },
         )
         return SearchResult(self._connection, **search_data)
@@ -159,8 +163,8 @@ def search_inside_video(
         video_id: str,
         query: str,
         result_threshold: Optional[int] = None,
-        score_threshold: Optional[int] = None,
-        dynamic_score_percentage: Optional[int] = None,
+        score_threshold: Optional[float] = None,
+        dynamic_score_percentage: Optional[float] = None,
         **kwargs,
     ):
         search_data = self._connection.post(
@@ -187,8 +191,8 @@ def search_inside_video(
         video_id: str,
         query: str,
         result_threshold: Optional[int] = None,
-        score_threshold: Optional[int] = None,
-        dynamic_score_percentage: Optional[int] = None,
+        score_threshold: Optional[float] = None,
+        dynamic_score_percentage: Optional[float] = None,
         **kwargs,
     ):
         search_data = self._connection.post(
@@ -198,6 +202,7 @@ def search_inside_video(
                 "query": query,
                 "score_threshold": score_threshold,
                 "result_threshold": result_threshold,
+                "dynamic_score_percentage": dynamic_score_percentage,
                 **kwargs,
             },
         )

videodb/video.py

@@ -28,7 +28,6 @@ def __init__(self, _connection, id: str, collection_id: str, **kwargs) -> None:
         self.transcript = kwargs.get("transcript", None)
         self.transcript_text = kwargs.get("transcript_text", None)
         self.scenes = kwargs.get("scenes", None)
-        self.scene_collections = kwargs.get("scene_collections", None)
 
     def __repr__(self) -> str:
         return (
@@ -51,8 +50,8 @@ def search(
         query: str,
         search_type: Optional[str] = SearchType.semantic,
         result_threshold: Optional[int] = None,
-        score_threshold: Optional[int] = None,
-        dynamic_score_percentage: Optional[int] = None,
+        score_threshold: Optional[float] = None,
+        dynamic_score_percentage: Optional[float] = None,
         **kwargs,
     ) -> SearchResult:
         search = SearchFactory(self._connection).get_search(search_type)
@@ -173,9 +172,9 @@ def get_scenes(self) -> Union[list, None]:
         self.scenes = scene_data
         return scene_data if scene_data else None
 
-    def _format_scene_collection(self, collection_data: dict) -> SceneCollection:
+    def _format_scene_collection(self, scene_collection_data: dict) -> SceneCollection:
         scenes = []
-        for scene in collection_data.get("scenes", []):
+        for scene in scene_collection_data.get("scenes", []):
             frames = []
             for frame in scene.get("frames", []):
                 frame = Frame(
@@ -200,9 +199,9 @@ def _format_scene_collection(self, collection_data: dict) -> SceneCollection:
 
         return SceneCollection(
             self._connection,
-            collection_data.get("scene_collection_id"),
+            scene_collection_data.get("scene_collection_id"),
             self.id,
-            collection_data.get("config", {}),
+            scene_collection_data.get("config", {}),
             scenes,
         )