Skip to content

Safari browser support #4

@bengreenier

Description

@bengreenier

Redirecting 3DStreamingToolkit/3DStreamingToolkit#164 (comment) to an issue in this repo on behalf of @zaxy78:

Hi !

I'm using the 3dtoolkit and noticed it's not compatible with Safari browser,
although Safari supports WebRTC since June 2017.

I've made it work on my side, mostly though fixes in adapter.js (PR PR) library.
Would it be a problem for you guys to include adapter.js intto 3dtoolkit?
At least in the Web Client Sample, but also potentially in the JS 3dtoolkit Lib itself.

It helps a lot with browsers differences, and might have saved you guys few tens of lines of code.
It is possible ofcouse to add the Safari APIs to the "adaptation lines of code" you guys used in the repo, manually.

I can suggest some pull request with the fixes, and allow the repo to enjoy support for Safari clients.

My only question is - would you take the easy path of including adapter.js , or would you insist in making the changes manually inside the lib?

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions