Skip to content

dev/core#5041 - Add role aria-hidden to FontAwesome icons #23

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
colemanw wants to merge 1 commit into
base: master
Choose a base branch
from
Open

dev/core#5041 - Add role aria-hidden to FontAwesome icons #23

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion templates/CRM/Chat/Page/Contact/Tab.tpl
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
<div id="sms-conversations-tab" class="view-content">
<div class="action-link">
<a accesskey="N" href='{crmURL p="civicrm/sms/conversation/schedule" q="cid=`$contactId`"}' class="button medium-popup"><span><i class="crm-i fa-comment"></i> Schedule Conversation</span></a>
<a accesskey="N" href='{crmURL p="civicrm/sms/conversation/schedule" q="cid=`$contactId`"}' class="button medium-popup"><span><i class="crm-i fa-comment" role="img" aria-hidden="true"></i> Schedule Conversation</span></a>
</div>

<table class="crm-chat-selector crm-ajax-table">
Expand Down
8 changes: 4 additions & 4 deletions templates/CRM/Chat/Page/ConversationType/View.tpl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
<h4>
{$question.number}.
{$question.text}
<a href="{crmURL p='civicrm/chat/question/edit' q="id=`$question.id`"}" title="edit action"><i class="crm-i fa-pencil"></i></a>
<a href="{crmURL p='civicrm/chat/question/edit' q="id=`$question.id`"}" title="edit action"><i class="crm-i fa-pencil" role="img" aria-hidden="true"></i></a>
</h4>

<ul>
Expand All @@ -28,11 +28,11 @@
go to question {$questionMap[$action.action_data]}
{/if}

<a href="{crmURL p='civicrm/chat/action/edit' q="id=`$action.id`"}" title="edit action"><i class="crm-i fa-pencil"></i></a>
<a href="{crmURL p='civicrm/chat/action/edit' q="id=`$action.id`"}" title="edit action"><i class="crm-i fa-pencil" role="img" aria-hidden="true"></i></a>

</li>
{/foreach}
<li><em>add action <a href="{crmURL p='civicrm/chat/action/add' q="questionId=`$question.id`"}" title="add action"><i class="crm-i fa-plus"></i></em></a></li>
<li><em>add action <a href="{crmURL p='civicrm/chat/action/add' q="questionId=`$question.id`"}" title="add action"><i class="crm-i fa-plus" role="img" aria-hidden="true"></i></em></a></li>
</ul>

{foreachelse}
Expand All @@ -51,7 +51,7 @@
</ul>
</div>
{/if}
<h4><em>{ts}Add question{/ts} <a href="{crmURL p='civicrm/chat/question/add' q="conversationTypeId=`$conversationType.id`"}" role="button"><i class="crm-i fa-plus"></i></a></em></h4>
<h4><em>{ts}Add question{/ts} <a href="{crmURL p='civicrm/chat/question/add' q="conversationTypeId=`$conversationType.id`"}" role="button"><i class="crm-i fa-plus" role="img" aria-hidden="true"></i></a></em></h4>
<p>{ts}Conversation timeout:{/ts} {$conversationType.timeout} {ts}minutes{/ts}</p>
<br/><br/>
<p>
Expand Down