Skip to content

Commit ef046f3

Browse files
LucioFrancoonelesd
andauthored
[2/n] Remove otel layer from tracing logger (#3041)
<!-- CURSOR_SUMMARY --> > [!NOTE] > Drops OTEL log export and related config/deps, simplifying logger setup and call sites. > > - **Logging (framework-cli)**: > - Remove OpenTelemetry/OTLP export layer and related code (`export_to`, OTEL layer creation, `LoggerError`, `CustomFields`). > - Simplify `setup_logging` API (no `machine_id`) and modern/legacy setup paths; retain session ID option and file/stdout outputs. > - **CLI main**: > - Update call site to `setup_logging(&config.logger)` and retrieve `machine_id` afterward. > - **Dependencies**: > - Remove `opentelemetry*` crates and appender from `Cargo.toml` and lockfile; adjust transitive references to generic `opentelemetry` where needed. > - Clean up cargo-machete ignored list (drop `opentelemetry-http`). > > <sup>Written by [Cursor Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit 2244806. This will update automatically on new commits. Configure [here](https://cursor.com/dashboard?tab=bugbot).</sup> <!-- /CURSOR_SUMMARY --> --------- Co-authored-by: Dave Seleno <958603+onelesd@users.noreply.github.com>
1 parent a225eff commit ef046f3

File tree

4 files changed

+63
-402
lines changed

4 files changed

+63
-402
lines changed

Cargo.lock

Lines changed: 14 additions & 119 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

apps/framework-cli/Cargo.toml

Lines changed: 2 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@ convert_case = "0.6.0"
3535
humantime = "2.1.0"
3636
uuid = { version = "1.6", features = ["v4", "serde"] }
3737
serde_json = { version = "1.0.133", features = ["preserve_order"] }
38-
serde_urlencoded = "0.7"
38+
serde_urlencoded = "0.7"
3939
semver = "1.0"
4040
base64 = "0.22.0"
4141
async-recursion = "1.1.0"
@@ -84,23 +84,6 @@ logos = "0.15.0"
8484
# Monitoring
8585
tracing = "0.1.40"
8686
tracing-subscriber = { version = "0.3", features = ["env-filter", "json", "fmt"] }
87-
opentelemetry_sdk = { version = "0.29.0", features = [
88-
"logs",
89-
"metrics",
90-
"trace",
91-
"rt-tokio",
92-
] }
93-
opentelemetry-semantic-conventions = "0.29"
94-
opentelemetry = "0.29"
95-
opentelemetry-appender-tracing = "0.29.0"
96-
opentelemetry-otlp = { version = "0.29.0", default-features = false, features = [
97-
"logs",
98-
"metrics",
99-
"trace",
100-
"http-json",
101-
"tokio",
102-
] }
103-
opentelemetry-http = { version = "0.29.0", features = ["reqwest"] }
10487
prometheus-client = "0.23"
10588
serde_yaml = "0.9.34"
10689
temporal-sdk-core = { git = "https://github.com/temporalio/sdk-core.git", rev = "b94b2fc172c2740705b3454a0e04b856fe426233" }
@@ -137,4 +120,4 @@ walkdir = "2"
137120
used_linker = []
138121

139122
[package.metadata.cargo-machete]
140-
ignored = ["opentelemetry-http", "prost-types", "rustpython-ast"]
123+
ignored = ["prost-types", "rustpython-ast"]

0 commit comments

Comments
 (0)