Add proptest for all the parsers & fix bugs #2974
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Created using jj-spr 1.3.6-beta.1
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
Author
|
Undrafting this so cursor will give me a description |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note
Adds proptest-based tests and regressions across parsers, fixes UTF-8 panic in timeout parsing, and normalizes JSON empty-params equality in the ClickHouse type parser.
proptestinfrastructure (proptest.toml) and regression seed files underapps/framework-cli/proptest-regressions/**.framework/scripts/utils.rs,framework/versions.rs,infrastructure/olap/clickhouse/sql_parser.rs, and.../type_parser.rs(with custom generators).Cargo.tomldev-deps: addproptest,proptest-derive.framework/scripts/utils.rs: makeparse_timeout_to_secondsUTF-8 safe (no panics on multi-byte chars); add regression test..../type_parser.rs: implement customPartialEq(andEq) forClickHouseTypeNodesoJSON(Some([]))equalsJSON(None); add regression test and roundtrip properties.PROPTEST_FINDINGS.mddocumenting discovered issues and fixes.syndep versions (via transitive updates).Written by Cursor Bugbot for commit 4d9d42d. This will update automatically on new commits. Configure here.