Tim/pmm 534 new templates experience #2999
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
| // Get filter values from URL params | ||
| const typeFilter = (searchParams.get("type") as TypeFilter) || null; | ||
| const languageFilter = | ||
| (searchParams.get("language") as LanguageFilter) || null; |
There was a problem hiding this comment.
Bug: Unvalidated Filters Cause UI State Inconsistency
The typeFilter and languageFilter values are cast from URL params without validation, unlike categoryFilter which properly validates values. This creates inconsistent behavior with TemplateGrid which validates these same params. Invalid URL params like ?type=invalid will cause the sidebar to have no checkboxes selected while the grid shows all items (treating invalid as null), creating confusing UX and state inconsistency between the two components.
tg339
force-pushed
the
tim/pmm-534-new-templates-experience
branch
from
a58dd7a to
54f8a84
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note
Introduce a dedicated
/templatespage with sidebar filters and search, enhanced template/app cards with deploy/actions, and a reusable command snippet, plus routing/content and TS config updates.app/templates/route with layout andTemplatesSideNav(URL-driven filters fortype,language,category).content/templates/index.mdxto use<CommandSnippet />andTemplatesGridServer.TemplateGridreads URL params for filtering; search retained in main content.TemplateCardredesigned: combined chips (frameworks/features) with expand, terminal snippet, and action buttons (Deploy, Blog, GitHub).CommandSnippetvia MDX renderer/components.templatesfrom catch‑all[...slug]routing and from content scanning; adjustgenerateStaticParams.guides/strategy/platform-engineeringpage with metadata/TOC.ui/checkbox,ui/item; tweakui/input,ui/select,ui/commandto usebg-card.globals.css.tsconfigto extend@repo/ts-config/nextjs.json; disable declarations.@radix-ui/react-checkbox,@radix-ui/react-popover; lockfile updates (incl.@clickhouse/clientminor bump)..npmrchoisting inframework-docs-v2.Written by Cursor Bugbot for commit 54f8a84. This will update automatically on new commits. Configure here.