Tim/eng 1368 guides structure #3013
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
| form.setFieldValues(currentValues); | ||
| } | ||
| } | ||
| }, [searchParams, manifest, language]); |
There was a problem hiding this comment.
Bug: Missing form dependency in useEffect
The useEffect hook at line 84 is missing form in its dependency array. The effect reads form.state.values and calls form.setFieldValues, but only includes searchParams, manifest, and language as dependencies. This causes the effect to use stale form state, potentially leading to incorrect form updates or infinite loops when the form state changes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note
Introduces a dynamic, parameterized Guides system with step rendering; creates a dedicated Templates hub with sidebar filters; and updates navigation, UI, and config across docs.
app/guidesroutes (layout.tsx,page.tsx,[...slug]/page.tsx) with dynamic step rendering, TOC integration, and breadcrumbs.guide.toml, cache steps, conditional step inclusion via filename selectors, and render viaGuideForm,DynamicGuideBuilder,GuideStepsWrapper/Nav,StepContent.guides/**/guide-overview.mdxand a full example (performant-dashboards) with flows/options and step files.app/templateswith layout, sidebar filters (TemplatesSideNavwith URL-basedtype/language/category), and page rendering.TemplateGrid, richerTemplateCard(chips, deploy/blog/github), andCommandSnippetcomponent.templates/andguides/from catch-all route params and handling.Checkbox,Popover,Item*; tweakInput/Commandto usebg-card.cacheComponentsin Next config; switchrobots.txthost/sitemap; simplifypublic/sitemap.xml.@tanstack/react-form,@tanstack/zod-adapter,zod), new Radix packages; introduce Biome config; update TS configs tonextjs.json.Written by Cursor Bugbot for commit 2f5b495. This will update automatically on new commits. Configure here.