Allow for empty db (to support pre-prefixed tables) #3036
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
georgevanderson
requested review from
phiSgr
and removed request for
callicles
jmsuzuki
approved these changes
Nov 26, 2025
georgevanderson
force-pushed
the
empty-db-case
branch
from
a0ccd10 to
d53b7e8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note
Adjust
Table::idto skip database prefix when the resolved database is empty, adding tests for legacy, versioned, and fully-qualified cases.Table::idto not prepend database whendbis empty, while still skipping prefix for fully-qualified names containing a dot.default_database(with and without version) ensuring IDs lack db prefix.Written by Cursor Bugbot for commit d53b7e8. This will update automatically on new commits. Configure here.