Skip to content

Conversation

@LucioFranco
Copy link
Contributor

@LucioFranco LucioFranco commented Nov 26, 2025

Note

Drops OTEL log export and related config/deps, simplifying logger setup and call sites.

  • Logging (framework-cli):
    • Remove OpenTelemetry/OTLP export layer and related code (export_to, OTEL layer creation, LoggerError, CustomFields).
    • Simplify setup_logging API (no machine_id) and modern/legacy setup paths; retain session ID option and file/stdout outputs.
  • CLI main:
    • Update call site to setup_logging(&config.logger) and retrieve machine_id afterward.
  • Dependencies:
    • Remove opentelemetry* crates and appender from Cargo.toml and lockfile; adjust transitive references to generic opentelemetry where needed.
    • Clean up cargo-machete ignored list (drop opentelemetry-http).

Written by Cursor Bugbot for commit 2244806. This will update automatically on new commits. Configure here.

Created using jj-spr 0.1.0
Created using jj-spr 0.1.0

[skip ci]
@vercel
Copy link

vercel bot commented Nov 26, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
docs-v2 Ready Ready Preview Comment Dec 2, 2025 0:20am
framework-docs Ready Ready Preview Comment Dec 2, 2025 0:20am

@LucioFranco LucioFranco changed the title Remove otel layer from tracing logger [2/n] Remove otel layer from tracing logger Nov 26, 2025
@LucioFranco LucioFranco requested review from a team and callicles November 26, 2025 17:00
Created using jj-spr 0.1.0
Created using jj-spr 0.1.0

[skip ci]
Created using jj-spr 0.1.0
@LucioFranco LucioFranco changed the base branch from spr/lucio/main.remove-otel-layer-from-tracing-logger to main December 2, 2025 00:14
@LucioFranco LucioFranco changed the base branch from main to spr/lucio/main.remove-otel-layer-from-tracing-logger December 2, 2025 00:16
onelesd and others added 2 commits December 1, 2025 16:18
Created using jj-spr 0.1.0

[skip ci]
Created using jj-spr 0.1.0
@LucioFranco LucioFranco changed the base branch from spr/lucio/main.remove-otel-layer-from-tracing-logger to main December 2, 2025 00:27
@LucioFranco LucioFranco added this pull request to the merge queue Dec 2, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 2, 2025
@LucioFranco LucioFranco added this pull request to the merge queue Dec 2, 2025
Merged via the queue into main with commit ef046f3 Dec 2, 2025
82 of 83 checks passed
@LucioFranco LucioFranco deleted the spr/lucio/remove-otel-layer-from-tracing-logger branch December 2, 2025 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants