Skip to content

Conversation

@hh2110
Copy link
Collaborator

@hh2110 hh2110 commented Nov 30, 2025

Summary

  • Add support for ignoring LowCardinality differences in column comparisons
  • Enhance column equivalence logic to handle IgnoreStringLowCardinalityDifferences flag
  • Add comprehensive test coverage for LowCardinality normalization functionality

Co-Authored-By: Claude noreply@anthropic.com


Note

Adds IgnoreStringLowCardinalityDifferences to ignore String vs LowCardinality(String) differences in table/column comparisons, with full propagation and tests.

  • Diff/Schema Comparison:
    • Add IgnorableOperation::IgnoreStringLowCardinalityDifferences and integrate into normalize_table_for_diff to strip LowCardinality annotations when ignored.
    • Extend compute_table_columns_diff and columns_are_equivalent to accept ignore_ops and normalize columns accordingly.
    • Update ClickHouse diff strategy helpers (nested_are_equivalent, column_types_are_equivalent, json_options_are_equivalent) to accept ignore_low_cardinality and compare types semantically.
  • Call Sites:
    • Update usages to pass the new parameter (default &[]) in CLI routines and infra diff utilities (simple_table_diff, lifecycle variants, tests).
  • Tests:
    • Add comprehensive tests for LowCardinality-ignore behavior across columns, nested types, JSON typed paths, normalization, and table-level normalization; verify non-LowCardinality differences still detected.

Written by Cursor Bugbot for commit 19de4ab. This will update automatically on new commits. Configure here.

@vercel
Copy link

vercel bot commented Nov 30, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
docs-v2 Ready Ready Preview Comment Dec 1, 2025 5:03am
framework-docs Ready Ready Preview Comment Dec 1, 2025 5:03am

@hh2110 hh2110 marked this pull request as ready for review November 30, 2025 21:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants