Skip to content

Feat: Implement Battery Losses #70

@ADGEfficiency

Description

@ADGEfficiency

Description

The current battery model implementation does not properly account for energy losses during charge and discharge cycles. In the step() function, losses are initialized but never calculated based on the battery efficiency parameter (efficiency_pct). This means the model operates with a perfect 100% efficiency despite having an efficiency parameter.

Background

Battery energy storage systems (BESS) experience energy losses during both charge and
discharge cycles due to factors like:

  • AC-DC conversion losses in power electronics
  • Internal resistance
  • Battery thermal management systems
  • Self-discharge over time

In real-world applications, round-trip efficiencies for lithium-ion batteries typically range
from 85-95%. The current model initializes with efficiency_pct=0.9 (90%) in the constructor
but doesn't use this parameter in energy calculations.

Battery roundtrip efficiency losses should be applied on export energy.

Proposed Changes

  • Implement proper loss calculations using the efficiency_pct parameter
  • Update the step() method to properly handle losses during charging and discharging
  • Fix the conversion between power (MW) and energy (MWh)
  • Update the energy_balance() method to verify energy conservation with losses
  • Add tests that verify energy conservation with losses

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions