Skip to content

[BUG] Custom outputs don't get included in the output folder when using xlsx option #312

@tombisho

Description

@tombisho

Custom outputs don't seem to get included in the output folder when using the xlsx option for the format in the acro_finalise() function. This does not happen with the json format. Maybe I am doing something wrong?

Steps to reproduce the behavior:

  1. Create a custom output with acro_custom_output() (in this case it was a pdf file)
  2. Finalise your outputs, using the xlsx format in the acro_finalise() function
  3. The target folder gets created, but the xlsx file doesn't mention the custom output, nor is the file included
  4. Finalise your outputs into a different folder, using the json format in the acro_finalise() function
  5. The target folder gets created, the json file mentions the custom output, and is the file included.

I would expect the xlsx option to behave the similar to the json option, in that the custom file is mentioned and included.

Version - add_conda branch (i.e. 0.1.6)

(as an aside, I wanted to use the xlsx format because 1. our TRE is Rocky Linux and can't use the .deb ACRO Viewer 2. Our Windows desktops don't allow us to install an .msi without going through a semi-painful process of asking for an exception)

Metadata

Metadata

Assignees

Labels

bugSomething isn't workinggood first issueGood for newcomers

Type

Projects

No projects

Relationships

None yet

Development

No branches or pull requests

Issue actions