[Chore] Remove all in-file disable pragmas

[rpreen]

There are a lot of disgusting pylint: disable pragmas littering the code base: they should be removed completely - pylint is not used directly any more because it's slow and Ruff can perform those same checks, so they are useless.

Standards as defined in the pyproject.toml to keep the source readable and to have a single place to view what has been set. Some of the pylint checks are commented out (probably because they would fail), but it would be good to also see what can be enabled by adding per-file ignores and exclusions to carefully achieve the same as the in-file pragmas until refactoring is done later.

ACRO/pyproject.toml

Lines 94 to 128 in 50b6c6c

	lint.select = [
	# "ANN", # flake8-annotations
	"ARG", # flake8-unused-arguments
	"B", # flake8-bugbear
	# "C4", # flake8-comprehensions
	"C90", # mccabe
	"D", # pydocstyle
	# "DTZ", # flake8-datetimez
	# "E", # pycodestyle
	# "EM", # flake8-errmsg
	# "ERA", # eradicate
	"F", # Pyflakes
	"I", # isort
	"ICN", # flake8-import-conventions
	"N", # pep8-naming
	# "PD", # pandas-vet
	"PGH", # pygrep-hooks
	"PIE", # flake8-pie
	# "PL", # Pylint
	"PLC", # Pylint
	"PLE", # Pylint
	# "PLR", # Pylint
	# "PLW", # Pylint
	"PT", # flake8-pytest-style
	"Q", # flake8-quotes
	# "RET", # flake8-return
	"RUF100", # Ruff-specific
	# "S", # flake8-bandit
	# "SIM", # flake8-simplify
	# "T20", # flake8-print
	"TID", # flake8-tidy-imports
	"UP", # pyupgrade
	"W", # pycodestyle
	"YTT", # flake8-2020
	]

[rpreen]

Generally it would be good to see how many of those extra checks we can enable (even if it requires a couple of specific exclusions) to improve overall code quality and find any problems. Also, that list itself is probably not exhaustive there could be other checks we can add.

[ssrhaso]

Hi @rpreen , two questions before I start on this issue more concretely:

1. Should pragma removal + enabling new ruff rule sets be one PR or two separate ones?
2. For violations like too-many-arguments, should i just migrate the suppression to per-file-ignores in pyproject.toml for now, or attempt actual refactoring?

[rpreen]

Yes, removal of the existing pylint inline pragmas and enabling equivalent checks in Ruff should be two separate PRs.

1. Remove pylint pragmas. We don't run pylint directly, so the existing pragmas should have no effect. Verify this is the case, then remove them in a straightforward cleanup PR.
2. Enable Ruff checks. Turning on the equivalent Ruff rules will surface a large number of violations. The goal is to enable as many checks as reasonably possible without an excessive amount of churn.

For the Ruff checks, I suggest configuring settings first. Some checks can probably be satisfied via pyproject.toml rather than code changes (e.g., raising the too-many-arguments threshold). Prefer this over per-file ignores where possible. Add per-file ignores sparingly: if a check can be silenced for a small number of files, a per-file-ignores entry is acceptable. If every file needs ignoring, the check probably shouldn't be enabled yet. Identify refactoring candidates. if enabling a check requires straightforward code fixes rather than just configuration, note those but don't make the changes here. Each one should be a dedicated follow-up PR.

It may turn out that several checks require too much work to enable right now - this is an investigation as much as a migration.