generated from AOSSIE-Org/Template-Repo
-
-
Notifications
You must be signed in to change notification settings - Fork 28
Open
Labels
enhancementNew feature or requestNew feature or request
Description
Feature and its Use Cases
Overview
The repository currently lacks unit tests for two utility functions:
create_tokenizer in tests/test_tokenizer.py and load_merkle_proof in tests/test_util.py
- This lack of test coverage creates blind spots, making the code harder to safely refactor and potentially allowing bugs to be introduced without being detected by our test suite.
Example scenarios to test:
- When "bpe" is passed, the function should return an instance of the BPE tokenizer class.
- When "sentencepiece" is passed, the function should return an instance of the SentencePiece tokenizer class.
- When an unsupported tokenizer type is passed, the function should raise a ValueError.
- Loading a valid JSON Merkle proof file returns the expected structure.
- Attempting to load a non-existent file raises FileNotFoundError.
- Attempting to load invalid JSON raises a parsing exception.
Acceptance Criteria
- Unit tests exist for both create_tokenizer and load_merkle_proof.
- Tests cover both successful execution and failure scenarios.
- All tests pass when running:
Additional Context
No response
Code of Conduct
- I have joined the Discord server and will post updates there
- I have searched existing issues to avoid duplicates
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
enhancementNew feature or requestNew feature or request