"disconnect" parameter in TargetManager cannot be configured

[ep1cman]

I am trying to create a new connection type for WA which requires disconnect to be called, but looking in TargetManager the disconnect parameter defaults to False and cannot be overridden.

TargetManager gets passed device_config:

        self.target_manager = TargetManager(config.run_config.device,
                                            config.run_config.device_config,
                                            output.basepath)

from which it extracts the disconnect parameter, but if you try to specify it in an agenda it give an error that this is an unexpected value due to it not being a parameter of the target:

 Unexpected values for device_config: {'disconnect': True}

If you add it (with a default of True) to the list of conn_param when calling add_description_for_target it gets picked up by the TargetManager but it then causes an issue further down the line because the connection class doesn't know about this parameter:

TypeError(SshConnection.__init__() got an unexpected keyword argument 'disconnect')

I can see in the code that there is a special case added for the Gem5 connection to work around this

if self.disconnect or isinstance(self.target.platform, Gem5SimulationPlatform):