Skip to content

Commit 3edc54b

Browse files
committed
Remove BlockingUtils#asIO & monix-bio optional dependency
Recently, we've ran into a problem, where some usages of `BlockingUtils` which involved Java code would not respect the optionality of monix-bio on the classpath. Since there's only a single usage for monix-bio in the commons library and the maintenance status of the library is questionable, I'd like to propose removing the optional dependency. Removed method can be easily restored in the projects if at all needed.
1 parent 48416c6 commit 3edc54b

File tree

2 files changed

+0
-6
lines changed

2 files changed

+0
-6
lines changed

core/jvm/src/main/scala/com/avsystem/commons/concurrent/BlockingUtils.scala

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,6 @@ import com.avsystem.commons.collection.CloseableIterator
55
import monix.eval.Task
66
import monix.execution.Scheduler
77
import monix.reactive.Observable
8-
import monix.bio.IO
98

109
import scala.concurrent.Await
1110
import scala.concurrent.duration._
@@ -39,9 +38,6 @@ abstract class BlockingUtils {
3938
def asTask[T](blockingCode: => T): Task[T] =
4039
Task.eval(blockingCode).executeOn(ioScheduler, forceAsync = true)
4140

42-
def asIO[A, B](blockingCode: => Either[A, B]): IO[A, B] =
43-
IO.deferTotal(IO.fromEither(blockingCode)).executeOn(ioScheduler, forceAsync = true)
44-
4541
def await[T](future: Future[T]): T =
4642
await(future, defaultTimeout)
4743

project/Commons.scala

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,6 @@ object Commons extends ProjectGroup("commons") {
3737
val scalaLoggingVersion = "3.9.5"
3838
val akkaVersion = "2.6.19"
3939
val monixVersion = "3.4.1"
40-
val monixBioVersion = "1.2.0"
4140
val circeVersion = "0.14.5" // benchmark only
4241
val upickleVersion = "3.1.2" // benchmark only
4342
val scalajsBenchmarkVersion = "0.10.0"
@@ -287,7 +286,6 @@ object Commons extends ProjectGroup("commons") {
287286
"com.google.code.findbugs" % "jsr305" % jsr305Version % Optional,
288287
"com.google.guava" % "guava" % guavaVersion % Optional,
289288
"io.monix" %% "monix" % monixVersion % Optional,
290-
"io.monix" %% "monix-bio" % monixBioVersion % Optional,
291289
),
292290
)
293291

0 commit comments

Comments
 (0)