Skip to content

Commit 5b9b974

Browse files
committed
More conditional includes review fixes
1 parent c505aeb commit 5b9b974

File tree

1 file changed

+12
-11
lines changed

1 file changed

+12
-11
lines changed

commons-spring/src/main/scala/com/avsystem/commons/spring/HoconBeanDefinitionReader.scala

Lines changed: 12 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -16,8 +16,8 @@ import scala.annotation.nowarn
1616
class HoconBeanDefinitionReader(registry: BeanDefinitionRegistry)
1717
extends AbstractBeanDefinitionReader(registry) {
1818

19+
import com.avsystem.commons.spring.HoconBeanDefinitionReader.Keys._
1920
import com.typesafe.config.ConfigValueType._
20-
import com.avsystem.commons.spring.HoconBeanDefinitionReader._
2121

2222
private implicit class ConfigValueExtensions(value: ConfigValue) {
2323
def as[T: HoconType] =
@@ -347,15 +347,14 @@ class HoconBeanDefinitionReader(registry: BeanDefinitionRegistry)
347347

348348
private def readConditionals(config: Config): Config = {
349349
if (!config.hasPath(Conditionals)) config
350-
else config.getList(Conditionals).asScala.foldLeft(config.withoutPath(Conditionals))((currentConfig, conditionalObject) => {
350+
else config.getList(Conditionals).asScala.foldLeft(config.withoutPath(Conditionals)) { (currentConfig, conditionalObject) =>
351351
val props = getProps(conditionalObject.as[ConfigObject])
352352

353-
if (props.get(Condition).exists(_.as[Boolean])) {
353+
if (props(Condition).as[Boolean])
354354
readConditionals(props(Config).as[Config]).withFallback(currentConfig)
355-
} else {
355+
else
356356
currentConfig
357-
}
358-
})
357+
}
359358
}
360359

361360
def loadBeanDefinitions(resourceConfig: Config): Int = {
@@ -371,9 +370,11 @@ class HoconBeanDefinitionReader(registry: BeanDefinitionRegistry)
371370
loadBeanDefinitions(ConfigFactory.parseURL(resource.getURL).resolve)
372371
}
373372
object HoconBeanDefinitionReader {
374-
val Conditionals = "conditionals"
375-
val Condition = "condition"
376-
val Config = "config"
377-
val Beans = "beans"
378-
val Aliases = "aliases"
373+
object Keys {
374+
final val Conditionals = "conditionals"
375+
final val Condition = "condition"
376+
final val Config = "config"
377+
final val Beans = "beans"
378+
final val Aliases = "aliases"
379+
}
379380
}

0 commit comments

Comments
 (0)