From 367c2e7f327832ffbd5562a71197f6bdb6b3e66e Mon Sep 17 00:00:00 2001
From: Rucha Mahabal <ruchamahabal2@gmail.com>
Date: Wed, 3 Apr 2024 07:27:31 +0530
Subject: [PATCH 01/10] feat: geolocation in Employee Checkin

---
 .../employee_checkin/employee_checkin.json    | 34 +++++++++++++++++--
 .../employee_checkin/employee_checkin.py      | 14 ++++++++
 2 files changed, 46 insertions(+), 2 deletions(-)

diff --git a/hrms/hr/doctype/employee_checkin/employee_checkin.json b/hrms/hr/doctype/employee_checkin/employee_checkin.json
index 146254d9e4..cacfb51e3a 100644
--- a/hrms/hr/doctype/employee_checkin/employee_checkin.json
+++ b/hrms/hr/doctype/employee_checkin/employee_checkin.json
@@ -15,8 +15,13 @@
   "device_id",
   "skip_auto_attendance",
   "attendance",
+  "location_section",
+  "coordinates",
+  "geolocation",
+  "shift_timings_section",
   "shift_start",
   "shift_end",
+  "column_break_vyyt",
   "shift_actual_start",
   "shift_actual_end"
  ],
@@ -107,10 +112,35 @@
    "fieldtype": "Datetime",
    "hidden": 1,
    "label": "Shift Actual End"
+  },
+  {
+   "fieldname": "location_section",
+   "fieldtype": "Section Break",
+   "label": "Location"
+  },
+  {
+   "fieldname": "coordinates",
+   "fieldtype": "Data",
+   "label": "Coordinates",
+   "read_only": 1
+  },
+  {
+   "fieldname": "geolocation",
+   "fieldtype": "Geolocation",
+   "label": "Geolocation"
+  },
+  {
+   "fieldname": "shift_timings_section",
+   "fieldtype": "Section Break",
+   "label": "Shift Timings"
+  },
+  {
+   "fieldname": "column_break_vyyt",
+   "fieldtype": "Column Break"
   }
  ],
  "links": [],
- "modified": "2024-04-02 01:50:23.150627",
+ "modified": "2024-04-03 06:36:07.640893",
  "modified_by": "Administrator",
  "module": "HR",
  "name": "Employee Checkin",
@@ -210,4 +240,4 @@
  "states": [],
  "title_field": "employee_name",
  "track_changes": 1
-}
\ No newline at end of file
+}
diff --git a/hrms/hr/doctype/employee_checkin/employee_checkin.py b/hrms/hr/doctype/employee_checkin/employee_checkin.py
index 8524b6ef6a..7a5e784a76 100644
--- a/hrms/hr/doctype/employee_checkin/employee_checkin.py
+++ b/hrms/hr/doctype/employee_checkin/employee_checkin.py
@@ -18,6 +18,7 @@ def validate(self):
 		validate_active_employee(self.employee)
 		self.validate_duplicate_log()
 		self.fetch_shift()
+		self.set_geolocation_coordinates()
 
 	def validate_duplicate_log(self):
 		doc = frappe.db.exists(
@@ -60,6 +61,19 @@ def fetch_shift(self):
 		else:
 			self.shift = None
 
+	def set_geolocation_coordinates(self):
+		if not self.geolocation:
+			return
+
+		try:
+			self.coordinates = str(get_coordinates_from_geolocation(self.geolocation))
+		except Exception:
+			frappe.log_error("Error parsing geolocation field")
+
+
+def get_coordinates_from_geolocation(geolocation: str):
+	return frappe.parse_json(geolocation)["features"][0]["geometry"]["coordinates"]
+
 
 @frappe.whitelist()
 def add_log_based_on_employee_field(

From 56dca0511344b519c9d2eb6af87dcdb624a83b54 Mon Sep 17 00:00:00 2001
From: Rucha Mahabal <ruchamahabal2@gmail.com>
Date: Wed, 3 Apr 2024 07:29:07 +0530
Subject: [PATCH 02/10] feat(PWA): capture geolocation in checkins

---
 frontend/src/components/CheckInPanel.vue | 59 ++++++++++++++++++++++--
 1 file changed, 56 insertions(+), 3 deletions(-)

diff --git a/frontend/src/components/CheckInPanel.vue b/frontend/src/components/CheckInPanel.vue
index 99481e03e8..80dfcc59c9 100644
--- a/frontend/src/components/CheckInPanel.vue
+++ b/frontend/src/components/CheckInPanel.vue
@@ -9,7 +9,7 @@
 			<Button
 				class="mt-4 mb-1 drop-shadow-sm py-5 text-base"
 				id="open-checkin-modal"
-				@click="checkinTimestamp = dayjs().format('YYYY-MM-DD HH:mm:ss')"
+				@click="fetchLocation"
 			>
 				<template #prefix>
 					<FeatherIcon
@@ -26,8 +26,8 @@
 				:initial-breakpoint="1"
 				:breakpoints="[0, 1]"
 			>
-				<div class="h-40 w-full flex flex-col items-center justify-center gap-5 p-4 mb-5">
-					<div class="flex flex-col gap-1.5 items-center justify-center">
+				<div class="h-120 w-full flex flex-col items-center justify-center gap-5 p-4 mb-5">
+					<div class="flex flex-col gap-1.5 mt-2 items-center justify-center">
 						<div class="font-bold text-xl">
 							{{ dayjs(checkinTimestamp).format("hh:mm:ss a") }}
 						</div>
@@ -35,6 +35,22 @@
 							{{ dayjs().format("D MMM, YYYY") }}
 						</div>
 					</div>
+					<div v-if="locationStatus">
+						<span class="font-medium text-gray-500 text-sm">
+							{{ locationStatus }}
+						</span>
+
+						<iframe
+							width="370"
+							height="170"
+							frameborder="1"
+							scrolling="no"
+							marginheight="0"
+							marginwidth="0"
+							:src="`https://maps.google.com/maps?q=${latitude},${longitude}&hl=en&z=15&amp;output=embed`"
+						>
+						</iframe>
+					</div>
 					<Button
 						variant="solid"
 						class="w-full py-5 text-sm"
@@ -64,6 +80,9 @@ const socket = inject("$socket")
 const employee = inject("$employee")
 const dayjs = inject("$dayjs")
 const checkinTimestamp = ref(null)
+const latitude = ref("")
+const longitude = ref("")
+const locationStatus = ref("")
 
 const checkins = createListResource({
 	doctype: DOCTYPE,
@@ -102,6 +121,40 @@ const lastLogTime = computed(() => {
 	return `${formattedTime} on ${dayjs(timestamp).format("D MMM, YYYY")}`
 })
 
+function success(position) {
+	latitude.value = position.coords.latitude
+	longitude.value = position.coords.longitude
+
+	locationStatus.value = `Latitude: ${latitude.value} °, Longitude: ${longitude.value} °`
+}
+
+function error() {
+	locationStatus.value = "Unable to retrieve your location"
+}
+
+const fetchLocation = () => {
+	checkinTimestamp.value = dayjs().format("YYYY-MM-DD HH:mm:ss")
+
+	if (!navigator.geolocation) {
+		locationStatus.value =
+			"Geolocation is not supported by your current browser"
+	} else {
+		locationStatus.value = "Locating..."
+		navigator.geolocation.getCurrentPosition(success, error)
+	}
+
+	if ("geolocation" in navigator) {
+	} else {
+		toast({
+			title: "Error",
+			text: "Your current browser does not support geolocation",
+			icon: "alert-circle",
+			position: "bottom-center",
+			iconClasses: "text-red-500",
+		})
+	}
+}
+
 const submitLog = (logType) => {
 	const action = logType === "IN" ? "Check-in" : "Check-out"
 

From 2ade1f3a4814ac093ac94a8be507c02315e51a98 Mon Sep 17 00:00:00 2001
From: Rucha Mahabal <ruchamahabal2@gmail.com>
Date: Wed, 3 Apr 2024 09:02:19 +0530
Subject: [PATCH 03/10] style: add border-radius to map iframe

---
 frontend/src/components/CheckInPanel.vue | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/frontend/src/components/CheckInPanel.vue b/frontend/src/components/CheckInPanel.vue
index 80dfcc59c9..624d5681c3 100644
--- a/frontend/src/components/CheckInPanel.vue
+++ b/frontend/src/components/CheckInPanel.vue
@@ -35,7 +35,7 @@
 							{{ dayjs().format("D MMM, YYYY") }}
 						</div>
 					</div>
-					<div v-if="locationStatus">
+					<div v-if="locationStatus" class="rounded border-4 translate-z-0 block overflow-hidden w-350 h-170">
 						<span class="font-medium text-gray-500 text-sm">
 							{{ locationStatus }}
 						</span>

From 662abbd464cf4a7aa940a22ee516e6d30d1f7b80 Mon Sep 17 00:00:00 2001
From: Rucha Mahabal <ruchamahabal2@gmail.com>
Date: Wed, 3 Apr 2024 09:20:13 +0530
Subject: [PATCH 04/10] fix: show fixed no of digits in location coordinates

---
 frontend/src/components/CheckInPanel.vue | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/frontend/src/components/CheckInPanel.vue b/frontend/src/components/CheckInPanel.vue
index 624d5681c3..7a024335a0 100644
--- a/frontend/src/components/CheckInPanel.vue
+++ b/frontend/src/components/CheckInPanel.vue
@@ -125,7 +125,10 @@ function success(position) {
 	latitude.value = position.coords.latitude
 	longitude.value = position.coords.longitude
 
-	locationStatus.value = `Latitude: ${latitude.value} °, Longitude: ${longitude.value} °`
+	locationStatus.value = `
+		Latitude: ${Number(latitude.value).toFixed(5)} °,
+		Longitude: ${Number(longitude.value).toFixed(5)} °
+	`
 }
 
 function error() {

From 13dc65223ed3c695ce2ccfc3b5bc47704f173761 Mon Sep 17 00:00:00 2001
From: Apavayan Sinha <info@apavayan.com>
Date: Thu, 25 Apr 2024 17:23:12 +0530
Subject: [PATCH 05/10] feat: update api for geolocation in Employee Checkin

---
 hrms/hr/doctype/employee_checkin/employee_checkin.py | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/hrms/hr/doctype/employee_checkin/employee_checkin.py b/hrms/hr/doctype/employee_checkin/employee_checkin.py
index 7a5e784a76..9c48b8a5c0 100644
--- a/hrms/hr/doctype/employee_checkin/employee_checkin.py
+++ b/hrms/hr/doctype/employee_checkin/employee_checkin.py
@@ -83,6 +83,7 @@ def add_log_based_on_employee_field(
 	log_type=None,
 	skip_auto_attendance=0,
 	employee_fieldname="attendance_device_id",
+	geolocation=None,
 ):
 	"""Finds the relevant Employee using the employee field value and creates a Employee Checkin.
 
@@ -92,6 +93,7 @@ def add_log_based_on_employee_field(
 	:param log_type: (optional)Direction of the Punch if available (IN/OUT).
 	:param skip_auto_attendance: (optional)Skip auto attendance field will be set for this log(0/1).
 	:param employee_fieldname: (Default: attendance_device_id)Name of the field in Employee DocType based on which employee lookup will happen.
+	:param geolocation: (optional)Geolocation in the format of GeoJSON. A JSON string is expected.
 	"""
 
 	if not employee_field_value or not timestamp:
@@ -118,6 +120,8 @@ def add_log_based_on_employee_field(
 	doc.time = timestamp
 	doc.device_id = device_id
 	doc.log_type = log_type
+	doc.geolocation = geolocation
+	doc.coordinates = get_coordinates_from_geolocation(str(geolocation))
 	if cint(skip_auto_attendance) == 1:
 		doc.skip_auto_attendance = "1"
 	doc.insert()

From 5ca62fd69f79d20c0dbca1be33c93ab7b6a7bbf7 Mon Sep 17 00:00:00 2001
From: Apavayan Sinha <info@apavayan.com>
Date: Thu, 25 Apr 2024 17:26:21 +0530
Subject: [PATCH 06/10] feat(PWA): show upto 7 floating digits

---
 frontend/src/components/CheckInPanel.vue | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/frontend/src/components/CheckInPanel.vue b/frontend/src/components/CheckInPanel.vue
index 7a024335a0..adf4d770c9 100644
--- a/frontend/src/components/CheckInPanel.vue
+++ b/frontend/src/components/CheckInPanel.vue
@@ -126,8 +126,8 @@ function success(position) {
 	longitude.value = position.coords.longitude
 
 	locationStatus.value = `
-		Latitude: ${Number(latitude.value).toFixed(5)} °,
-		Longitude: ${Number(longitude.value).toFixed(5)} °
+		Latitude: ${Number(latitude.value).toFixed(7)} °,
+		Longitude: ${Number(longitude.value).toFixed(7)} °
 	`
 }
 

From 78b570422002fefe22c0adf37a2dcbcca840a49f Mon Sep 17 00:00:00 2001
From: Apavayan Sinha <info@apavayan.com>
Date: Thu, 25 Apr 2024 17:27:25 +0530
Subject: [PATCH 07/10] feat(PWA): Update Mobile app Zoom Level

---
 frontend/src/components/CheckInPanel.vue | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/frontend/src/components/CheckInPanel.vue b/frontend/src/components/CheckInPanel.vue
index adf4d770c9..273516601d 100644
--- a/frontend/src/components/CheckInPanel.vue
+++ b/frontend/src/components/CheckInPanel.vue
@@ -47,7 +47,7 @@
 							scrolling="no"
 							marginheight="0"
 							marginwidth="0"
-							:src="`https://maps.google.com/maps?q=${latitude},${longitude}&hl=en&z=15&amp;output=embed`"
+							:src="`https://maps.google.com/maps?q=${latitude},${longitude}&hl=en&z=17&amp;output=embed`"
 						>
 						</iframe>
 					</div>

From fe61292d2e88e36277f2721b58f282ae23785944 Mon Sep 17 00:00:00 2001
From: Apavayan Sinha <info@apavayan.com>
Date: Thu, 25 Apr 2024 17:33:54 +0530
Subject: [PATCH 08/10] feat: Add geolocation data to check-in log

---
 frontend/src/components/CheckInPanel.vue | 1 +
 1 file changed, 1 insertion(+)

diff --git a/frontend/src/components/CheckInPanel.vue b/frontend/src/components/CheckInPanel.vue
index 273516601d..bfb746b920 100644
--- a/frontend/src/components/CheckInPanel.vue
+++ b/frontend/src/components/CheckInPanel.vue
@@ -166,6 +166,7 @@ const submitLog = (logType) => {
 			employee: employee.data.name,
 			log_type: logType,
 			time: checkinTimestamp.value,
+			geolocation: `{"type":"FeatureCollection","features":[{"type":"Feature","properties":{},"geometry":{"type":"Point","coordinates":[${longitude.value},${latitude.value}]}}]}`
 		},
 		{
 			onSuccess() {

From ccf47b4bf7ee63d7caab8669892b7ec579fdc9b8 Mon Sep 17 00:00:00 2001
From: Apavayan Sinha <info@apavayan.com>
Date: Thu, 25 Apr 2024 17:56:16 +0530
Subject: [PATCH 09/10] feat(PWA): disable confirm button untill location
 fetched

---
 frontend/src/components/CheckInPanel.vue | 1 +
 1 file changed, 1 insertion(+)

diff --git a/frontend/src/components/CheckInPanel.vue b/frontend/src/components/CheckInPanel.vue
index bfb746b920..ea356477b7 100644
--- a/frontend/src/components/CheckInPanel.vue
+++ b/frontend/src/components/CheckInPanel.vue
@@ -55,6 +55,7 @@
 						variant="solid"
 						class="w-full py-5 text-sm"
 						@click="submitLog(nextAction.action)"
+						@disabled="!latitude || !longitude"
 					>
 						Confirm {{ nextAction.label }}
 					</Button>

From 723c7ba005445d0caea015d5619cbdaeb56a3d82 Mon Sep 17 00:00:00 2001
From: "dependabot[bot]" <49699333+dependabot[bot]@users.noreply.github.com>
Date: Thu, 2 May 2024 18:40:24 +0000
Subject: [PATCH 10/10] chore(deps): bump ejs from 3.1.9 to 3.1.10 in /frontend

Bumps [ejs](https://github.com/mde/ejs) from 3.1.9 to 3.1.10.
- [Release notes](https://github.com/mde/ejs/releases)
- [Commits](https://github.com/mde/ejs/compare/v3.1.9...v3.1.10)

---
updated-dependencies:
- dependency-name: ejs
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
---
 frontend/yarn.lock | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/frontend/yarn.lock b/frontend/yarn.lock
index 6f389c65ba..ac335744fc 100644
--- a/frontend/yarn.lock
+++ b/frontend/yarn.lock
@@ -2697,9 +2697,9 @@ doctrine@^3.0.0:
     esutils "^2.0.2"
 
 ejs@^3.1.6:
-  version "3.1.9"
-  resolved "https://registry.yarnpkg.com/ejs/-/ejs-3.1.9.tgz#03c9e8777fe12686a9effcef22303ca3d8eeb361"
-  integrity sha512-rC+QVNMJWv+MtPgkt0y+0rVEIdbtxVADApW9JXrUVlzHetgcyczP/E7DJmWJ4fJCZF2cPcBk0laWO9ZHMG3DmQ==
+  version "3.1.10"
+  resolved "https://registry.yarnpkg.com/ejs/-/ejs-3.1.10.tgz#69ab8358b14e896f80cc39e62087b88500c3ac3b"
+  integrity sha512-UeJmFfOrAQS8OJWPZ4qtgHyWExa088/MtK5UEyoJGFH67cDEXkZSviOiKRCZ4Xij0zxI3JECgYs3oKx+AizQBA==
   dependencies:
     jake "^10.8.5"