From 22ee98f0ea4a852129042e9c3b65465f8510bb44 Mon Sep 17 00:00:00 2001 From: yurg Date: Tue, 21 Feb 2017 09:41:46 +0100 Subject: [PATCH] Update CommercePosTransactionBaseActions.php Have faced this one https://www.drupal.org/node/2824865 It's closed as "Works as designed", yet still affects operations at our side, because taxes are being added twice in certain circumstances. It seems, commenting out commerce_tax_calculate_by_type fixes issue in our case, yet it's not quite clear if there are any side effects, caused by code change. We observe no issues so far, doesn't mean there aren't any. It seems the piece of code may be obsolete, yet not 100% sure. --- classes/CommercePosTransactionBaseActions.php | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/classes/CommercePosTransactionBaseActions.php b/classes/CommercePosTransactionBaseActions.php index b717715..5b8a596 100644 --- a/classes/CommercePosTransactionBaseActions.php +++ b/classes/CommercePosTransactionBaseActions.php @@ -200,12 +200,13 @@ public function addProduct($product, $quantity = 1, $combine = TRUE) { $line_item->commerce_pricing_attributes = serialize(array()); } + /* if (module_exists('commerce_tax')) { foreach (commerce_tax_types() as $name => $type) { commerce_tax_calculate_by_type($line_item, $name); } } - +*/ return $this->addLineItem($line_item, $combine); }