Skip to content

Code review by Shubham Sikriwal #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ShubhSik wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Code review by Shubham Sikriwal #8

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
93 changes: 69 additions & 24 deletions src/main/java/main/GameManager.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,6 +65,8 @@ public static void main(String[] args) {
launch(args);
}



@Override
public void start(Stage primaryStage) {

Expand All @@ -75,36 +77,67 @@ public void start(Stage primaryStage) {
timeManager = new TimeManager();

}
//Graceful Shutdown of the Application to handle potential exceptions during application shutdown
@Override
public void stop() {
try {
if (gameTimer != null) {
gameTimer.stop();
}
music.stop(currentMusic);
} catch (Exception e) {
System.err.println("Error during application shutdown: " + e.getMessage());
} finally {
System.out.println("Application stopped gracefully.");
}
}

//Add try-catch blocks with meaningful error messages to handle potential issues.
public void playSE(URL url) {

se.setFile(url);
se.play(url);
try {
if (url == null) {
throw new IllegalArgumentException("Sound effect URL is null");
}
se.setFile(url);
se.play(url);
} catch (Exception e) {
System.err.println("Error playing sound effect: " + e.getMessage());
}
}
public void playMusic(URL url){

music.setFile(url);
music.play(url);
music.loop(url);
//Add try-catch blocks with meaningful error messages to handle potential issues.
public void playMusic(URL url) {
try {
music.setFile(url);
music.play(url);
music.loop(url);
} catch (Exception e) {
System.err.println("Error playing music: " + e.getMessage());
}
}
public void stopMusic(URL url){

music.stop(url);
}


// Add try-catch blocks if there is an issue with starting the timer, handle it to avoid affecting game flow.
public void startGameTimer() {
startTime = System.nanoTime();
gameTimer = new AnimationTimer() {
@Override
public void handle(long now) {
elapsedTime = (now - startTime) / 1_000_000; // Convert to milliseconds
updateTimerUI();
}
};
gameTimer.start();
try {
startTime = System.nanoTime();
gameTimer = new AnimationTimer() {
@Override
public void handle(long now) {
elapsedTime = (now - startTime) / 1_000_000; // Convert to milliseconds
updateTimerUI();
}
};
gameTimer.start();
} catch (Exception e) {
System.err.println("Error starting the game timer: " + e.getMessage());
}
}



public void stopGameTimer() {
if (gameTimer != null) {
gameTimer.stop();
Expand All @@ -116,17 +149,29 @@ public void stopGameTimer() {
}
}

//Add try-catch blocks with meaningful error messages to handle potential issues.
public void updateTimerUI() {
// Format the time as minutes and seconds
long seconds = elapsedTime / 1000;
long minutes = seconds / 60;
seconds %= 60;
try {
if (ui.timerLabel == null) {
throw new NullPointerException("Timer label is not initialized in the UI");
}

long seconds = elapsedTime / 1000;
long minutes = seconds / 60;
seconds %= 60;

// Display the timer on the UI
ui.timerLabel.setText(String.format("%02d:%02d", minutes, seconds));
// Update the timer label
ui.timerLabel.setText(String.format("%02d:%02d", minutes, seconds));
} catch (Exception e) {
System.err.println("Error updating timer UI: " + e.getMessage());
}
}

public void showLeaderboard() {
List<String> leaderboard = timeManager.getFormattedFastestTimes();
ui.displayLeaderboard(leaderboard); // Add a method in UI to display the leaderboard
}



}