Fixed issue when raw_response is empty. (#39)

Fixes #35

Author: Aleffio

Adyen/client.py

@@ -414,9 +414,8 @@ def _handle_response(self, url, raw_response, raw_request, status_code, headers,
             response = {}
             # If the result can't be parsed into json, most likely is raw html.
             # Some response are neither json or raw html, handle them here:
-
-            response = json_lib.loads(raw_response)
-
+            if raw_response:
+                response = json_lib.loads(raw_response)
             # Pass raised error to error handler.
             self._handle_http_error(url,response,status_code,headers.get('pspReference'),raw_request,raw_response,headers,request_dict)
 
@@ -488,10 +487,10 @@ def _handle_http_error(self, url, response_obj, status_code, psp_ref,
         elif status_code in [400, 422]:
             erstr = "Received validation error with errorCode: %s, message: %s, HTTP Code: %s. Please verify the values provided. Please reach out to support@adyen.com if the problem persists, providing the PSP reference: %s" % (response_obj["errorCode"],response_obj["message"], status_code, psp_ref)
 
-            raise ValueError(erstr)
+            raise AdyenAPIValidationError(erstr)
         elif status_code == 401:
             erstr = "Unable to authenticate with Adyen's Servers. Please verify the credentials set with the Adyen base class. Please reach out to your Adyen Admin if the problem persists"
-            raise ValueError(erstr)
+            raise AdyenAPIAuthenticationError(erstr)
         elif status_code == 403:
             from . import username
 

test/ModificationTest.py

@@ -30,7 +30,7 @@ def test_capture_error_167(self):
         request['modificationAmount'] = {"value": "1234", "currency": "EUR"}
         request['originalReference'] = "YourOriginalReference"
         self.ady.client = self.test.create_client_from_file(422, request, 'test/mocks/capture-error-167.json')
-        self.assertRaisesRegexp(ValueError,"Received validation error with errorCode: 167, message: Original pspReference required for this operation, HTTP Code: 422." +
+        self.assertRaisesRegexp(Adyen.AdyenAPIValidationError,"Received validation error with errorCode: 167, message: Original pspReference required for this operation, HTTP Code: 422." +
                                            " Please verify the values provided. Please reach out to support@adyen.com if the problem persists, providing the PSP reference.*",
                                 self.ady.payment.capture, request)
 

test/PaymentTest.py

@@ -147,7 +147,7 @@ def test_error_401_mocked(self):
             "holderName": "John Doe"
         }
         self.ady.client = self.test.create_client_from_file(401, request, 'test/mocks/authorise-error-010.json')
-        self.assertRaisesRegexp(ValueError, "Unable to authenticate with Adyen's Servers. Please verify the credentials set with the Adyen base class. Please reach out to your Adyen Admin if the problem persists" , self.ady.payment.authorise, request)
+        self.assertRaisesRegexp(Adyen.AdyenAPIAuthenticationError, "Unable to authenticate with Adyen's Servers. Please verify the credentials set with the Adyen base class. Please reach out to your Adyen Admin if the problem persists" , self.ady.payment.authorise, request)
 
 
 TestPayments.client.http_force = "requests"

test/RecurringTest.py

@@ -45,7 +45,7 @@ def test_disable_803(self):
         request["shopperReference"] = "ref"
         request["recurringDetailReference"] = "12345678889"
         self.ady.client = self.test.create_client_from_file(422, request, 'test/mocks/recurring/disable-error-803.json')
-        self.assertRaisesRegexp(ValueError,
+        self.assertRaisesRegexp(Adyen.AdyenAPIValidationError,
                                 "Received validation error with errorCode: 803, message: PaymentDetail not found, HTTP Code: 422.*",
                                 self.ady.recurring.disable, request)