PW-279: Refactor code to PEP8 standards (#41)

- Refactored code
- Added pycodestyle to the Travis "script" to check for PEP8 compliance
- Added pylint to the Travis "after_success" to get a score for general code cleaning

Author: Aleffio

.travis.yml

@@ -9,7 +9,11 @@ install:
   - pip install pycurl
   - pip install mock
   - pip install coveralls
+  - pip install pylint
+  - pip install pycodestyle
 script:
   - coverage run -m unittest discover -s test -p '*Test.py'
+  - pycodestyle -v
 after_success:
-  coveralls
+  - coveralls
+  - pylint Adyen

Adyen/__init__.py

@@ -1,6 +1,6 @@
 #!/bin/python
 
-from __future__ import absolute_import, division, print_function, unicode_literals
+from __future__ import absolute_import, division, unicode_literals
 
 from . import util
 from .util import generate_hpp_sig
@@ -21,14 +21,13 @@
 
 from .httpclient import HTTPClient
 
-import datetime
+username = None
+password = None
+platform = None
+merchant_account = None
+merchant_specific_url = None
+hmac = None
 
-username = ""
-password = ""
-platform = ""
-merchant_account = ""
-merchant_specific_url = ""
-hmac = ""
 
 class Adyen(AdyenBase):
     def __init__(self, **kwargs):
@@ -37,6 +36,7 @@ def __init__(self, **kwargs):
         self.hpp = AdyenHPP(client=self.client)
         self.recurring = AdyenRecurring(client=self.client)
 
+
 _base_adyen_obj = Adyen()
 recurring = _base_adyen_obj.recurring
 hpp = _base_adyen_obj.hpp

Adyen/client.py

@@ -1,67 +1,75 @@
-from __future__ import absolute_import, division, print_function, unicode_literals
+from __future__ import absolute_import, division, unicode_literals
 
-class AdyenError(Exception):
 
+class AdyenError(Exception):
     def __init__(self,
-            message,
-            raw_request="",
-            raw_response="",
-            url="",
-            psp="",
-            headers="",
-            status_code=""):
+                 message,
+                 raw_request="",
+                 raw_response="",
+                 url="",
+                 psp="",
+                 headers="",
+                 status_code=""):
         self.message = message
-        self.raw_request=raw_request
-        self.raw_response=raw_response
-        self.url=url
-        self.psp=psp
-        self.headers=headers
-        self.status_code=status_code
+        self.raw_request = raw_request
+        self.raw_response = raw_response
+        self.url = url
+        self.psp = psp
+        self.headers = headers
+        self.status_code = status_code
 
     def __str__(self):
         return repr(self.message)
 
     def debug(self):
-        return "message: {}\nHTTP status_code:{}\nurl: {}\nrequest: {}\nresponse: {}\nheaders: {}".format(
-            self.message,
-            self.status_code,
-            self.url,
-            self.raw_request,
-            self.raw_response,
-            self.headers)
+        return "message: {}\nHTTP status_code:{}\nurl: {}\nrequest:" \
+               " {}\nresponse: {}\nheaders: {}".format(
+                self.message,
+                self.status_code,
+                self.url,
+                self.raw_request,
+                self.raw_response,
+                self.headers)
+
 
 class AdyenInvalidRequestError(AdyenError):
     pass
 
-class AdyenAPIResponseError(AdyenError):
 
+class AdyenAPIResponseError(AdyenError):
     def __init__(self,
-            message,
-            result="",
-            error_code="",
-            *args,
-            **kwargs):
-        super(AdyenAPIResponseError,self).__init__(message, *args,**kwargs)
-        self.error_code=error_code
-        self.result=result
+                 message,
+                 result="",
+                 error_code="",
+                 *args,
+                 **kwargs):
+        super(AdyenAPIResponseError, self).__init__(message, *args, **kwargs)
+        self.error_code = error_code
+        self.result = result
 
     def __str__(self):
         return repr(self.message)
 
+
 class AdyenAPIAuthenticationError(AdyenAPIResponseError):
     pass
 
+
 class AdyenAPIInvalidPermission(AdyenAPIResponseError):
     pass
 
+
 class AdyenAPICommunicationError(AdyenAPIResponseError):
     pass
 
+
 class AdyenAPIValidationError(AdyenAPIResponseError):
     pass
 
+
 class AdyenAPIInvalidAmount(AdyenAPIResponseError):
     pass
 
+
 class AdyenAPIInvalidFormat(AdyenAPIResponseError):
     pass