You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The new Round::reset() introduced in #288 returns storage actions rather than directly mutating the storage. This easier to test and reason about. There are other methods in Round which could be refactored to work the same way, and have more unit tests written for them:
new()
remove_contributor_unsafe (introduced during Round restart #288 to combine removed_locks_unsafe and remove_chunk_contributions_unsafe)
remove_locks_unsafe
remove_chunk_contributions_unsafe
try_lock_chunk
The following methods depend on an immutable reference to Storage, perhaps they could be decoupled:
The new
Round::reset()introduced in #288 returns storage actions rather than directly mutating the storage. This easier to test and reason about. There are other methods inRoundwhich could be refactored to work the same way, and have more unit tests written for them:new()remove_contributor_unsafe(introduced during Round restart #288 to combineremoved_locks_unsafeandremove_chunk_contributions_unsafe)remove_locks_unsaferemove_chunk_contributions_unsafetry_lock_chunkThe following methods depend on an immutable reference to
Storage, perhaps they could be decoupled:current_contribution_locatornext_contribution_locatornext_contribution_file_signature_locator