HDF5 crashes with large 2d grids on Mac

[IanHawke]

METHOD/Project/CPU/Src/serialSaveDataHDF5.cc

Line 95 in 9865d60

double buffer[buffer_size];

When running on 1024^2 with ToyQ on Mac, the buffer creation segfaults. Replacing this line with

double *buffer = (double *) malloc(buffer_size*sizeof(double));

seems to work.

Unless someone objects, I will change this to an explicit malloc (note: need to check parallel case).

[AlexJamesWright]

Shouldn't this be
double * buffer = new double[buffer_size]
buffer_size isnt a constant so cant allocated at compile time

[AlexJamesWright]

Same needs to be done for the lengths variable just above I think too

[AlexJamesWright]

bd46c18 has a mem leak, Ian - *audible tutting*

[IanHawke]

Memory leak addressed in 7e9eeca but I didn't bother with the lengths variable as it's max size 3.

[AlexJamesWright]

FYI when you do fixes can you do them on a new branch so they can be merged into master sooner than the feature branches? Thnks