Skip to content

Proposal: Decouple 'impact' logic from EDM data model #21

@JTC-0

Description

@JTC-0

Description

Currently the EDM data model is generated within objects in poopy.py and companies.py. Coupled with this, is some logic to calculate impact - the downstream effects of the discharges and for visualisations.

For users who want to use this package to access data from the APIs and do their own analyses this probably shouldn't require the GDAL dependency for example - which can be a pain to install.

I propose the data model is separated from the impact/visualisation logic so that the dependencies required in the calculation of impact are optional.

This may give:

  • Space to grow the impact logic over time to include things like flow, tidal influence etc. without taking away from those wanting only the data model.
  • A better logical separation as the data model grows with more companies and the storing of history.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions