From 4eb51194366ddf00c16ae4da4ef3ab06763287e7 Mon Sep 17 00:00:00 2001 From: Isaac Hill <71404865+isaachilly@users.noreply.github.com> Date: Thu, 11 Dec 2025 16:49:46 +0100 Subject: [PATCH 1/2] [O2B-1489] Update table and page height constants Adjusted TABLEROW_HEIGHT and PAGE_USED_HEIGHT to reflect updated UI dimensions. --- .../Environments/Overview/environmentOverviewComponent.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/public/views/Environments/Overview/environmentOverviewComponent.js b/lib/public/views/Environments/Overview/environmentOverviewComponent.js index 7cc60ecd22..837616dd91 100644 --- a/lib/public/views/Environments/Overview/environmentOverviewComponent.js +++ b/lib/public/views/Environments/Overview/environmentOverviewComponent.js @@ -18,9 +18,9 @@ import { estimateDisplayableRowsCount } from '../../../utilities/estimateDisplay import { paginationComponent } from '../../../components/Pagination/paginationComponent.js'; import { filtersPanelPopover } from '../../../components/Filters/common/filtersPanelPopover.js'; -const TABLEROW_HEIGHT = 58; +const TABLEROW_HEIGHT = 65.3; // Estimate of the navbar and pagination elements height total; Needs to be updated in case of changes; -const PAGE_USED_HEIGHT = 181; +const PAGE_USED_HEIGHT = 260; /** * The shows the environment table From de8460e24cfed237a35293dd70e7a521d114246e Mon Sep 17 00:00:00 2001 From: Isaac Hill <71404865+isaachilly@users.noreply.github.com> Date: Thu, 11 Dec 2025 17:07:03 +0100 Subject: [PATCH 2/2] [O2B-1489] Update tests for new page size and row count Adjusted test expectations to reflect a change in the row heights and used page height. --- test/public/envs/overview.test.js | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/test/public/envs/overview.test.js b/test/public/envs/overview.test.js index b6e9183798..78309ec8a8 100644 --- a/test/public/envs/overview.test.js +++ b/test/public/envs/overview.test.js @@ -81,7 +81,7 @@ module.exports = () => { it('Should display the correct items counter at the bottom of the page', async () => { await expectInnerText(page, '#firstRowIndex', '1'); - await expectInnerText(page, '#lastRowIndex', '9'); + await expectInnerText(page, '#lastRowIndex', '7'); await expectInnerText(page, '#totalRowsCount', '9'); }); @@ -139,15 +139,15 @@ module.exports = () => { await checkEnvironmentStatusColor(2, 3); await checkEnvironmentStatusColor(3, 3); await checkEnvironmentStatusColor(6, 3); - await checkEnvironmentStatusColor(9, 3); + await checkEnvironmentStatusColor(7, 3); }); it('can set how many environments are available per page', async () => { - // Expect the amount selector to currently be set to 9 (because of the defined page height) + // Expect the amount selector to currently be set to 7 (because of the defined page height) const amountSelectorId = '#amountSelector'; const amountSelectorButton = await page.waitForSelector(`${amountSelectorId} button`); const amountSelectorButtonText = await page.evaluate((element) => element.innerText, amountSelectorButton); - expect(amountSelectorButtonText.trim().endsWith('9')).to.be.true; + expect(amountSelectorButtonText.trim().endsWith('7')).to.be.true; // Expect the dropdown options to be visible when it is selected await pressElement(page, `${amountSelectorId} button`);