Skip to content

Commit 00824b0

Browse files
committed
Fix bug that not support array.
1 parent 678704a commit 00824b0

File tree

2 files changed

+8
-7
lines changed

2 files changed

+8
-7
lines changed

src/handlers/search/tags_count/search_tags_count.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,7 @@ def get_schema(self):
1919
}
2020

2121
def validate_params(self):
22+
self.params['tags'] = self.event['multiValueQueryStringParameters'].get('tags')
2223
validate(self.params, self.get_schema())
2324

2425
def exec_main_proc(self):

tests/handlers/search/tags_count/test_search_tags_count.py

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -73,7 +73,7 @@ def tearDown(self):
7373
@patch('time.time', MagicMock(return_value=1530112710 + 86400 * 7))
7474
def test_search_request(self):
7575
params = {
76-
'queryStringParameters': {
76+
'multiValueQueryStringParameters': {
7777
'tags': ['A', 'B', 'C', 'D']
7878
}
7979
}
@@ -90,7 +90,7 @@ def test_search_request(self):
9090

9191
def test_search_request_not_exists(self):
9292
params = {
93-
'queryStringParameters': {
93+
'multiValueQueryStringParameters': {
9494
'tags': ['あ', 'い', 'う']
9595
}
9696
}
@@ -107,7 +107,7 @@ def test_search_request_not_exists(self):
107107
@patch('time.time', MagicMock(return_value=1530112710 + 86400 * 7))
108108
def test_search_with_tag_half_kana(self):
109109
params = {
110-
'queryStringParameters': {
110+
'multiValueQueryStringParameters': {
111111
'tags': ['ハンカク', '&$%!”#', '𪚲🍣𪚲', 'aaa-aaa', 'abcde vwxyz']
112112
}
113113
}
@@ -130,7 +130,7 @@ def test_search_request_tags_over150(self):
130130
temp_tags.append('AAA')
131131

132132
params = {
133-
'queryStringParameters': {
133+
'multiValueQueryStringParameters': {
134134
'tags': temp_tags,
135135
}
136136
}
@@ -139,22 +139,22 @@ def test_search_request_tags_over150(self):
139139

140140
def test_search_no_params(self):
141141
params = {
142-
'queryStringParameters': {}
142+
'multiValueQueryStringParameters': {}
143143
}
144144
response = SearchTagsCount(params, {}, elasticsearch=self.elasticsearch).main()
145145
self.assertEqual(response['statusCode'], 400)
146146

147147
def test_invalid_tag_parmas(self):
148148
params = {
149-
'queryStringParameters': {
149+
'multiValueQueryStringParameters': {
150150
'tags': ['']
151151
}
152152
}
153153
response = SearchTagsCount(params, {}, elasticsearch=self.elasticsearch).main()
154154
self.assertEqual(response['statusCode'], 400)
155155

156156
params = {
157-
'queryStringParameters': {
157+
'multiValueQueryStringParameters': {
158158
'tags': ['A' * 26]
159159
}
160160
}

0 commit comments

Comments
 (0)