Add process to limit the number of characters for tweet.

Author: keillera

src/handlers/me/articles/like/create/me_articles_like_create.py

@@ -147,13 +147,24 @@ def __get_article_likes_count(self):
 
     def __post_tweet(self, user_id, title, tags):
         # tweet 文の作成
-        # hash tag 文
+        # title 文(50文字以上は省略)
+        if len(title) > 50:
+            show_title = title[:50] + '...'
+        else:
+            show_title = title
+        # hash tag 文(最大55文字)
         hash_tags_str = ''
         if tags:
-            hash_tags_str += '\n#' + ' #'.join(tags)
+            for tag in tags:
+                if hash_tags_str == '':
+                    hash_tags_str += '\n#' + tag
+                elif len(hash_tags_str + tag) < 55:
+                    hash_tags_str += ' #' + tag
+                else:
+                    break
         # tweet 文
         payload = {
-            "text": f"{title}\n"
+            "text": f"{show_title}\n"
                     f"https://{os.environ['DOMAIN']}/{user_id}/articles/{self.event['pathParameters']['article_id']}" +
                     hash_tags_str
         }

tests/handlers/me/articles/like/create/test_me_articles_like_create.py

@@ -73,6 +73,14 @@ def setUp(self):
                 'status': 'public',
                 'user_id': 'article_user_id_02',
                 'sort_key': 1520150272000002
+            },
+            {
+                'article_id': 'testid000003',
+                'title': '123456789012345678901234567890123456789012345678901234567890',
+                'status': 'public',
+                'user_id': 'article_user_id_03',
+                'tags': ['a1234567890', 'b1234567890', 'c1234567890', 'd1234567890', 'e1234567890'],
+                'sort_key': 1520150272000003
             }
         ]
         TestsUtil.create_table(
@@ -292,14 +300,15 @@ def test_main_with_updating_notification(self):
 
     @patch('time.time', MagicMock(return_value=1520150272.000015))
     def test_main_ok_with_self_liked_user(self):
+        settings.LIKED_TWEET_COUNT = 1
         params = {
             'pathParameters': {
-                'article_id': self.article_info_table_items[2]['article_id']
+                'article_id': self.article_info_table_items[3]['article_id']
             },
             'requestContext': {
                 'authorizer': {
                     'claims': {
-                        'cognito:username': self.article_info_table_items[2]['user_id'],
+                        'cognito:username': self.article_info_table_items[3]['user_id'],
                         'custom:private_eth_address': '0x1234567890123456789012345678901234567890',
                         'phone_number_verified': 'true',
                         'email_verified': 'true'
@@ -315,7 +324,19 @@ def test_main_ok_with_self_liked_user(self):
         notification_before = notification_table.scan()['Items']
         unread_notification_manager_before = unread_notification_manager_table.scan()['Items']
 
-        response = MeArticlesLikeCreate(event=params, context={}, dynamodb=self.dynamodb).main()
+        mock_lib = MagicMock()
+        with patch('me_articles_like_create.TwitterUtil', mock_lib):
+            response = MeArticlesLikeCreate(event=params, context={}, dynamodb=self.dynamodb).main()
+            args, _ = mock_lib.return_value.post_tweet.call_args
+            self.assertTrue(mock_lib.return_value.post_tweet.called)
+            self.assertEqual(
+                args[0],
+                {
+                    'text': '12345678901234567890123456789012345678901234567890...\n'
+                            'https://dummy/article_user_id_03/articles/testid000003\n'
+                            '#a1234567890 #b1234567890 #c1234567890 #d1234567890'
+                }
+            )
 
         notification_after = notification_table.scan()['Items']
         unread_notification_manager_after = unread_notification_manager_table.scan()['Items']