特定の理由の時に依存項目の入力チェック

(jsonschemaでやりたくて色々調べたが、draft-07で初めてifが登場してた)

Author: ippei-fukamatsu

src/handlers/me/articles/fraud/create/me_articles_fraud_create.py

@@ -18,16 +18,25 @@ def get_schema(self):
                 'reason': {
                     'type': 'string',
                     'enum': settings.FRAUD_REASONS
-                }
+                },
+                'plagiarism_url': {
+                    'type': 'string',
+                },
+                'plagiarism_description': {
+                    'type': 'string'
+                },
+                'illegal_content': {
+                    'type': 'string'
+                },
             },
             'required': ['article_id']
         }
 
     def validate_params(self):
-        if not self.event.get('body'):
+        if self.event.get('pathParameters') is None:
             raise ValidationError('Request parameter is required')
-
         validate(self.params, self.get_schema())
+        self.__validate_reason_dependencies(self.params)
         # relation
         DBUtil.validate_article_existence(
             self.dynamodb,
@@ -63,7 +72,16 @@ def __create_article_fraud_user(self, article_fraud_user_table):
             ConditionExpression='attribute_not_exists(article_id)'
         )
 
-    def __validate_plagiarism(self):
-        # TODO:
+    def __validate_reason_dependencies(self, params):
+        reason = params.get('reason', '')
+        if reason in settings.FRAUD_NEED_ORIGINAL_REASONS:
+            self.__validate_dependencies(params, ['plagiarism_url', 'plagiarism_description'])
+
+        if reason in settings.FRAUD_NEED_DETAIL_REASONS:
+            self.__validate_dependencies(params, ['illegal_content'])
 
+    def __validate_dependencies(self, params, required_items):
+        for item in required_items:
+            if not params[item]:
+                raise ValidationError("%s is required" % item)
 

tests/handlers/me/articles/fraud/create/test_me_articles_fraud_create.py

@@ -20,19 +20,16 @@ def setUpClass(cls):
             {
                 'article_id': 'testid000000',
                 'user_id': 'test01',
-                'reason': 'violence',
                 'created_at': 1520150272
             },
             {
                 'article_id': 'testid000001',
                 'user_id': 'test01',
-                'reason': 'violence',
                 'created_at': 1520150273
             },
             {
                 'article_id': 'testid000002',
                 'user_id': 'test02',
-                'reason': 'violence',
                 'created_at': 1520150273
             }
         ]
@@ -87,7 +84,6 @@ def test_main_ok_exist_article_id(self):
             'pathParameters': {
                 'article_id': self.article_fraud_user_table_items[0]['article_id']
             },
-            'body': json.dumps({'reason': self.article_fraud_user_table_items[0]['reason']}),
             'requestContext': {
                 'authorizer': {
                     'claims': {
@@ -107,14 +103,12 @@ def test_main_ok_exist_article_id(self):
 
         target_article_id = params['pathParameters']['article_id']
         target_user_id = params['requestContext']['authorizer']['claims']['cognito:username']
-        target_reason = json.loads(params['body'])['reason']
 
         article_fraud_user = self.get_article_fraud_user(target_article_id, target_user_id)
 
         expected_items = {
             'article_id': target_article_id,
             'user_id': target_user_id,
-            'reason': target_reason,
             'created_at': 1520150272000003
         }
 
@@ -129,7 +123,6 @@ def test_call_validate_article_existence(self):
             'pathParameters': {
                 'article_id': 'testid000002'
             },
-            'body': json.dumps({'reason': self.article_fraud_user_table_items[0]['reason']}),
             'requestContext': {
                 'authorizer': {
                     'claims': {
@@ -154,7 +147,6 @@ def test_main_ng_exist_user_id(self):
             'pathParameters': {
                 'article_id': self.article_fraud_user_table_items[0]['article_id']
             },
-            'body': json.dumps({'reason': self.article_fraud_user_table_items[0]['reason']}),
             'requestContext': {
                 'authorizer': {
                     'claims': {