Test coverage: Admin controllers (knowledge sources, summaries, jobs, blocklists)

[AndreRobitaille]

Summary

Admin controller test coverage has expanded since this issue was filed but gaps remain.

What's already covered

• Topics — admin/topics_controller_test.rb, admin/topics_review_test.rb, admin/topics_controller_description_test.rb
• Committees — admin/committees_controller_test.rb (9 tests: CRUD, alias create/destroy)
• Members — admin/members_controller_test.rb (6 tests: index, show, alias CRUD, merge, merge-into-self rejection)

Controllers still needing tests

Admin::KnowledgeSourcesController

• CRUD operations (create, read, update, delete)
• File upload handling
• reingest action (re-processes knowledge source)

Admin::SummariesController

• Show action (view summaries for a meeting)
• regenerate_all — Regenerates all summaries for a meeting
• regenerate_one — Regenerates a single summary

Admin::JobsController

• Show action (job queue dashboard)
• retry_failed — Retry a single failed job
• retry_all_failed — Retry all failed jobs
• discard_failed — Discard a failed job
• clear_completed — Clear completed job records

Admin::TopicBlocklistsController

• CRUD operations for blocklist entries

Approach

• Follow patterns from existing admin/committees_controller_test.rb
• Use fixtures for test data
• Verify authentication is enforced on all actions
• Test both success and error paths

[AndreRobitaille]

Status (2026-04-14): narrower than filed. Current test/controllers/admin/:

• topics_controller_test.rb, topics_controller_description_test.rb, topics_review_test.rb
• committees_controller_test.rb, members_controller_test.rb
• prompt_templates_controller_test.rb (4.3k)
• job_runs_controller_test.rb (1.8k)
• searches_controller_test.rb (1.3k)

Still missing:

• KnowledgeSourcesController (CRUD + reingest)
• SummariesController (show + regenerate_all + regenerate_one)
• JobsController (queue dashboard + retry/discard/clear) — job_runs_controller_test is a different controller
• TopicBlocklistsController

Remaining scope is ~4 controllers. Still worth doing for refactor safety.