Node v12 Support

[Morgul]

So, the good news is, that, at least for my use case, this package works great on node v12. However, I have to install with --ignore-engines since the engine specifier specifies a maximum version of v10.

Maybe only set the minimum version, and if it breaks on newer node wait for reports? (AFAIK, there's no good way for a user to say "for this one package, I know it works on my version of node", and ignoring engine versions for all installs clearly isn't desirable.)

[calvinmetcalf]

I have traditionally had to update mapnik for each version of node that comes out and that's why it's pinned to a specific version of node

…

On Mon, Mar 23, 2020 at 3:35 PM Christopher S. Case < ***@***.***> wrote: So, the good news is, that, at least for my use case, this package works great on node v12. However, I have to install with --ignore-engines since the engine specifier specifies a maximum version of v10. Maybe only set the minimum version, and if it breaks on newer node wait for reports? (AFAIK, there's no good way for a user to say "for this one package, I know it works on my version of node", and ignoring engine versions for all installs clearly isn't desirable.) — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#17>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAITRH7VHXKPGQFWSOGSFODRI62XBANCNFSM4LSD3MTA> .

-- -Calvin W. Metcalf

[Morgul]

@calvinmetcalf Ah, yeah, I've run into that as well. I wonder if, since I'm using mapnik directly in my project as well, I've circumvented the issue?

Either way, I guess this is really a request for node v12 support. ;)

[calvinmetcalf]

ok I'll probably get around to it at some point during this quarantine

…

On Mon, Mar 23, 2020 at 3:59 PM Christopher S. Case < ***@***.***> wrote: @calvinmetcalf <https://github.com/calvinmetcalf> Ah, yeah, I've run into that as well. I wonder if, since I'm using mapnik directly in my project as well, I've circumvented the issue? Either way, I guess this is really a request for node v12 support. ;) — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#17 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAITRH2WIZWVAHYXGBREYB3RI65RLANCNFSM4LSD3MTA> .

-- -Calvin W. Metcalf