Skip to content

import from src is confusing and breaks packages #77

@xtofl

Description

@xtofl

As mentioned in my comment on f3b7979#r171493313, many python files in this repository contain lines like

import src.this  # bad

When installing this code as a package, it will not work - unless the package is actually called src. Also, it leads to bad habits like setting sys.path from within imported modules (I've seen this practice many times).

Maybe the idea was to not care for packaging, in which case I suggest removing the src/ and test/ folders altogether.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions