feat: pallet-collator-selection improvement

[ashutoshvarma]

Partially resolves #1521

Summary

This PR updates the collator selection mechanism to governance approved system. A candidate applicant needs to apply first by reserving the bond and only once application is approved by governanace the node is added to collator candidates. Also governanace can kick & slash bad performing collator candidates.

The pallet uses two configurable origins for governance actions

• GovernanceOrigin: Can approve/close candidacy applications
• ForceRemovalOrigin: Can forcibly kick and slash candidates

The following extrinsincs are added,

• apply_for_candidacy: Apply to be a candidate by reserving bond
• close_application: Close pending candidate application, unreserve the bond.
• approve_application: Approve the candidate application, add node to candidates. (Only GovernanceOrigin)
• kick_candidate: Kick and slash a candidate immediately. (Only ForceRemovalOrigin)
  • If governance wish to remove a candidate without slashing, it can be done via wrapping the leave_intent call with utility's dispatch_as via a referendum

Note:-

The old register_as_candidate is deprecated and will fail with Permission error (should be removed?)

Configs

For Astar & Shibuya

• GovernanceOrigin: 2/3 MainCouncil OR Referendum
• ForceRemovalOrigin: 2/3 MainCouncil OR Referendum

For Shiden, both root account

TODO

• Finalise the origins config for Astar
• Astar Docs PR

Check list**

• added or updated unit tests
• updated Astar official documentation
• added benchmarks & weights for any modified runtime logics.

[ashutoshvarma]

/bench astar-dev,shibuya-dev,shiden-dev pallet_collator_selection

[github-actions]

Benchmarks job is scheduled at https://github.com/AstarNetwork/Astar/actions/runs/17574770820.
Please wait for a while.
Branch: feat/collator-selection-improvment
SHA: 96219d9

[github-actions]

Benchmark job failed.
Please check https://github.com/AstarNetwork/Astar/actions/runs/17574770820.

[ashutoshvarma]

/bench astar,shibuya,shiden pallet_collator_selection

[github-actions]

Benchmarks job is scheduled at https://github.com/AstarNetwork/Astar/actions/runs/17576131975.
Please wait for a while.
Branch: feat/collator-selection-improvment
SHA: 96219d9

[github-actions]

Benchmarks have been finished.
You can download artifacts if exists https://github.com/AstarNetwork/Astar/actions/runs/17576131975.

[ashutoshvarma]

/bench astar-dev,shibuya-dev,shiden-dev pallet_collator_selection

[github-actions]

Benchmarks job is scheduled at https://github.com/AstarNetwork/Astar/actions/runs/18000194658.
Please wait for a while.
Branch: feat/collator-selection-improvment
SHA: 1417c14

[github-actions]

Benchmark job failed.
Please check https://github.com/AstarNetwork/Astar/actions/runs/18000194658.

[ashutoshvarma]

/bench astar,shibuya,shiden pallet_collator_selection

[github-actions]

Benchmarks job is scheduled at https://github.com/AstarNetwork/Astar/actions/runs/18002582024.
Please wait for a while.
Branch: feat/collator-selection-improvment
SHA: 1417c14

[github-actions]

Benchmarks have been finished.
You can download artifacts if exists https://github.com/AstarNetwork/Astar/actions/runs/18002582024.

[PierreOssun]

Really clean thanks!
I just have 2 questions and one suggestion

[Dinonard]

LGTM

[PierreOssun]

LGTM

[github-actions]

Package	Line Rate	Branch Rate	Health
pallets/price-aggregator/src	75%	0%	➖
pallets/unified-accounts/src	79%	0%	➖
precompiles/sr25519/src	56%	0%	➖
precompiles/dapp-staking/src	89%	0%	✔
precompiles/dapp-staking/src/test	0%	0%	❌
primitives/src	53%	0%	➖
pallets/democracy-mbm/src	30%	0%	❌
precompiles/substrate-ecdsa/src	67%	0%	➖
precompiles/dispatch-lockdrop/src	83%	0%	✔
chain-extensions/pallet-assets/src	54%	0%	➖
pallets/astar-xcm-benchmarks/src/fungible	100%	0%	✔
chain-extensions/types/assets/src	0%	0%	❌
pallets/dapp-staking/src	80%	0%	✔
pallets/static-price-provider/src	91%	0%	✔
pallets/ethereum-checked/src	76%	0%	➖
pallets/inflation/src	58%	0%	➖
pallets/vesting-mbm/src	87%	0%	✔
precompiles/assets-erc20/src	77%	0%	➖
pallets/dapp-staking/rpc/runtime-api/src	0%	0%	❌
pallets/collator-selection/src	88%	0%	✔
pallets/dapp-staking/src/benchmarking	95%	0%	✔
chain-extensions/unified-accounts/src	0%	0%	❌
pallets/collective-proxy/src	94%	0%	✔
primitives/src/xcm	60%	0%	➖
precompiles/unified-accounts/src	100%	0%	✔
pallets/xc-asset-config/src	64%	0%	➖
pallets/astar-xcm-benchmarks/src/generic	100%	0%	✔
chain-extensions/types/unified-accounts/src	0%	0%	❌
pallets/astar-xcm-benchmarks/src	86%	0%	✔
pallets/dapp-staking/src/test	0%	0%	❌
precompiles/xcm/src	69%	0%	➖
pallets/dynamic-evm-base-fee/src	84%	0%	✔
Summary	73% (3888 / 5345)	0% (0 / 0)	➖

Minimum allowed line rate is 50%