forge-multisig — add test verifying get_approval_count() returns correct value at each stage of a proposal lifecycle

[Austinaminu2]

Summary

Existing get_approval_count tests cover 0, 1, and 2 approvals but do not verify the count at every stage of a full proposal lifecycle including after execution. The count should remain at the final approval number even after execution.

Tasks

• Create a proposal — assert get_approval_count() == 1 (proposer auto-approves)
• Second owner approves — assert get_approval_count() == 2
• Third owner approves — assert get_approval_count() == 3
• Advance past timelock and execute — assert get_approval_count() == 3 (unchanged)
• Verify the count for a non-existent proposal still returns 0
• Verify the count for a rejected proposal returns the number of approvals at rejection time

Labels: testing, forge-multisig

[Emins25]

Implemented and opened PR for this issue: #345

Summary:

• added lifecycle coverage for approval_count from propose to execute
• verifies get_approval_count() remains unchanged after execution
• added rejected-proposal coverage so approval_count reflects the approvals present at rejection time