From df6b40988ccef676dea75c9572b9ccdf70737cb9 Mon Sep 17 00:00:00 2001 From: Kristian Darlington Date: Fri, 7 Sep 2018 17:27:28 -0700 Subject: [PATCH] callback is made even when error occurs. Error and response object are passed in as parameters as per Node.js standards. --- lib/apicontrollersbase.js | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/lib/apicontrollersbase.js b/lib/apicontrollersbase.js index 46f170d..4a14d54 100644 --- a/lib/apicontrollersbase.js +++ b/lib/apicontrollersbase.js @@ -49,7 +49,7 @@ class APIOperationBase { if(this._response){ message = this._response.message; } - + return message; } @@ -58,7 +58,7 @@ class APIOperationBase { setClientId() { for(var obj in this._request){ - this._request[obj]['clientId'] = config.clientId; + this._request[obj]['clientId'] = config.clientId; break; } } @@ -99,7 +99,8 @@ class APIOperationBase { request(reqOpts, function(error, response, body){ if(error) { logger.error(error); - } else + callback(error, null); + } else { //TODO: slice added due to BOM character. remove once BOM character is removed. var responseObj = JSON.parse(body.slice(1)); @@ -112,7 +113,7 @@ class APIOperationBase { logger.debug("Response: " + JSON.stringify(body, 2, null)); obj._response = body; */ - callback(); + callback(null, responseObj); } });