fix: stop reporting errors when there are none

Author: Steve Taylor

detection.sh

@@ -14,22 +14,14 @@ find_fail(){
     target=$1
     file=$2
     suite_line=$(cat "$file" | grep "$target")
-    if echo "$suite_line" | grep "failures=\"0\"";then
-        if echo "$suite_line" | grep -L "errors=\"[1-9]\d*\"";then
-            echo "Error found in $file: $suite_line"
-            return 1
-        else
-            return 0
-        fi
-    elif echo "$suite_line" | grep -L "errors=\"0\"";then
-        if echo "$suite_line" | grep -L "failures=\"[1-9]\d*\"";then
-            echo "Error found in $file: $suite_line"
-            return 1
-        else
-            return 0
-        fi
-    else
-        echo "Failure found in $file: $suite_line"
+    if echo "$suite_line" | grep -q -E "failures=\"[1-9]\\d*\""; then
+        echo "Failure(s) found in $file: $suite_line"
+        return 1
+    elif echo "$suite_line" | grep -q -E "errors=\"[1-9]\\d*\""; then
+        echo "Error(s) found in $file: $suite_line"
+        return 1
+    elif echo "$suite_line" | grep -qv -E "failures=\"0\""; then
+        echo "Test report may be malformed: No errors were detected, but the failures attribute is missing from the testsuite element."
         return 1
     fi
 }