fix: removed doc property from validation errors as per maintainer feedback

Author: Jadu07

lib/model.js

@@ -3042,9 +3042,6 @@ Model.$__insertMany = function(arr, options, callback) {
   const results = ordered ? null : new Array(arr.length);
   const toExecute = arr.map((doc, index) =>
     callback => {
-      // Store original document for error reporting
-      const originalDoc = arr[index];
-      
       // If option `lean` is set to true bypass validation and hydration
       if (lean) {
         // we have to execute callback at the nextTick to be compatible
@@ -3079,9 +3076,8 @@ Model.$__insertMany = function(arr, options, callback) {
         () => { callback(null, doc); },
         error => {
           if (ordered === false) {
-            // Add index and doc to validation error for better debugging
+            // Add index to validation error so users can identify which document failed
             error.index = index;
-            error.doc = doc.toObject ? doc.toObject() : originalDoc;
             validationErrors.push(error);
             validationErrorsToOriginalOrder.set(error, index);
             results[index] = error;

test/model.insertMany.test.js

@@ -429,7 +429,7 @@ describe('insertMany()', function() {
     assert.ok(!err.mongoose.validationErrors[1].errors['name']);
   });
 
-  it('insertMany() validation errors include index and doc properties with ordered false and rawResult', async function() {
+  it('insertMany() validation errors include index property with ordered false and rawResult', async function() {
     const schema = new Schema({
       title: { type: String, required: true },
       requiredField: { type: String, required: true }
@@ -451,19 +451,15 @@ describe('insertMany()', function() {
     // Check first validation error (index 1)
     const error1 = res.mongoose.validationErrors[0];
     assert.equal(error1.index, 1);
-    assert.ok(error1.doc);
-    assert.equal(error1.doc.title, 'title2');
     assert.ok(error1.errors['requiredField']);
 
     // Check second validation error (index 2)
     const error2 = res.mongoose.validationErrors[1];
     assert.equal(error2.index, 2);
-    assert.ok(error2.doc);
-    assert.equal(error2.doc.requiredField, 'field3');
     assert.ok(error2.errors['title']);
   });
 
-  it('insertMany() validation errors include index and doc properties with throwOnValidationError', async function() {
+  it('insertMany() validation errors include index property with throwOnValidationError', async function() {
     const schema = new Schema({
       title: { type: String, required: true },
       requiredField: { type: String, required: true }
@@ -485,15 +481,11 @@ describe('insertMany()', function() {
     // Check first validation error (index 1)
     const error1 = err.validationErrors[0];
     assert.equal(error1.index, 1);
-    assert.ok(error1.doc);
-    assert.equal(error1.doc.title, 'title2');
     assert.ok(error1.errors['requiredField']);
 
     // Check second validation error (index 2)
     const error2 = err.validationErrors[1];
     assert.equal(error2.index, 2);
-    assert.ok(error2.doc);
-    assert.equal(error2.doc.requiredField, 'field3');
     assert.ok(error2.errors['title']);
   });
 

types/error.d.ts

@@ -90,12 +90,9 @@ declare module 'mongoose' {
 
       errors: { [path: string]: ValidatorError | CastError };
       addError: (path: string, error: ValidatorError | CastError) => void;
-      
+
       /** Index of the document in insertMany() that failed validation (only set for unordered insertMany) */
       index?: number;
-      
-      /** Document that failed validation (only set for unordered insertMany) */
-      doc?: any;
 
       constructor(instance?: MongooseError);
     }