From 0992bda5a9ff076adae3574708a784eab5c556c0 Mon Sep 17 00:00:00 2001 From: Christian Clauss Date: Sun, 16 Nov 2025 07:14:57 +0100 Subject: [PATCH 1/3] GitHub Actions Windows use node-gyp 12 not 8 --- .github/workflows/ci.yaml | 20 ++++++++++---------- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/.github/workflows/ci.yaml b/.github/workflows/ci.yaml index 963d21721..534f9d369 100644 --- a/.github/workflows/ci.yaml +++ b/.github/workflows/ci.yaml @@ -15,10 +15,10 @@ jobs: matrix: node: [18.20.5, 20.18.1, 22.12.0, 23.3.0, 24.2.0] steps: - - uses: actions/setup-node@v4 + - uses: actions/setup-node@v6 with: node-version: ${{ matrix.node }} - - uses: actions/checkout@v4 + - uses: actions/checkout@v5 - name: Install Dependencies run: | sudo apt update @@ -35,10 +35,10 @@ jobs: matrix: node: [18.20.5, 20.18.1, 22.12.0, 23.3.0, 24.2.0] steps: - - uses: actions/setup-node@v4 + - uses: actions/setup-node@v6 with: node-version: ${{ matrix.node }} - - uses: actions/checkout@v4 + - uses: actions/checkout@v5 - name: Install Dependencies run: | Invoke-WebRequest "https://ftp.gnome.org/pub/GNOME/binaries/win64/gtk+/2.22/gtk+-bundle_2.22.1-20101229_win64.zip" -OutFile "gtk.zip" @@ -46,7 +46,7 @@ jobs: Invoke-WebRequest "https://downloads.sourceforge.net/project/libjpeg-turbo/2.0.4/libjpeg-turbo-2.0.4-vc64.exe" -OutFile "libjpeg.exe" -UserAgent NativeHost .\libjpeg.exe /S winget install --accept-source-agreements --id=Microsoft.VCRedist.2010.x64 -e - npm install -g node-gyp@8 + npm install -g node-gyp npm prefix -g | % {npm config set node_gyp "$_\node_modules\node-gyp\bin\node-gyp.js"} - name: Install run: npm install --build-from-source @@ -55,15 +55,15 @@ jobs: macOS: name: Test on macOS - runs-on: macos-15 + runs-on: macos-26 strategy: matrix: node: [18.20.5, 20.18.1, 22.12.0, 23.3.0, 24.2.0] steps: - - uses: actions/setup-node@v4 + - uses: actions/setup-node@v6 with: node-version: ${{ matrix.node }} - - uses: actions/checkout@v4 + - uses: actions/checkout@v5 - name: Install Dependencies run: | brew update @@ -77,10 +77,10 @@ jobs: name: Lint runs-on: ubuntu-latest steps: - - uses: actions/setup-node@v4 + - uses: actions/setup-node@v6 with: node-version: 20.9.0 - - uses: actions/checkout@v4 + - uses: actions/checkout@v5 - name: Install run: npm install --ignore-scripts - name: Lint From e9cd45a9441e4ca0bd6a7a20a69e61d2530ecbac Mon Sep 17 00:00:00 2001 From: Christian Clauss Date: Sun, 16 Nov 2025 07:27:35 +0100 Subject: [PATCH 2/3] npm config set node_gyp is no longer supported --- .github/workflows/ci.yaml | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/.github/workflows/ci.yaml b/.github/workflows/ci.yaml index 534f9d369..08aa97310 100644 --- a/.github/workflows/ci.yaml +++ b/.github/workflows/ci.yaml @@ -12,6 +12,7 @@ jobs: name: Test on Linux runs-on: ubuntu-latest strategy: + fail-fast: false matrix: node: [18.20.5, 20.18.1, 22.12.0, 23.3.0, 24.2.0] steps: @@ -32,6 +33,7 @@ jobs: name: Test on Windows runs-on: windows-2025 strategy: + fail-fast: false matrix: node: [18.20.5, 20.18.1, 22.12.0, 23.3.0, 24.2.0] steps: @@ -46,8 +48,6 @@ jobs: Invoke-WebRequest "https://downloads.sourceforge.net/project/libjpeg-turbo/2.0.4/libjpeg-turbo-2.0.4-vc64.exe" -OutFile "libjpeg.exe" -UserAgent NativeHost .\libjpeg.exe /S winget install --accept-source-agreements --id=Microsoft.VCRedist.2010.x64 -e - npm install -g node-gyp - npm prefix -g | % {npm config set node_gyp "$_\node_modules\node-gyp\bin\node-gyp.js"} - name: Install run: npm install --build-from-source - name: Test @@ -57,6 +57,7 @@ jobs: name: Test on macOS runs-on: macos-26 strategy: + fail-fast: false matrix: node: [18.20.5, 20.18.1, 22.12.0, 23.3.0, 24.2.0] steps: From 56b70c6e926da05fdac535f63bfe200f54e4a639 Mon Sep 17 00:00:00 2001 From: Christian Clauss Date: Sun, 16 Nov 2025 07:33:15 +0100 Subject: [PATCH 3/3] Update macOS runner to use 'macos-latest' --- .github/workflows/ci.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/ci.yaml b/.github/workflows/ci.yaml index 08aa97310..056d3a7e2 100644 --- a/.github/workflows/ci.yaml +++ b/.github/workflows/ci.yaml @@ -55,7 +55,7 @@ jobs: macOS: name: Test on macOS - runs-on: macos-26 + runs-on: macos-latest strategy: fail-fast: false matrix: