Malformed JSON Vscode error catch #87
Description
TL;DR handle what happens when you unset jupyter things
This is what we get when we rm all jupyter, all nbdiff/nb-whatever stuff. We CAN right now just open in text editor and then have everything (status bar) work fine.
I presume that the find notebooks with merge conflicts command palette would also work well. Status bar is going to be important though, for better integration into vscode. Perhaps we just make the status bar a "drop up" and have users choose the file they want to fix. Or perhaps just throw up a modal and keep it in the status-bar-as-tray for users to open again.
Check out:
microsoft / vscode / src / vs / workbench / contrib / notebook / browser / notebookEditor.ts
for how vscode handles malformed json. I think some nbdiff/jupyter product addresses this but basically, we need to address it ourselves and probably change the status bar thing to some kind of modal/alert we throw in vscode.
I also have no clue what it looks like when you merge in and the notebook's already open. Does it still throw a json malformed error??
This should happen along with #85 - and we should rename it. Check out the comment there for more on git too.