From 40e64555965f95ec3c79c7486f903df74ffc0f0b Mon Sep 17 00:00:00 2001 From: Dimitris Dafnis <68849116+jim-daf@users.noreply.github.com> Date: Sat, 25 Apr 2026 21:11:12 +0200 Subject: [PATCH 1/2] cleanup(webview): drop trivial DEBUG-only overrides Refs #422 --- .../java/com/ferg/awfulapp/webview/LoggingWebChromeClient.java | 1 - 1 file changed, 1 deletion(-) diff --git a/Awful.apk/src/main/java/com/ferg/awfulapp/webview/LoggingWebChromeClient.java b/Awful.apk/src/main/java/com/ferg/awfulapp/webview/LoggingWebChromeClient.java index 3103b1a51..5828f722b 100644 --- a/Awful.apk/src/main/java/com/ferg/awfulapp/webview/LoggingWebChromeClient.java +++ b/Awful.apk/src/main/java/com/ferg/awfulapp/webview/LoggingWebChromeClient.java @@ -1,6 +1,5 @@ package com.ferg.awfulapp.webview; -import android.os.Message; import androidx.annotation.CallSuper; import androidx.annotation.Nullable; import androidx.appcompat.app.AlertDialog; From d5bff59e1543206c23a0063ee53aa9ec8f68d2bd Mon Sep 17 00:00:00 2001 From: Dimitris Dafnis <68849116+jim-daf@users.noreply.github.com> Date: Sat, 25 Apr 2026 21:11:15 +0200 Subject: [PATCH 2/2] cleanup(webview): drop trivial DEBUG-only overrides Refs #422 --- .../webview/LoggingWebChromeClient.java | 23 +------------------ 1 file changed, 1 insertion(+), 22 deletions(-) diff --git a/Awful.apk/src/main/java/com/ferg/awfulapp/webview/LoggingWebChromeClient.java b/Awful.apk/src/main/java/com/ferg/awfulapp/webview/LoggingWebChromeClient.java index 5828f722b..00bafe816 100644 --- a/Awful.apk/src/main/java/com/ferg/awfulapp/webview/LoggingWebChromeClient.java +++ b/Awful.apk/src/main/java/com/ferg/awfulapp/webview/LoggingWebChromeClient.java @@ -1,5 +1,6 @@ package com.ferg.awfulapp.webview; +import android.os.Message; import androidx.annotation.CallSuper; import androidx.annotation.Nullable; import androidx.appcompat.app.AlertDialog; @@ -39,28 +40,6 @@ public LoggingWebChromeClient(WebView webView) { this.webView = webView; } - @CallSuper - @Override - public void onCloseWindow(WebView window) { - super.onCloseWindow(window); - if (DEBUG) Log.d(TAG, "onCloseWindow"); - } - - @CallSuper - @Override - public boolean onCreateWindow(WebView view, boolean isDialog, boolean isUserGesture, Message resultMsg) { - if (DEBUG) - Log.d(TAG, "onCreateWindow" + (isDialog ? " isDialog" : "") + (isUserGesture ? " isUserGesture" : "")); - return super.onCreateWindow(view, isDialog, isUserGesture, resultMsg); - } - - @CallSuper - @Override - public boolean onJsTimeout() { - if (DEBUG) Log.d(TAG, "onJsTimeout"); - return super.onJsTimeout(); - } - @Override public void onShowCustomView(View view, CustomViewCallback callback) { // if a view already exists then immediately terminate the new one