-
Notifications
You must be signed in to change notification settings - Fork 4.1k
make source list optional for redistribute throughput API #28561
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
make source list optional for redistribute throughput API #28561
Conversation
…24165) * apply Az.CosmosDB-preview branch CosmosDB folder to this branch * Use autorest.powershell to generate management SDK for cosmosDB (Azure#22413) * remove the custom code since character case change is not treated as a breaking change (Azure#22500) * regen sdk * specify header type as string to fix build error * update autorest file to align with main; regen sdk * fix casing * [Cosmos DB] Powershell changes for 2023-03-15 stable API (Azure#21990) * added tests for listconnectionstrings; updated changelog * add changes for list connection strings response * re-record test * update changelog * Add location api changes * Added test recording for location api * re-record tests * re-record tests * Revert "add changes for list connection strings response" This reverts commit ff3ef0a. * update changelog, update and re-record account tests --------- Co-authored-by: Udit Singh <udsing@microsoft.com> * CosmosDB - New Restore Parameter (Azure#22585) * restore new param public network access * minor fixes * test change * stable changes 1 * md param def changed * reverting test changes for build * restore ts * test and test recording * CosmosDB 2023-09-15 release (Azure#22726) (Azure#22953) * genrated changes * help and changelog and test case update * Powershell model changes for burst capacity * added customer managed key status to PSDatabaseAccountGetResults.cs * added recording for MongoOperationsTests and SqlOperationsTest * added recording for remaining tests * rerecorded failed tests * added changes in tests * Minimal Tls version for create and update * fixed build errors * updated tls version in test * updated commit id * MinimalTlsVersion to changelog * Update ChangeLog.md Added CustomerManagedKeyStatus to the Changelog * mask 'primaryReadOnlyMasterKey' and 'secondaryReadOnlyMasterKey' in recorded test * mask 'primaryMasterKey' and 'secondaryMasterKey' in recorded test * rerecorded account tests * rerecorded account tests * rerecorded Cassandra tests * re-recorded all but mongo and restore tests --------- Co-authored-by: Richa Sharma <richasharma.amu@gmail.com> Co-authored-by: Adrián Sibaja Retana <adriansretana@hotmail.com> Co-authored-by: unknown <danivsauma@gmail.com> Co-authored-by: AdrianSibajaRetana <54075415+AdrianSibajaRetana@users.noreply.github.com> * [CosmosDB] GA PowerShell commands for InAccount Restore of Deleted Database/ Containers feature for SQL/Mongo/Table/Gremlin (Azure#23666) * changes and generated code * update tests * update session records * update help files * update changelog * update session records * update TestUpdateCosmosDBAccountBackupPolicyToContinuous30Days session record * update session records * add notimestamp tests and update few old session records * regen sdk, fix build error * fix duplicate code * nit fix restore tests * re-record tests * CosmosDB: Adds changes to handle enabling partition merge on CosmosDB account (Azure#21736) * Merge branch 'Az.CosmosDB-preview' of https://github.com/SrinikhilReddy/azure-powershell into features/users/nanarava/enablepmerge * CosmosDB: Adds changes to handle enabling partition merge on CosmosDB account. * CosmosDB: Adds changes to handle enabling partition merge on CosmosDB account. * Update src/CosmosDB/CosmosDB/ChangeLog.md Co-authored-by: Jin Lei <54836179+msJinLei@users.noreply.github.com> * CosmosDB: Adds changes to handle enabling partition merge on CosmosDB account. * CosmosDB: Adds changes to handle enabling partition merge on CosmosDB account. * CosmosDB: Adds changes to handle enabling partition merge on CosmosDB account. * Update ChangeLog.md Remove duplicate line * Resolve code comments. --------- Co-authored-by: Jin Lei <54836179+msJinLei@users.noreply.github.com> * Replace Start-Sleep with Start-TestSleep for all test cases (Azure#23780) * re-record account test * fix typo * [Cosmos DB] Powershell changes for 2023-04-15 stable API (Continuous 7 GA) (Azure#21685) * move to new swagger version and prereq * edit readme.md * manually generated from autorest * Continuous 7 days change * add 2 new test recordings * fix example issues * add all test recordings for RestoreTests suite * fix New-AzCosmosDBAccount.md * add almost all test recordings * add 4 more successful recordings. all working now * no examples * clean up help file * add output type to cmdlet * suppress errors for existing cmdlets * Revert "suppress errors for existing cmdlets" This reverts commit f36e275. * suppress static validation errors for existing commands --------- Co-authored-by: Xiaogang <xidi@microsoft.com> Co-authored-by: Udit Singh <udsing@microsoft.com> Co-authored-by: mayankkatwal <121567171+mayankkatwal@users.noreply.github.com> Co-authored-by: Yabo Hu <yabhu@microsoft.com> Co-authored-by: Richa Sharma <richasharma.amu@gmail.com> Co-authored-by: Adrián Sibaja Retana <adriansretana@hotmail.com> Co-authored-by: unknown <danivsauma@gmail.com> Co-authored-by: AdrianSibajaRetana <54075415+AdrianSibajaRetana@users.noreply.github.com> Co-authored-by: ddhamotharan <105816437+ddhamotharan@users.noreply.github.com> Co-authored-by: Srinikhil Naravamakula <srinikhil.r@gmail.com> Co-authored-by: Jin Lei <54836179+msJinLei@users.noreply.github.com> Co-authored-by: Vincent Dai <23257217+vidai-msft@users.noreply.github.com> Co-authored-by: vinhms <vitrinh@microsoft.com>
* cherry-pick stable change into preview; stable:Azure#24199 * 1 out of 7 fixed * fixing other 2 tests * fixing remaining 4 tests failure due to session record
…re#24261) * update and regen for 02-15-2024-preview version * code changes * test recording * re-record tests * regen sdk * rerecord tests * test recording * Update ChangeLog.md * Add DisableTtl * Update md file * Introduce custom model class DisableTtl to accomodate enumness * Update readme * Update test json file to expect string instead of bool * Update readme to have boolean to string * Revert back to boolean parameter * Remove bak file * Update restore test * Update restore test * Undo recording file change * Add missing copy in the constructor * Fix spaceing * rerecord test --------- Co-authored-by: Kushal Warke <kuwarke@microsoft.com> Co-authored-by: Min Ho Kang <minhokang@microsoft.com>
[DoNotSquash] Get Az.CosmosDB-preview branch up to date
…owershell into azure_preview
…review [CosmosDB] Sync main to CosmosDB preview
[CosmosDB] Sync main to CosmosDB preview
[Microsoft.DocumentDB] Cosmos DB 2025-05-01-preview API version release.
Co-authored-by: lijinpei2008 <31384087+lijinpei2008@users.noreply.github.com> Co-authored-by: Gandharv Sachdeva <53263043+gansach@users.noreply.github.com> Co-authored-by: gansach <gasachdeva@microsoft.com> Co-authored-by: Azure PowerShell <65331932+azure-powershell-bot@users.noreply.github.com> Co-authored-by: Yunchi Wang <54880216+wyunchi-ms@users.noreply.github.com> Co-authored-by: EmmaZhu-MSFT <emmazhu@microsoft.com> Co-authored-by: Prajjwal Kamboj <pkamboj@microsoft.com> Co-authored-by: Xiaogang <xidi@microsoft.com> Co-authored-by: Jin Lei <54836179+msJinLei@users.noreply.github.com> Co-authored-by: Yabo Hu <yabhu@microsoft.com> Co-authored-by: Vincent Dai <23257217+vidai-msft@users.noreply.github.com> Co-authored-by: Prajjwal Kamboj <kamboj.prjwl@gmail.com> Co-authored-by: Ankit Baluni <56029339+ankitbaluni123@users.noreply.github.com> Co-authored-by: Ankit Baluni (from Dev Box) <ankitbaluni@microsoft.com> Co-authored-by: Eugenio Peña García <70240915+EugenioPena@users.noreply.github.com> Co-authored-by: Himanshu Agarwal <hiaga@microsoft.com> Co-authored-by: Karthik Gumpu <gumpukarthik@gmail.com> Co-authored-by: Karthik Gumpu (from Dev Box) <karthikgumpu@microsoft.com> Co-authored-by: JoyerJin <116236375+JoyerJin@users.noreply.github.com> Co-authored-by: Jingshu918 <138486531+Jingshu918@users.noreply.github.com> Co-authored-by: ShawnX <17153057+ShawnXxy@users.noreply.github.com> Co-authored-by: mmkiran21-git <v-mmanikiran@microsoft.com> Co-authored-by: kumarutkarsh3b2166 <kumarutkarsh@microsoft.com> Co-authored-by: NoriZC <110961157+NoriZC@users.noreply.github.com> Co-authored-by: Auðunn <audunnb@gmail.com> Co-authored-by: Sam Lee <32776898+minhsuanlee@users.noreply.github.com> Co-authored-by: Sam Lee <samlee3@microsoft.com> Co-authored-by: Yan Xu <yanxu1@microsoft.com> Co-authored-by: yashikajain14 <140590975+yashikajain14@users.noreply.github.com> Co-authored-by: Mike F. Robbins <6719572+mikefrobbins@users.noreply.github.com> Co-authored-by: Theodore Chang <thchan@microsoft.com> Co-authored-by: Yeming Liu <11371776+isra-fel@users.noreply.github.com> Co-authored-by: Yeming Liu <yeliu@microsoft.com> Co-authored-by: yanivha6 <132562992+yanivha6@users.noreply.github.com> Co-authored-by: Yaniv Haddad <yanivhaddad@microsoft.com> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Co-authored-by: Qi Pan <43341456+Pan-Qi@users.noreply.github.com> Co-authored-by: Arie Heinrich <arie.heinrich@outlook.com> Co-authored-by: Wei Wei <weiwei@microsoft.com> Co-authored-by: Ana Arias Rosales <147624519+anaarias-msft@users.noreply.github.com> Co-authored-by: Srinivas <alluri02@users.noreply.github.com> Co-authored-by: Srinivas Alluri <sralluri@microsoft.com> Co-authored-by: Aditya Pujara <59631311+a0x1ab@users.noreply.github.com> Co-authored-by: v-sapanchal <117979452+v-sapanchal@users.noreply.github.com> Co-authored-by: yk <83654272+2258093686@users.noreply.github.com> Co-authored-by: Yukun Li (Beyondsoft) <v-yukunli@microsoft.com> Co-authored-by: Faizan Uddin Fahad Khan <contact.faizan.fahad@gmail.com> Co-authored-by: Faizan Uddin Fahad Khan <faikh@microsoft.com> Co-authored-by: emmeliaAra <emmelia.ara42@gmail.com> Co-authored-by: emmeliaAra <earakleitou@microsoft.com> Co-authored-by: ajtms <154369796+ajtms@users.noreply.github.com> Co-authored-by: Christopher Lewis <ChristopherGLewis@users.noreply.github.com> Co-authored-by: mihretkidane-OCI <mihret.kidane@oracle.com> Co-authored-by: raghumetta <raghunadh.metta@oracle.com> Co-authored-by: Emily Hua <emily.hua@oracle.com> Co-authored-by: Mathias Foster <77993506+mfoster58@users.noreply.github.com> Co-authored-by: mfoster58 <mathfoster@microsoft.com> Co-authored-by: Anna Pankiewicz <anna.pankiewicz@microsoft.com> Co-authored-by: prakhar_shukla <78557330+shuklaprakhar415@users.noreply.github.com> Co-authored-by: Prakhar Shukla <prakshukla@microsoft.com> Co-authored-by: Weishu Zhao <632604666@qq.com> Co-authored-by: BhumikaMatharu <50544476+BhumikaMatharu@users.noreply.github.com> Co-authored-by: Bhumika Kaur Matharu <bmatharu@microsoft.com> Co-authored-by: am-lim <55768281+am-lim@users.noreply.github.com>
…uckets (Azure#28378) Co-authored-by: NoriZC <110961157+NoriZC@users.noreply.github.com>
Thanks for your contribution! The pull request validation has started. Please revisit this comment for updated status. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR makes the source list parameter optional for the redistribute throughput API in CosmosDB. Previously, the API would throw an error when the source list was null or not passed, but now it supports empty source lists to provide more flexibility.
Key Changes
- Updated the redistribute throughput API to handle optional source lists
- Modified validation logic to accept empty/null source lists instead of throwing errors
Reviewed Changes
Copilot reviewed 2 out of 526 changed files in this pull request and generated 1 comment.
File | Description |
---|---|
src/CosmosDB/CosmosDB.Management.Sdk/CosmosDB.Management.Sdk.csproj | Added BOM character to project file |
NuGet.Config | Added empty lines to configuration file |
@@ -1,4 +1,4 @@ | |||
<Project Sdk="Microsoft.NET.Sdk"> | |||
<Project Sdk="Microsoft.NET.Sdk"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The addition of a UTF-8 BOM (Byte Order Mark) character at the beginning of the project file is unnecessary and can cause issues with some tools and editors. Project files should be saved as UTF-8 without BOM.
<Project Sdk="Microsoft.NET.Sdk"> | |
<Project Sdk="Microsoft.NET.Sdk"> |
Copilot uses AI. Check for mistakes.
/azp run |
Azure Pipelines will not run the associated pipelines, because the pull request was updated after the run command was issued. Review the pull request again and issue a new run command. |
|
||
|
||
|
||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please remove this change from your PR
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please remove changes under azure-powershell/generated from your PR
@@ -1,4 +1,4 @@ | |||
<Project Sdk="Microsoft.NET.Sdk"> | |||
<Project Sdk="Microsoft.NET.Sdk"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what is this change for?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please use a specific commit id instead of main
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it looks like your base branch was based on the preview feature branch, and incorrectly targeting to main branch, please double check your target release
@lnajaroen please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.
Contributor License AgreementContribution License AgreementThis Contribution License Agreement (“Agreement”) is agreed to by the party signing below (“You”),
|
|
Description
Update existing API. Make source list optional for redistribute throughput API. Currently it throws error if list is null and not passed through. We now support empty source list.
Mandatory Checklist
Please choose the target release of Azure PowerShell. (⚠️ Target release is a different concept from API readiness. Please click below links for details.)
Check this box to confirm: I have read the Submitting Changes section of
CONTRIBUTING.md
and reviewed the following information:ChangeLog.md
file(s) appropriatelysrc/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
.## Upcoming Release
header in the past tense.ChangeLog.md
if no new release is required, such as fixing test case only.