From 8993f35a235a98bcee2a8bf1d60d2c50951b0064 Mon Sep 17 00:00:00 2001 From: Mike Chambers Date: Tue, 5 Jul 2022 09:08:31 +0100 Subject: [PATCH 1/3] Update NodeDefenderSettings.cs --- Our.Umbraco.NodeDefender/NodeDefenderSettings.cs | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/Our.Umbraco.NodeDefender/NodeDefenderSettings.cs b/Our.Umbraco.NodeDefender/NodeDefenderSettings.cs index 36761a8..c53a888 100644 --- a/Our.Umbraco.NodeDefender/NodeDefenderSettings.cs +++ b/Our.Umbraco.NodeDefender/NodeDefenderSettings.cs @@ -5,6 +5,8 @@ namespace NodeDefender { public class NodeDefenderSettings { + public static string NodeDefender = "NodeDefender" + public IEnumerable AllowedUserGroups { get; set; } public DenyOptions DenyRename { get; set; } @@ -30,4 +32,4 @@ public class ErrorMessage public string Message { get; set; } public string Type { get; set; } = EventMessageType.Error.ToString(); } -} \ No newline at end of file +} From fe5c0ead6d060649c7cc01b473eaa1f6683c6000 Mon Sep 17 00:00:00 2001 From: Mike Chambers Date: Tue, 5 Jul 2022 09:13:50 +0100 Subject: [PATCH 2/3] Remove magic string in Conifg --- Our.Umbraco.NodeDefender/NodeDefender.cs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Our.Umbraco.NodeDefender/NodeDefender.cs b/Our.Umbraco.NodeDefender/NodeDefender.cs index 9e60262..84625fa 100644 --- a/Our.Umbraco.NodeDefender/NodeDefender.cs +++ b/Our.Umbraco.NodeDefender/NodeDefender.cs @@ -12,7 +12,7 @@ public class NodeDefender : IComposer public void Compose(IUmbracoBuilder builder) { // get all doctypes and node Ids - builder.Services.Configure(builder.Config.GetSection("NodeDefender")); + builder.Services.Configure(builder.Config.GetSection(NodeDefenderSettings.NodeDefender)); builder.AddNotificationHandler(); builder.AddNotificationHandler(); From b53adaef73fd4acce388fd306dc2b28c9a885d93 Mon Sep 17 00:00:00 2001 From: Mike Chambers Date: Tue, 5 Jul 2022 09:16:32 +0100 Subject: [PATCH 3/3] update to const rather than static --- Our.Umbraco.NodeDefender/NodeDefenderSettings.cs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Our.Umbraco.NodeDefender/NodeDefenderSettings.cs b/Our.Umbraco.NodeDefender/NodeDefenderSettings.cs index c53a888..bf5db31 100644 --- a/Our.Umbraco.NodeDefender/NodeDefenderSettings.cs +++ b/Our.Umbraco.NodeDefender/NodeDefenderSettings.cs @@ -5,7 +5,7 @@ namespace NodeDefender { public class NodeDefenderSettings { - public static string NodeDefender = "NodeDefender" + public const string NodeDefender = "NodeDefender" public IEnumerable AllowedUserGroups { get; set; } public DenyOptions DenyRename { get; set; }