Skip to content

Commit 0c9669e

Browse files
BrandonDaniel Tolbert
authored andcommitted
add check for ResultCount when fetching availableNumbers (#13)
update test for Accoutn::availableNumbers
1 parent 2b12087 commit 0c9669e

File tree

2 files changed

+10
-1
lines changed

2 files changed

+10
-1
lines changed

src/Account.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -177,7 +177,7 @@ public function availableNumbers($filters=Array()){
177177

178178
$url = sprintf('%s/%s', $this->account_id, 'availableNumbers');
179179
$data = parent::_get($url, $filters);
180-
$count = $data['ResultCount'];
180+
$count = isset($data['ResultCount']) ? $data['ResultCount'] : 0;
181181

182182
$types = [
183183
["level1" => "TelephoneNumberDetailList", "level2" => "TelephoneNumberDetail", "classname" => "\Iris\TelephoneNumberDetail"],

tests/AccountTest.php

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,7 @@ public static function setUpBeforeClass() {
1717
new Response(200, [], "<?xml version=\"1.0\"?> <SearchResult><ResultCount>2</ResultCount> <TelephoneNumberDetailList><TelephoneNumberDetail> <City>KNIGHTDALE</City> <LATA>426</LATA> <RateCenter>KNIGHTDALE</RateCenter> <State>NC</State> <FullNumber>9192956932</FullNumber> <Tier>0</Tier><VendorId>49</VendorId> <VendorName>Bandwidth CLEC</VendorName></TelephoneNumberDetail><TelephoneNumberDetail> <City>KNIGHTDALE</City> <LATA>426</LATA> <RateCenter>KNIGHTDALE</RateCenter> <State>NC</State> <FullNumber>9192956932</FullNumber> <Tier>0</Tier><VendorId>49</VendorId> <VendorName>Bandwidth CLEC</VendorName></TelephoneNumberDetail> </TelephoneNumberDetailList></SearchResult>"),
1818
new Response(200, [], "<?xml version=\"1.0\" encoding=\"UTF-8\" standalone=\"no\"?> <SearchResult><ResultCount>5</ResultCount> <TelephoneNumberList><TelephoneNumber>9194390154</TelephoneNumber> <TelephoneNumber>9194390158</TelephoneNumber> <TelephoneNumber>9194390176</TelephoneNumber> <TelephoneNumber>9194390179</TelephoneNumber> <TelephoneNumber>9194390185</TelephoneNumber></TelephoneNumberList> </SearchResult>"),
1919
new Response(400, [], "<?xml version=\"1.0\" encoding=\"UTF-8\" standalone=\"yes\"?> <SearchResult><Error> <Code>4000</Code> <Description>The area code of telephone numbers can not end with 11. </Description></Error><ResultCount>0</ResultCount> </SearchResult>"),
20+
new Response(200, [],"<?xml version=\"1.0\" encoding=\"UTF-8\" standalone=\"yes\"?><SearchResult/>"),
2021
new Response(201, ['Location' => 'https://api.test.inetwork.com:443/v1.0/accounts/9500249/tnsreservation/2489']),
2122
new Response(200, [], "<?xml version=\"1.0\"?><ReservationResponse><Reservation> <ReservationId>0099ff73-da96-4303-8a0a-00ff316c07aa</ReservationId> <AccountId>14</AccountId> <ReservationExpires>0</ReservationExpires> <ReservedTn>2512027430</ReservedTn></Reservation> </ReservationResponse>"),
2223
new Response(200, []),
@@ -93,6 +94,14 @@ public function testAvailableNumbersError() {
9394
self::$index++;
9495
}
9596

97+
public function testAvailableNumbersNoResults() {
98+
$response = self::$account->availableNumbers();
99+
100+
$this->assertEquals("GET", self::$container[self::$index]['request']->getMethod());
101+
$this->assertEquals("https://api.test.inetwork.com/v1.0/accounts/9500249/availableNumbers", self::$container[self::$index]['request']->getUri());
102+
self::$index++;
103+
}
104+
96105
public function testTnReservation() {
97106
$resertation = self::$account->tnsreservations()->create(["ReservedTn" => "2512027430"]);
98107

0 commit comments

Comments
 (0)