Dx 1390 fixed file response header for post requests (#63)

* Fixed location header response

* Fixed php warnings

* Updated readme example

* Added test

Author: jmulford-bw

README.md

@@ -20,6 +20,7 @@ PHP Client library for Bandwidth's Phone Number Dashboard (AKA: Dashboard, Iris)
 | 2.3.0 | Added `loas` endpoints for ImportTnOrders |
 | 2.4.0 | Added Emergency Calling Notification, Emergeny Notification Group, Emergency Notification Endpoint, and Alternate End User Identity methods |
 | 2.5.0 | Added `PortOutPasscode` for TnOption orders |
+| 2.5.1 | Fixed grabbing of response header for file uploads |
 
 ## Supported PHP Versions
 
@@ -366,6 +367,14 @@ $portin->set_metadata('test.txt', $meta_new);
 $portin->delete_metadata('test.txt');
 ```
 
+#### PortIn File Management: Grab filename
+```PHP
+$response = $portin->loas_send('./hello.txt', array("Content-Type" => "text/plain"));
+$tmp = explode("/", $response);
+$id = end($tmp);
+print_r($id);
+```
+
 ## Rate Centers
 ### List Ratecenters
 ```PHP

composer.json

@@ -4,7 +4,7 @@
     "description": "Bandwidth's Iris SDK for PHP",
     "keywords": ["iris","sdk","php"],
     "homepage": "http://dev.bandwidth.com",
-    "reference": "v2.5.0",
+    "reference": "v2.5.1",
     "license": "MIT",
     "authors": [
     ],

core/Client.php

@@ -236,11 +236,12 @@ public function raw_file_post($url, $content, $headers = [])
         ];
         $response = $this->request('post', $url, $options, false);
 
-        if (!is_array($response) || !isset($response['Location']))
+        if ($response->hasHeader('Location'))
         {
-            return '';
+            $header = $response->getHeader('Location');
+            return reset($header);
         }
-        return $response['Location'];
+        return '';
     }
 
     /**

tests/PortinsTest.php

@@ -26,6 +26,8 @@ public static function setUpBeforeClass() {
 			new Response(200, [], "<?xml version=\"1.0\" encoding=\"UTF-8\" standalone=\"yes\"?><LnpOrderResponse>    <ProcessingStatus>SUBMITTED</ProcessingStatus>    <RequestedFocDate>2015-06-03T15:30:00Z</RequestedFocDate>    <LoaAuthorizingPerson>Joe Blow</LoaAuthorizingPerson>    <Subscriber>        <SubscriberType>BUSINESS</SubscriberType>        <BusinessName>Company</BusinessName>        <ServiceAddress>            <HouseNumber>123</HouseNumber>            <StreetName>EZ Street</StreetName>            <City>Raleigh</City>            <StateCode>NC</StateCode>            <Zip>27615</Zip>            <County>Wake</County>            <Country>United States</Country>            <AddressType>Service</AddressType>        </ServiceAddress>    </Subscriber>    <BillingTelephoneNumber>9193491234</BillingTelephoneNumber>       <NewBillingTelephoneNumber>9175131245</NewBillingTelephoneNumber>     <ListOfPhoneNumbers>        <PhoneNumber>9193491234</PhoneNumber>    </ListOfPhoneNumbers>    <PON>BWC1433343996123</PON>    <AccountId>9500249</AccountId>    <SiteId>2297</SiteId>    <PeerId>500655</PeerId>    <LosingCarrierName>Test Losing Carrier L3</LosingCarrierName>    <VendorName>Bandwidth CLEC</VendorName>    <OrderCreateDate>2015-06-03T15:06:35.533Z</OrderCreateDate>    <LastModifiedDate>2015-06-03T15:06:36.234Z</LastModifiedDate>    <userId>System</userId>    <LastModifiedBy>System</LastModifiedBy>    <PartialPort>false</PartialPort>    <Immediately>false</Immediately>    <Triggered>false</Triggered></LnpOrderResponse>"),
 			new Response(200, [], "<?xml version=\"1.0\" encoding=\"UTF-8\" standalone=\"yes\"?><OrderHistoryWrapper>    <OrderHistory>        <OrderDate>2015-06-03T15:06:35.765Z</OrderDate>        <Note>LOA required</Note>        <Author>byo_dev</Author>        <Status>PENDING_DOCUMENTS</Status>    </OrderHistory>    <OrderHistory>        <OrderDate>2015-06-03T15:06:36.234Z</OrderDate>        <Note>Order has been created</Note>        <Author>System</Author>        <Status>SUBMITTED</Status>        <Difference>LoaDate : \"\" --&gt; Wed Jun 03 15:06:35 UTC 2015</Difference>    </OrderHistory></OrderHistoryWrapper>"),
 			new Response(200, [], "<?xml version=\"1.0\" encoding=\"UTF-8\" standalone=\"yes\"?><Quantity><Count>4</Count></Quantity>"),
+			new Response(200),
+			new Response(200, ["Location" => "filename"], ""),
         ]);
 
         self::$container = [];
@@ -275,5 +277,10 @@ public function testTotals() {
         self::$index++;
     }
 
+    public function testLoasSend() {
+        $portin = self::$portins->portin("");
+        $response = $portin->loas_send('./tests/test.txt', array("Content-Type" => "text/plain"));
+        $this->assertEquals("filename", $response);
+    }
 
 }