[BUG] Server crashes when connection is not closed properly

[Neptnium]

Fill out general information
OS (windows, linux, ...): debian12
BeamMP-Server Version: v3.9.2

Describe the bug
When client crashes or ALT + F4, or any other case where the connection is not closed properly. The server might crash with a core dump.

To Reproduce
Steps to reproduce the behavior:

1. Go on a server, and close the launcher !

Expected behavior
The server does not crahes (I guess 😆)

Logs
Sorry, there is nothing logged, just a SIGABRT.

Additional context
The server crashes with a SIGABRT caused by an uncaught boost::system::system_error exception escaping the thread's boundary, triggering std::terminate().

src/TNetwork.cpp:652:

void TNetwork::DisconnectClient(TClient &c, const std::string &R)
{
    if (c.IsDisconnected()) return;
    // THIS LINE THROWS when the socket is already closed:
    std::string ClientIP = c.GetTCPSock().remote_endpoint().address().to_string();
    mClientMapMutex.lock();
    if (mClientMap[ClientIP] > 0) {
        mClientMap[ClientIP]--;
    }
    if (mClientMap[ClientIP] == 0) {
        mClientMap.erase(ClientIP);
    }
    mClientMapMutex.unlock();
    c.Disconnect(R);
}

BUT, the fix is not as simple as a try / catch because of the mClientMap, my best bet would be to save the client's ip inside of TClient at all times. If you have any other idea, please tell me.

[boubouleuh]

I tried to reproduce it and im not able to, how often is that happening to you? Is it happening even if the server have only one player or when theres more or if its full?

[Neptnium]

Did you make sure to close the Launcher and not the game, I was able to reproduce this bug 100% of the time on beammp's official servers.
It is only on the latest version !

[boubouleuh]

Did you make sure to close the Launcher and not the game, I was able to reproduce this bug 100% of the time on beammp's official servers. It is only on the latest version !

yup i did and it doesnt crash, did you try on a local server with only you online?

[boubouleuh]

terminate called without an active exception
Aborted (core dumped)

was able to reproduce it on my end, this issue only appear on linux not on windows

[Neptnium]

I would like to make the PR for this issue if possible as I already started to work on the fix :D