Skip to content

Interactions with LSP semantic tokens #197

@GheTar-home

Description

@GheTar-home

Hello, I've noticed a strange interaction between your themes and Golang / gopls (Golang LSP).

The starting situation was this one:
image

as you can see almost all operators are grey instead of yellow and function arguments are correctly highlighted with a different color from local variables.

Now, VSCode by default uses

"editor.semanticHighlighting.enabled": "configuredByTheme",

and in my settings.json I have configured gopls like this.

"gopls": { "ui.semanticTokens": true },

I'm not an expert on these stuff but it looks like that the LSP gives additional information for themes to use; Like which are the arguments in the function body that, as you can see, works as expected.

I tried to disable the gopls semantic tokens option in settings.json, restart VSCode and there it goes:

image

All operators are yellow instead of grey but function arguments (and I suppose other type of "symbols") are no longer highlighted differently.

I think that this issue might be related to #169

Thanks a lot for your work on these themes, they are the best around.

P.S. : I have just now noticed that you already aknowledged the issue with semantic tokens on #92, sorry for the redundancy.

Metadata

Metadata

Assignees

No one assigned

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions