move_all_by fails when the layout contains pins, via_infos, ...

[gnawhleinad]

move_all_by (shown below 👇)

BPG/BPG/photonic_core.py

Lines 559 to 564 in 8018c0d

	for obj in chain(self._inst_list, self._inst_primitives, self._rect_list,
	self._via_primitives, self._via_list, self._pin_list,
	self._path_list, self._blockage_list, self._boundary_list,
	self._polygon_list, self._round_list,
	self._sim_list, self._source_list, self._monitor_list):
	obj.move_by(dx=dx, dy=dy, unit_mode=unit_mode)

assumes each object from the list in the chain has a move_by with dx, dy, and unit_mode parameter. Unfortunately, PhotonicPinInfo (PinInfo) doesn't use unit_mode:

    def move_by(self, dx=0, dy=0):

ref: https://github.com/BerkeleyPhotonicsGenerator/BAG_framework/blob/31334948d686a8241b064995af1ea824d78a5d1c/layout/objects.py#L1917

[pvnbhargava]

Thanks, I can add a unit_mode argument in there.

[pvnbhargava]

Actually I think it would be best to post this issue to the main BAG repository, since this affects them as well. I've forked BAG over into this organization with the intent to embed it within BPG for easier setup, but that task will likely not happen for a while.

The fastest way to resolve your issue would be to change it in the main repo, but regardless when I finish moving BAG over, I will make this change here.

[gnawhleinad]

Actually I think it would be best to post this issue to the main BAG repository, since this affects them as well.

👍, created ucb-art/BAG_framework#8!

(I updated the issue title to explain that this issue could occur in more places.)