Hey I think I found a potential issue when creating a new user. If something happened during the creation on the server side the callback would still return true allowing the user to chat with an undefined username. I think a way to solve this would be to wrap the new user creation in a try catch. I have done the changes here (https://github.com/goteamtim/ioChat/blob/newUser/src/server/server.js). Since I had not posted about this before I made the change I figured I would post an issue rather than a pull request. Any thoughts on this? Should I do a PR?
Hey I think I found a potential issue when creating a new user. If something happened during the creation on the server side the callback would still return true allowing the user to chat with an undefined username. I think a way to solve this would be to wrap the new user creation in a try catch. I have done the changes here (https://github.com/goteamtim/ioChat/blob/newUser/src/server/server.js). Since I had not posted about this before I made the change I figured I would post an issue rather than a pull request. Any thoughts on this? Should I do a PR?