diff --git a/.Rbuildignore b/.Rbuildignore index 8301922..ad4f687 100644 --- a/.Rbuildignore +++ b/.Rbuildignore @@ -12,3 +12,5 @@ cran-comments.md ^pkgdown$ ^cran-comments\.md$ ^CRAN-RELEASE$ +^data-raw$ +^CRAN-SUBMISSION$ diff --git a/.github/workflows/render-readme.yml b/.github/workflows/render-readme.yml new file mode 100644 index 0000000..1a111d9 --- /dev/null +++ b/.github/workflows/render-readme.yml @@ -0,0 +1,40 @@ +# Workflow derived from https://github.com/r-lib/actions/tree/v2/examples +# Need help debugging build failures? Start at https://github.com/r-lib/actions#where-to-find-help + +# this is set to re-render whenever README.Rmd is changed on a given branch +# the file is rendered and committed to the same branch +# adapted from: https://github.com/r-lib/actions/tree/v2/examples#render-rmarkdown +on: + push: + paths: ['README.Rmd'] + +name: render-readme + +jobs: + render-rmarkdown: + runs-on: ubuntu-latest + env: + GITHUB_PAT: ${{ secrets.GITHUB_TOKEN }} + steps: + - name: Checkout repo + uses: actions/checkout@v3 + with: + fetch-depth: 0 + + - uses: r-lib/actions/setup-pandoc@v2 + + - uses: r-lib/actions/setup-r@v2 + + # install packages needed + - name: install required packages + run: Rscript -e 'install.packages(c("rmarkdown"))' + + - name: Render Rmarkdown files and Commit Results + run: | + Rscript -e 'rmarkdown::render("README.Rmd", output_format = "github_document")' + git config --local user.name "$GITHUB_ACTOR" + git config --local user.email "$GITHUB_ACTOR@users.noreply.github.com" + git add README.md || echo "WARN: README.md was not updated" + git add man/figures/README-* || echo "No figure updates were found" + git commit -m 'Re-build Rmarkdown files' || echo "No changes to commit" + git push origin || echo "No changes to commit" diff --git a/CRAN-SUBMISSION b/CRAN-SUBMISSION new file mode 100644 index 0000000..74bb8de --- /dev/null +++ b/CRAN-SUBMISSION @@ -0,0 +1,3 @@ +Version: 0.2.0 +Date: 2024-04-10 14:26:56 UTC +SHA: fb6f1fbe1a4f883c2fa7e819abfa0772dac6be50 diff --git a/DESCRIPTION b/DESCRIPTION index aa54ddc..fe182e1 100644 --- a/DESCRIPTION +++ b/DESCRIPTION @@ -1,6 +1,6 @@ Package: IDEAFilter Type: Package -Version: 0.1.3 +Version: 0.2.0 Title: Agnostic, Idiomatic Data Filter Module for Shiny Description: When added to an existing shiny app, users may subset any developer-chosen R data.frame on the fly. That is, users are empowered to @@ -19,6 +19,9 @@ Authors@R: c( email = "clark.aaronchris@gmail.com", role = c("aut", "cre"), comment = c(ORCID = "0000-0002-0123-0970")), + person( + given = "Jeff", family = "Thompson", + email = "jeff.thompson51317@gmail.com", role = "aut"), person( given = "Doug", family = "Kelkhoff", email = "doug.kelkhoff@gmail.com", role = c("ctb", "cph"), @@ -26,32 +29,32 @@ Authors@R: c( person( given = "Maya", family = "Gans", email = "maya.gans@biogen.com", role = "ctb"), - person( - given = "Jeff", family = "Thompson", - email = "jeff.thompson51317@gmail.com", role = "ctb"), person(family = "SortableJS contributors", role = "ctb", comment = "SortableJS library"), person(given = "Biogen", role = "cph")) -License: AGPL-3 + file LICENSE +License: MIT + file LICENSE URL: https://biogen-inc.github.io/IDEAFilter/, https://github.com/Biogen-Inc/IDEAFilter BugReports: https://github.com/Biogen-Inc/IDEAFilter/issues Encoding: UTF-8 LazyData: true -RoxygenNote: 7.1.2 +RoxygenNote: 7.3.1 Imports: - shiny, + crayon, ggplot2, pillar (>= 1.5.0), - crayon, + purrr, RColorBrewer, - shinyTime, - purrr + shiny, + shinyTime Suggests: - shinytest, - shinytest2, - testthat, + dplyr, knitr, rmarkdown, + shinytest, + shinytest2, spelling, - dplyr + testthat Language: en-US +VignetteBuilder: knitr +Depends: + R (>= 2.10) diff --git a/LICENSE b/LICENSE index b667dd8..881b967 100644 --- a/LICENSE +++ b/LICENSE @@ -1,3 +1,6 @@ +YEAR: 2024 +COPYRIGHT HOLDER: Biogen Inc + The IDEAFilter package includes other open source software components. The following is a list of these components (full copies of the license agreements used by these components are included below): @@ -53,4 +56,4 @@ FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE -SOFTWARE. \ No newline at end of file +SOFTWARE. diff --git a/LICENSE.md b/LICENSE.md index fab6548..6c6f0ed 100644 --- a/LICENSE.md +++ b/LICENSE.md @@ -1,659 +1,21 @@ -GNU Affero General Public License -================================= - -_Version 3, 19 November 2007_ -_Copyright (C) 2007 Free Software Foundation, Inc. <>_ - -Everyone is permitted to copy and distribute verbatim copies of this -license document, but changing it is not allowed. - -## Preamble - -The GNU Affero General Public License is a free, copyleft license for -software and other kinds of works, specifically designed to ensure -cooperation with the community in the case of network server software. - -The licenses for most software and other practical works are designed -to take away your freedom to share and change the works. By contrast, -our General Public Licenses are intended to guarantee your freedom to -share and change all versions of a program--to make sure it remains -free software for all its users. - -When we speak of free software, we are referring to freedom, not -price. Our General Public Licenses are designed to make sure that you -have the freedom to distribute copies of free software (and charge for -them if you wish), that you receive source code or can get it if you -want it, that you can change the software or use pieces of it in new -free programs, and that you know you can do these things. - -Developers that use our General Public Licenses protect your rights -with two steps: (1) assert copyright on the software, and (2) offer -you this License which gives you legal permission to copy, distribute -and/or modify the software. - -A secondary benefit of defending all users' freedom is that -improvements made in alternate versions of the program, if they -receive widespread use, become available for other developers to -incorporate. Many developers of free software are heartened and -encouraged by the resulting cooperation. However, in the case of -software used on network servers, this result may fail to come about. -The GNU General Public License permits making a modified version and -letting the public access it on a server without ever releasing its -source code to the public. - -The GNU Affero General Public License is designed specifically to -ensure that, in such cases, the modified source code becomes available -to the community. It requires the operator of a network server to -provide the source code of the modified version running there to the -users of that server. Therefore, public use of a modified version, on -a publicly accessible server, gives the public access to the source -code of the modified version. - -An older license, called the Affero General Public License and -published by Affero, was designed to accomplish similar goals. This is -a different license, not a version of the Affero GPL, but Affero has -released a new version of the Affero GPL which permits relicensing -under this license. - -The precise terms and conditions for copying, distribution and -modification follow. - -## TERMS AND CONDITIONS - -### 0. Definitions. - -"This License" refers to version 3 of the GNU Affero General Public -License. - -"Copyright" also means copyright-like laws that apply to other kinds -of works, such as semiconductor masks. - -"The Program" refers to any copyrightable work licensed under this -License. Each licensee is addressed as "you". "Licensees" and -"recipients" may be individuals or organizations. - -To "modify" a work means to copy from or adapt all or part of the work -in a fashion requiring copyright permission, other than the making of -an exact copy. The resulting work is called a "modified version" of -the earlier work or a work "based on" the earlier work. - -A "covered work" means either the unmodified Program or a work based -on the Program. - -To "propagate" a work means to do anything with it that, without -permission, would make you directly or secondarily liable for -infringement under applicable copyright law, except executing it on a -computer or modifying a private copy. Propagation includes copying, -distribution (with or without modification), making available to the -public, and in some countries other activities as well. - -To "convey" a work means any kind of propagation that enables other -parties to make or receive copies. Mere interaction with a user -through a computer network, with no transfer of a copy, is not -conveying. - -An interactive user interface displays "Appropriate Legal Notices" to -the extent that it includes a convenient and prominently visible -feature that (1) displays an appropriate copyright notice, and (2) -tells the user that there is no warranty for the work (except to the -extent that warranties are provided), that licensees may convey the -work under this License, and how to view a copy of this License. If -the interface presents a list of user commands or options, such as a -menu, a prominent item in the list meets this criterion. - -### 1. Source Code. - -The "source code" for a work means the preferred form of the work for -making modifications to it. "Object code" means any non-source form of -a work. - -A "Standard Interface" means an interface that either is an official -standard defined by a recognized standards body, or, in the case of -interfaces specified for a particular programming language, one that -is widely used among developers working in that language. - -The "System Libraries" of an executable work include anything, other -than the work as a whole, that (a) is included in the normal form of -packaging a Major Component, but which is not part of that Major -Component, and (b) serves only to enable use of the work with that -Major Component, or to implement a Standard Interface for which an -implementation is available to the public in source code form. A -"Major Component", in this context, means a major essential component -(kernel, window system, and so on) of the specific operating system -(if any) on which the executable work runs, or a compiler used to -produce the work, or an object code interpreter used to run it. - -The "Corresponding Source" for a work in object code form means all -the source code needed to generate, install, and (for an executable -work) run the object code and to modify the work, including scripts to -control those activities. However, it does not include the work's -System Libraries, or general-purpose tools or generally available free -programs which are used unmodified in performing those activities but -which are not part of the work. For example, Corresponding Source -includes interface definition files associated with source files for -the work, and the source code for shared libraries and dynamically -linked subprograms that the work is specifically designed to require, -such as by intimate data communication or control flow between those -subprograms and other parts of the work. - -The Corresponding Source need not include anything that users can -regenerate automatically from other parts of the Corresponding Source. - -The Corresponding Source for a work in source code form is that same -work. - -### 2. Basic Permissions. - -All rights granted under this License are granted for the term of -copyright on the Program, and are irrevocable provided the stated -conditions are met. This License explicitly affirms your unlimited -permission to run the unmodified Program. The output from running a -covered work is covered by this License only if the output, given its -content, constitutes a covered work. This License acknowledges your -rights of fair use or other equivalent, as provided by copyright law. - -You may make, run and propagate covered works that you do not convey, -without conditions so long as your license otherwise remains in force. -You may convey covered works to others for the sole purpose of having -them make modifications exclusively for you, or provide you with -facilities for running those works, provided that you comply with the -terms of this License in conveying all material for which you do not -control copyright. Those thus making or running the covered works for -you must do so exclusively on your behalf, under your direction and -control, on terms that prohibit them from making any copies of your -copyrighted material outside their relationship with you. - -Conveying under any other circumstances is permitted solely under the -conditions stated below. Sublicensing is not allowed; section 10 makes -it unnecessary. - -### 3. Protecting Users' Legal Rights From Anti-Circumvention Law. - -No covered work shall be deemed part of an effective technological -measure under any applicable law fulfilling obligations under article -11 of the WIPO copyright treaty adopted on 20 December 1996, or -similar laws prohibiting or restricting circumvention of such -measures. - -When you convey a covered work, you waive any legal power to forbid -circumvention of technological measures to the extent such -circumvention is effected by exercising rights under this License with -respect to the covered work, and you disclaim any intention to limit -operation or modification of the work as a means of enforcing, against -the work's users, your or third parties' legal rights to forbid -circumvention of technological measures. - -### 4. Conveying Verbatim Copies. - -You may convey verbatim copies of the Program's source code as you -receive it, in any medium, provided that you conspicuously and -appropriately publish on each copy an appropriate copyright notice; -keep intact all notices stating that this License and any -non-permissive terms added in accord with section 7 apply to the code; -keep intact all notices of the absence of any warranty; and give all -recipients a copy of this License along with the Program. - -You may charge any price or no price for each copy that you convey, -and you may offer support or warranty protection for a fee. - -### 5. Conveying Modified Source Versions. - -You may convey a work based on the Program, or the modifications to -produce it from the Program, in the form of source code under the -terms of section 4, provided that you also meet all of these -conditions: - -- a) The work must carry prominent notices stating that you modified - it, and giving a relevant date. -- b) The work must carry prominent notices stating that it is - released under this License and any conditions added under - section 7. This requirement modifies the requirement in section 4 - to "keep intact all notices". -- c) You must license the entire work, as a whole, under this - License to anyone who comes into possession of a copy. This - License will therefore apply, along with any applicable section 7 - additional terms, to the whole of the work, and all its parts, - regardless of how they are packaged. This License gives no - permission to license the work in any other way, but it does not - invalidate such permission if you have separately received it. -- d) If the work has interactive user interfaces, each must display - Appropriate Legal Notices; however, if the Program has interactive - interfaces that do not display Appropriate Legal Notices, your - work need not make them do so. - -A compilation of a covered work with other separate and independent -works, which are not by their nature extensions of the covered work, -and which are not combined with it such as to form a larger program, -in or on a volume of a storage or distribution medium, is called an -"aggregate" if the compilation and its resulting copyright are not -used to limit the access or legal rights of the compilation's users -beyond what the individual works permit. Inclusion of a covered work -in an aggregate does not cause this License to apply to the other -parts of the aggregate. - -### 6. Conveying Non-Source Forms. - -You may convey a covered work in object code form under the terms of -sections 4 and 5, provided that you also convey the machine-readable -Corresponding Source under the terms of this License, in one of these -ways: - -- a) Convey the object code in, or embodied in, a physical product - (including a physical distribution medium), accompanied by the - Corresponding Source fixed on a durable physical medium - customarily used for software interchange. -- b) Convey the object code in, or embodied in, a physical product - (including a physical distribution medium), accompanied by a - written offer, valid for at least three years and valid for as - long as you offer spare parts or customer support for that product - model, to give anyone who possesses the object code either (1) a - copy of the Corresponding Source for all the software in the - product that is covered by this License, on a durable physical - medium customarily used for software interchange, for a price no - more than your reasonable cost of physically performing this - conveying of source, or (2) access to copy the Corresponding - Source from a network server at no charge. -- c) Convey individual copies of the object code with a copy of the - written offer to provide the Corresponding Source. This - alternative is allowed only occasionally and noncommercially, and - only if you received the object code with such an offer, in accord - with subsection 6b. -- d) Convey the object code by offering access from a designated - place (gratis or for a charge), and offer equivalent access to the - Corresponding Source in the same way through the same place at no - further charge. You need not require recipients to copy the - Corresponding Source along with the object code. If the place to - copy the object code is a network server, the Corresponding Source - may be on a different server (operated by you or a third party) - that supports equivalent copying facilities, provided you maintain - clear directions next to the object code saying where to find the - Corresponding Source. Regardless of what server hosts the - Corresponding Source, you remain obligated to ensure that it is - available for as long as needed to satisfy these requirements. -- e) Convey the object code using peer-to-peer transmission, - provided you inform other peers where the object code and - Corresponding Source of the work are being offered to the general - public at no charge under subsection 6d. - -A separable portion of the object code, whose source code is excluded -from the Corresponding Source as a System Library, need not be -included in conveying the object code work. - -A "User Product" is either (1) a "consumer product", which means any -tangible personal property which is normally used for personal, -family, or household purposes, or (2) anything designed or sold for -incorporation into a dwelling. In determining whether a product is a -consumer product, doubtful cases shall be resolved in favor of -coverage. For a particular product received by a particular user, -"normally used" refers to a typical or common use of that class of -product, regardless of the status of the particular user or of the way -in which the particular user actually uses, or expects or is expected -to use, the product. A product is a consumer product regardless of -whether the product has substantial commercial, industrial or -non-consumer uses, unless such uses represent the only significant -mode of use of the product. - -"Installation Information" for a User Product means any methods, -procedures, authorization keys, or other information required to -install and execute modified versions of a covered work in that User -Product from a modified version of its Corresponding Source. The -information must suffice to ensure that the continued functioning of -the modified object code is in no case prevented or interfered with -solely because modification has been made. - -If you convey an object code work under this section in, or with, or -specifically for use in, a User Product, and the conveying occurs as -part of a transaction in which the right of possession and use of the -User Product is transferred to the recipient in perpetuity or for a -fixed term (regardless of how the transaction is characterized), the -Corresponding Source conveyed under this section must be accompanied -by the Installation Information. But this requirement does not apply -if neither you nor any third party retains the ability to install -modified object code on the User Product (for example, the work has -been installed in ROM). - -The requirement to provide Installation Information does not include a -requirement to continue to provide support service, warranty, or -updates for a work that has been modified or installed by the -recipient, or for the User Product in which it has been modified or -installed. Access to a network may be denied when the modification -itself materially and adversely affects the operation of the network -or violates the rules and protocols for communication across the -network. - -Corresponding Source conveyed, and Installation Information provided, -in accord with this section must be in a format that is publicly -documented (and with an implementation available to the public in -source code form), and must require no special password or key for -unpacking, reading or copying. - -### 7. Additional Terms. - -"Additional permissions" are terms that supplement the terms of this -License by making exceptions from one or more of its conditions. -Additional permissions that are applicable to the entire Program shall -be treated as though they were included in this License, to the extent -that they are valid under applicable law. If additional permissions -apply only to part of the Program, that part may be used separately -under those permissions, but the entire Program remains governed by -this License without regard to the additional permissions. - -When you convey a copy of a covered work, you may at your option -remove any additional permissions from that copy, or from any part of -it. (Additional permissions may be written to require their own -removal in certain cases when you modify the work.) You may place -additional permissions on material, added by you to a covered work, -for which you have or can give appropriate copyright permission. - -Notwithstanding any other provision of this License, for material you -add to a covered work, you may (if authorized by the copyright holders -of that material) supplement the terms of this License with terms: - -- a) Disclaiming warranty or limiting liability differently from the - terms of sections 15 and 16 of this License; or -- b) Requiring preservation of specified reasonable legal notices or - author attributions in that material or in the Appropriate Legal - Notices displayed by works containing it; or -- c) Prohibiting misrepresentation of the origin of that material, - or requiring that modified versions of such material be marked in - reasonable ways as different from the original version; or -- d) Limiting the use for publicity purposes of names of licensors - or authors of the material; or -- e) Declining to grant rights under trademark law for use of some - trade names, trademarks, or service marks; or -- f) Requiring indemnification of licensors and authors of that - material by anyone who conveys the material (or modified versions - of it) with contractual assumptions of liability to the recipient, - for any liability that these contractual assumptions directly - impose on those licensors and authors. - -All other non-permissive additional terms are considered "further -restrictions" within the meaning of section 10. If the Program as you -received it, or any part of it, contains a notice stating that it is -governed by this License along with a term that is a further -restriction, you may remove that term. If a license document contains -a further restriction but permits relicensing or conveying under this -License, you may add to a covered work material governed by the terms -of that license document, provided that the further restriction does -not survive such relicensing or conveying. - -If you add terms to a covered work in accord with this section, you -must place, in the relevant source files, a statement of the -additional terms that apply to those files, or a notice indicating -where to find the applicable terms. - -Additional terms, permissive or non-permissive, may be stated in the -form of a separately written license, or stated as exceptions; the -above requirements apply either way. - -### 8. Termination. - -You may not propagate or modify a covered work except as expressly -provided under this License. Any attempt otherwise to propagate or -modify it is void, and will automatically terminate your rights under -this License (including any patent licenses granted under the third -paragraph of section 11). - -However, if you cease all violation of this License, then your license -from a particular copyright holder is reinstated (a) provisionally, -unless and until the copyright holder explicitly and finally -terminates your license, and (b) permanently, if the copyright holder -fails to notify you of the violation by some reasonable means prior to -60 days after the cessation. - -Moreover, your license from a particular copyright holder is -reinstated permanently if the copyright holder notifies you of the -violation by some reasonable means, this is the first time you have -received notice of violation of this License (for any work) from that -copyright holder, and you cure the violation prior to 30 days after -your receipt of the notice. - -Termination of your rights under this section does not terminate the -licenses of parties who have received copies or rights from you under -this License. If your rights have been terminated and not permanently -reinstated, you do not qualify to receive new licenses for the same -material under section 10. - -### 9. Acceptance Not Required for Having Copies. - -You are not required to accept this License in order to receive or run -a copy of the Program. Ancillary propagation of a covered work -occurring solely as a consequence of using peer-to-peer transmission -to receive a copy likewise does not require acceptance. However, -nothing other than this License grants you permission to propagate or -modify any covered work. These actions infringe copyright if you do -not accept this License. Therefore, by modifying or propagating a -covered work, you indicate your acceptance of this License to do so. - -### 10. Automatic Licensing of Downstream Recipients. - -Each time you convey a covered work, the recipient automatically -receives a license from the original licensors, to run, modify and -propagate that work, subject to this License. You are not responsible -for enforcing compliance by third parties with this License. - -An "entity transaction" is a transaction transferring control of an -organization, or substantially all assets of one, or subdividing an -organization, or merging organizations. If propagation of a covered -work results from an entity transaction, each party to that -transaction who receives a copy of the work also receives whatever -licenses to the work the party's predecessor in interest had or could -give under the previous paragraph, plus a right to possession of the -Corresponding Source of the work from the predecessor in interest, if -the predecessor has it or can get it with reasonable efforts. - -You may not impose any further restrictions on the exercise of the -rights granted or affirmed under this License. For example, you may -not impose a license fee, royalty, or other charge for exercise of -rights granted under this License, and you may not initiate litigation -(including a cross-claim or counterclaim in a lawsuit) alleging that -any patent claim is infringed by making, using, selling, offering for -sale, or importing the Program or any portion of it. - -### 11. Patents. - -A "contributor" is a copyright holder who authorizes use under this -License of the Program or a work on which the Program is based. The -work thus licensed is called the contributor's "contributor version". - -A contributor's "essential patent claims" are all patent claims owned -or controlled by the contributor, whether already acquired or -hereafter acquired, that would be infringed by some manner, permitted -by this License, of making, using, or selling its contributor version, -but do not include claims that would be infringed only as a -consequence of further modification of the contributor version. For -purposes of this definition, "control" includes the right to grant -patent sublicenses in a manner consistent with the requirements of -this License. - -Each contributor grants you a non-exclusive, worldwide, royalty-free -patent license under the contributor's essential patent claims, to -make, use, sell, offer for sale, import and otherwise run, modify and -propagate the contents of its contributor version. - -In the following three paragraphs, a "patent license" is any express -agreement or commitment, however denominated, not to enforce a patent -(such as an express permission to practice a patent or covenant not to -sue for patent infringement). To "grant" such a patent license to a -party means to make such an agreement or commitment not to enforce a -patent against the party. - -If you convey a covered work, knowingly relying on a patent license, -and the Corresponding Source of the work is not available for anyone -to copy, free of charge and under the terms of this License, through a -publicly available network server or other readily accessible means, -then you must either (1) cause the Corresponding Source to be so -available, or (2) arrange to deprive yourself of the benefit of the -patent license for this particular work, or (3) arrange, in a manner -consistent with the requirements of this License, to extend the patent -license to downstream recipients. "Knowingly relying" means you have -actual knowledge that, but for the patent license, your conveying the -covered work in a country, or your recipient's use of the covered work -in a country, would infringe one or more identifiable patents in that -country that you have reason to believe are valid. - -If, pursuant to or in connection with a single transaction or -arrangement, you convey, or propagate by procuring conveyance of, a -covered work, and grant a patent license to some of the parties -receiving the covered work authorizing them to use, propagate, modify -or convey a specific copy of the covered work, then the patent license -you grant is automatically extended to all recipients of the covered -work and works based on it. - -A patent license is "discriminatory" if it does not include within the -scope of its coverage, prohibits the exercise of, or is conditioned on -the non-exercise of one or more of the rights that are specifically -granted under this License. You may not convey a covered work if you -are a party to an arrangement with a third party that is in the -business of distributing software, under which you make payment to the -third party based on the extent of your activity of conveying the -work, and under which the third party grants, to any of the parties -who would receive the covered work from you, a discriminatory patent -license (a) in connection with copies of the covered work conveyed by -you (or copies made from those copies), or (b) primarily for and in -connection with specific products or compilations that contain the -covered work, unless you entered into that arrangement, or that patent -license was granted, prior to 28 March 2007. - -Nothing in this License shall be construed as excluding or limiting -any implied license or other defenses to infringement that may -otherwise be available to you under applicable patent law. - -### 12. No Surrender of Others' Freedom. - -If conditions are imposed on you (whether by court order, agreement or -otherwise) that contradict the conditions of this License, they do not -excuse you from the conditions of this License. If you cannot convey a -covered work so as to satisfy simultaneously your obligations under -this License and any other pertinent obligations, then as a -consequence you may not convey it at all. For example, if you agree to -terms that obligate you to collect a royalty for further conveying -from those to whom you convey the Program, the only way you could -satisfy both those terms and this License would be to refrain entirely -from conveying the Program. - -### 13. Remote Network Interaction; Use with the GNU General Public License. - -Notwithstanding any other provision of this License, if you modify the -Program, your modified version must prominently offer all users -interacting with it remotely through a computer network (if your -version supports such interaction) an opportunity to receive the -Corresponding Source of your version by providing access to the -Corresponding Source from a network server at no charge, through some -standard or customary means of facilitating copying of software. This -Corresponding Source shall include the Corresponding Source for any -work covered by version 3 of the GNU General Public License that is -incorporated pursuant to the following paragraph. - -Notwithstanding any other provision of this License, you have -permission to link or combine any covered work with a work licensed -under version 3 of the GNU General Public License into a single -combined work, and to convey the resulting work. The terms of this -License will continue to apply to the part which is the covered work, -but the work with which it is combined will remain governed by version -3 of the GNU General Public License. - -### 14. Revised Versions of this License. - -The Free Software Foundation may publish revised and/or new versions -of the GNU Affero General Public License from time to time. Such new -versions will be similar in spirit to the present version, but may -differ in detail to address new problems or concerns. - -Each version is given a distinguishing version number. If the Program -specifies that a certain numbered version of the GNU Affero General -Public License "or any later version" applies to it, you have the -option of following the terms and conditions either of that numbered -version or of any later version published by the Free Software -Foundation. If the Program does not specify a version number of the -GNU Affero General Public License, you may choose any version ever -published by the Free Software Foundation. - -If the Program specifies that a proxy can decide which future versions -of the GNU Affero General Public License can be used, that proxy's -public statement of acceptance of a version permanently authorizes you -to choose that version for the Program. - -Later license versions may give you additional or different -permissions. However, no additional obligations are imposed on any -author or copyright holder as a result of your choosing to follow a -later version. - -### 15. Disclaimer of Warranty. - -THERE IS NO WARRANTY FOR THE PROGRAM, TO THE EXTENT PERMITTED BY -APPLICABLE LAW. EXCEPT WHEN OTHERWISE STATED IN WRITING THE COPYRIGHT -HOLDERS AND/OR OTHER PARTIES PROVIDE THE PROGRAM "AS IS" WITHOUT -WARRANTY OF ANY KIND, EITHER EXPRESSED OR IMPLIED, INCLUDING, BUT NOT -LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR -A PARTICULAR PURPOSE. THE ENTIRE RISK AS TO THE QUALITY AND -PERFORMANCE OF THE PROGRAM IS WITH YOU. SHOULD THE PROGRAM PROVE -DEFECTIVE, YOU ASSUME THE COST OF ALL NECESSARY SERVICING, REPAIR OR -CORRECTION. - -### 16. Limitation of Liability. - -IN NO EVENT UNLESS REQUIRED BY APPLICABLE LAW OR AGREED TO IN WRITING -WILL ANY COPYRIGHT HOLDER, OR ANY OTHER PARTY WHO MODIFIES AND/OR -CONVEYS THE PROGRAM AS PERMITTED ABOVE, BE LIABLE TO YOU FOR DAMAGES, -INCLUDING ANY GENERAL, SPECIAL, INCIDENTAL OR CONSEQUENTIAL DAMAGES -ARISING OUT OF THE USE OR INABILITY TO USE THE PROGRAM (INCLUDING BUT -NOT LIMITED TO LOSS OF DATA OR DATA BEING RENDERED INACCURATE OR -LOSSES SUSTAINED BY YOU OR THIRD PARTIES OR A FAILURE OF THE PROGRAM -TO OPERATE WITH ANY OTHER PROGRAMS), EVEN IF SUCH HOLDER OR OTHER -PARTY HAS BEEN ADVISED OF THE POSSIBILITY OF SUCH DAMAGES. - -### 17. Interpretation of Sections 15 and 16. - -If the disclaimer of warranty and limitation of liability provided -above cannot be given local legal effect according to their terms, -reviewing courts shall apply local law that most closely approximates -an absolute waiver of all civil liability in connection with the -Program, unless a warranty or assumption of liability accompanies a -copy of the Program in return for a fee. - -END OF TERMS AND CONDITIONS - -## How to Apply These Terms to Your New Programs - -If you develop a new program, and you want it to be of the greatest -possible use to the public, the best way to achieve this is to make it -free software which everyone can redistribute and change under these -terms. - -To do so, attach the following notices to the program. It is safest to -attach them to the start of each source file to most effectively state -the exclusion of warranty; and each file should have at least the -"copyright" line and a pointer to where the full notice is found. - - - Copyright (C) - - This program is free software: you can redistribute it and/or modify - it under the terms of the GNU Affero General Public License as - published by the Free Software Foundation, either version 3 of the - License, or (at your option) any later version. - - This program is distributed in the hope that it will be useful, - but WITHOUT ANY WARRANTY; without even the implied warranty of - MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the - GNU Affero General Public License for more details. - - You should have received a copy of the GNU Affero General Public License - along with this program. If not, see . - -Also add information on how to contact you by electronic and paper -mail. - -If your software can interact with users remotely through a computer -network, you should also make sure that it provides a way for users to -get its source. For example, if your program is a web application, its -interface could display a "Source" link that leads users to an archive -of the code. There are many ways you could offer source, and different -solutions will be better for different programs; see section 13 for -the specific requirements. - -You should also get your employer (if you work as a programmer) or -school, if any, to sign a "copyright disclaimer" for the program, if -necessary. For more information on this, and how to apply and follow -the GNU AGPL, see . +# MIT License + +Copyright (c) 2024 Biogen Inc + +Permission is hereby granted, free of charge, to any person obtaining a copy +of this software and associated documentation files (the "Software"), to deal +in the Software without restriction, including without limitation the rights +to use, copy, modify, merge, publish, distribute, sublicense, and/or sell +copies of the Software, and to permit persons to whom the Software is +furnished to do so, subject to the following conditions: + +The above copyright notice and this permission notice shall be included in all +copies or substantial portions of the Software. + +THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR +IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, +FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE +AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER +LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, +OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE +SOFTWARE. diff --git a/NAMESPACE b/NAMESPACE index 12a7dba..c055b2d 100644 --- a/NAMESPACE +++ b/NAMESPACE @@ -16,6 +16,10 @@ S3method(shiny_vector_filter_ui,default) S3method(shiny_vector_filter_ui,factor) S3method(shiny_vector_filter_ui,logical) S3method(shiny_vector_filter_ui,numeric) +export(IDEAFilter) +export(IDEAFilter_item) +export(IDEAFilter_item_ui) +export(IDEAFilter_ui) export(getInitializationCode.shinyDataFilter_df) export(shiny_data_filter) export(shiny_data_filter_item) @@ -40,8 +44,9 @@ importFrom(ggplot2,scale_x_discrete) importFrom(ggplot2,scale_y_continuous) importFrom(ggplot2,theme_void) importFrom(grDevices,rgb) -importFrom(pillar,new_pillar_type) +importFrom(pillar,type_sum) importFrom(purrr,map) +importFrom(purrr,possibly) importFrom(purrr,reduce) importFrom(shiny,HTML) importFrom(shiny,NS) @@ -77,6 +82,7 @@ importFrom(shiny,uiOutput) importFrom(shiny,validate) importFrom(shiny,wellPanel) importFrom(shinyTime,timeInput) +importFrom(shinyTime,updateTimeInput) importFrom(stats,density) importFrom(stats,setNames) importFrom(utils,capture.output) diff --git a/NEWS.md b/NEWS.md index 6b9ecee..15c0269 100644 --- a/NEWS.md +++ b/NEWS.md @@ -1,3 +1,18 @@ +# IDEAFilter 0.2.0 + +## New features +* Added a new module implementation `IDEAFilter()` that is more modern and uses less resources. The old implementation `shiny_data_filter()` has been deprecated. +* Added a feature to allow users to restrict the filter to a subset of columns +* Added an erase button to filter items to allow users to clear applied filters + +## Minor improvements and fixes +* Fixed a bug that was trying to assign an attribute to a NULL +* Fixed a bug that was causing inaccurate filtering for `datetime` vectors +* Fixed a bug that was not always including a selected NA filter for `logical` vectors +* Fixed a bug that was causing the column selectize input to fail +* Upgraded `pillar::new_pillar_type()` to `pillar::type_sum()` +* Added trash collector to delete inputs and observers from dynamic vector modules when removed from UI + # IDEAFilter 0.1.3 * Cited works of other contributors (`shinyDataFilter` & `SortableJS`) diff --git a/R/IDEAFilter.R b/R/IDEAFilter.R new file mode 100644 index 0000000..3364a38 --- /dev/null +++ b/R/IDEAFilter.R @@ -0,0 +1,311 @@ +#' User interface function to add a data filter panel +#' +#' This is a wrapper for \code{\link{shiny_data_filter_ui}} created to match up +#' with the module server function \code{\link{IDEAFilter}}. +#' +#' @param id a module id name +#' @return a shiny \code{\link[shiny]{tagList}} containing the filter ui +#' +#' @import shiny +#' +#' @importFrom shiny NS tagList div actionButton icon +#' @export +#' @keywords internal +#' @seealso \link{shiny_data_filter_ui}, \link{IDEAFilter} +#' +#' @inherit shiny_data_filter examples +#' +IDEAFilter_ui <- function(id) { + ns <- shiny::NS(id) + + shinyDataFilter_resourcePath() + + shiny::tagList( + css_sortableJS_style_script(), + js_sortableJS_script(), + css_shinyDataFilter_animation_script(), + css_shinyDataFilter_style_script(), + shiny::div( + id = ns("sortableList"), + class = "listWithHandle list-group", + style = "margin-bottom: 0;"), + shiny::div( + id = "shinyDataFilter-addFilter", + width = "100%", + uiOutput(ns("add_filter_select_ui"))) + ) +} + +#' IDEA data filter module server function +#' +#' Serves as a wrapper for \code{\link{shiny_data_filter}} and utilizes +#' \code{moduleSever()} for a more modern implementation of the data item +#' filter. +#' +#' @param id a module id name +#' @param data a \code{data.frame} or \code{reactive expression} returning a +#' \code{data.frame} to use as the input to the filter module +#' @param ... placeholder for inclusion of additional parameters in future development +#' @param col_subset a \code{vector} containing the list of allowable columns to filter on +#' @param preselection a \code{list} that can be used to pre-populate the filter +#' @param verbose a \code{logical} value indicating whether or not to print log +#' statements out to the console +#' +#' @return a \code{reactive expression} which returns the filtered data wrapped +#' in an additional class, "shinyDataFilter_df". This structure also contains +#' a "code" field which represents the code needed to generate the filtered +#' data. +#' +#' @seealso \link{IDEAFilter_ui}, \link{shiny_data_filter} +#' +#' @import shiny +#' @importFrom utils head tail +#' @importFrom stats setNames +#' @export +#' +#' @examples +#' if(all(c(interactive(), require("dplyr"), require("IDEAFilter")))) { +#' library(shiny) +#' library(IDEAFilter) +#' library(dplyr) # for data pre-processing and example data +#' +#' # prep a new data.frame with more diverse data types +#' starwars2 <- starwars %>% +#' mutate_if(~is.numeric(.) && all(Filter(Negate(is.na), .) %% 1 == 0), as.integer) %>% +#' mutate_if(~is.character(.) && length(unique(.)) <= 25, as.factor) %>% +#' mutate(is_droid = species == "Droid") %>% +#' select(name, gender, height, mass, hair_color, eye_color, vehicles, is_droid) +#' +#' # create some labels to showcase column select input +#' attr(starwars2$name, "label") <- "name of character" +#' attr(starwars2$gender, "label") <- "gender of character" +#' attr(starwars2$height, "label") <- "height of character in centimeters" +#' attr(starwars2$mass, "label") <- "mass of character in kilograms" +#' attr(starwars2$is_droid, "label") <- "whether character is a droid" +#' +#' ui <- fluidPage( +#' titlePanel("Filter Data Example"), +#' fluidRow( +#' column(8, +#' verbatimTextOutput("data_summary"), +#' verbatimTextOutput("data_filter_code")), +#' column(4, IDEAFilter_ui("data_filter")))) +#' +#' server <- function(input, output, session) { +#' filtered_data <- IDEAFilter("data_filter", data = starwars2, verbose = FALSE) +#' +#' output$data_filter_code <- renderPrint({ +#' cat(gsub("%>%", "%>% \n ", +#' gsub("\\s{2,}", " ", +#' paste0( +#' capture.output(attr(filtered_data(), "code")), +#' collapse = " ")) +#' )) +#' }) +#' +#' output$data_summary <- renderPrint({ +#' if (nrow(filtered_data())) show(filtered_data()) +#' else "No data available" +#' }) +#' } +#' +#' shinyApp(ui = ui, server = server) +#' } +#' +IDEAFilter <- function(id, data, ..., col_subset = NULL, preselection = NULL, verbose = FALSE) { + moduleServer(id, function(input, output, session) { + ns <- session$ns + filter_log("calling module", verbose = verbose) + + data_call <- as.list(sys.call(-7L))$data + datar <- if (is.reactive(data)) data else reactive(data) + col_subsetr <- if (is.reactive(col_subset)) col_subset else reactive(col_subset) + preselectionr <- if (is.reactive(preselection)) preselection else reactive(preselection) + + filter_counter <- 0 + next_filter_id <- function() { + filter_counter <<- filter_counter + 1 + sprintf("filter_%d", filter_counter) + } + + filters <- reactiveVal(c("filter_0")) + filter_returns <- list(filter_0 = reactiveValues( + data = datar, + pre_filters = reactive(list()), + filters = reactive(list()), + remove = NULL)) + + update_filter <- function(fid, in_fid, column_name = NULL, preselection = NULL) { + fs <- isolate(filters()) + + if (missing(in_fid)) + if (fid %in% fs) in_fid <- fs[[utils::head(which(fid == fs), 1) - 1]] + else in_fid <- utils::tail(fs, 1) + + if (!in_fid %in% fs | !in_fid %in% names(filter_returns)) + stop('no known filter for inbound filter id.') + + if (fid %in% names(filter_returns)) { + filter_returns[[fid]]$pre_filters <- filter_returns[[in_fid]]$filters + } else { + filter_returns[[fid]] <<- IDEAFilter_item( + fid, + data = datar, + column_name = column_name, + filters = filter_returns[[in_fid]]$filters, + col_subset = col_subsetr, + preselection = preselection, + verbose = verbose) + } + } + + apply_preselection <- function(preselection = NULL) { + + for (col_sel in (names(preselectionr()) %||% preselectionr())) { + if (!col_sel %in% names(datar())) { + warning(sprintf("Unable to add `%s` to filter list.", col_sel)) + next() + } + + update_filter(fid <- next_filter_id(), column_name = col_sel, preselection = if(is.list(preselectionr())) preselectionr()[[col_sel]]) + filters(append(filters(), fid)) + + insertUI( + selector = sprintf("#%s", ns("sortableList")), + where = "beforeEnd", + ui = IDEAFilter_item_ui(ns(fid))) + + updateSelectInput(session, "add_filter_select", selected = "") + } + } + + output$add_filter_select_ui <- renderUI({ + req(datar()) + columnSelectInput( + ns("add_filter_select"), + label = NULL, + data = datar, + col_subset = col_subsetr, + placeholder = "Add Filter", + width = "100%") + }) + + observe({ + filter_log("scrubbing filters tagged for removal", verbose = verbose) + for (fid in filters()[-1]) + if (isTRUE(filter_returns[[fid]]$remove)) { + idx <- utils::head(which(filters() == fid), 1) + filter_returns[[fid]]$destroy + + filters(setdiff(filters(), fid)) + + # overwrite existing module call with one taking new input data + if (!idx > length(filters())) update_filter(filters()[[idx]]) + + removeUI(selector = sprintf("#%s-ui", ns(fid))) + break + } + }) + + observeEvent(input$add_filter_btn, { + filter_log("observing add filter button press", verbose = verbose) + update_filter(fid <- next_filter_id()) + filters(append(filters(), fid)) + + insertUI( + selector = sprintf("#%s", ns("sortableList")), + where = "beforeEnd", + ui = IDEAFilter_item_ui(ns(fid))) + }) + + observeEvent(input$add_filter_select, { + req(preselectionr()) + + filter_log("observing pre-selected columns", verbose = verbose) + + apply_preselection(preselectionr()) + }, once = TRUE) + + observeEvent(preselectionr(), { + req(!is.null(input$add_filter_select)) + + filter_log("scrubbing all filters", verbose = verbose) + for (fid in filters()[-1]) { + idx <- utils::head(which(filters() == fid), 1) + filter_returns[[fid]]$destroy + + filters(setdiff(filters(), fid)) + + # overwrite existing module call with one taking new input data + if (!idx > length(filters())) update_filter(filters()[[idx]]) + + removeUI(selector = sprintf("#%s-ui", ns(fid))) + } + + filter_log("applying updated selection", verbose = verbose) + apply_preselection(preselectionr()) + + }) + + observeEvent(input$add_filter_select, { + if (!input$add_filter_select %in% names(datar())) return() + + filter_log("observing add filter button press", verbose = verbose) + update_filter(fid <- next_filter_id(), column_name = input$add_filter_select) + filters(append(filters(), fid)) + + insertUI( + selector = sprintf("#%s", ns("sortableList")), + where = "beforeEnd", + ui = IDEAFilter_item_ui(ns(fid))) + + updateSelectInput(session, "add_filter_select", selected = "") + }, ignoreInit = TRUE, ignoreNULL = TRUE) + + # observe drag-and-drop and update data flow + observeEvent(input$sortableList, { + old_filters <- filters() + + filters(c( + filters()[1], # preserve input 'filter' + gsub(sprintf("^%s", ns("")), "", Filter(nchar, input$sortableList)) + )) + + filter_log("updating sortableJS list: ", + paste(filters(), collapse = ", "), + verbose = verbose) + + # update filters downstream of change, isolate to prevent premature updates + idxs <- which(cumsum(old_filters != filters()) > 0) + + isolate(for (idx in idxs) update_filter(filters()[[idx]])) + }) + + filter_logical <- reactiveVal(TRUE) + observeEvent(datar(), { + filter_logical(TRUE) + }) + code <- reactive({ + req(datar()) + filter_log("building code", verbose = verbose) + filter_exprs <- filter_returns[[utils::tail(filters(), 1)]]$filters() + + filter_logical(if (!length(filter_exprs)) rep(TRUE,nrow(datar())) else Reduce("&", Map(function(x) with(datar(), eval(x)), filter_exprs))) + + Reduce( + function(l,r) bquote(.(l) %>% filter(.(r))), + filter_exprs, + init = data_call) + }) + + bindEvent( + reactive({ + filter_log("recalculating filtered data", verbose = verbose) + structure( + d <- subset(datar(), filter_logical()) %||% data.frame(), + code = code(), + class = c("shinyDataFilter_df", class(d))) + }), + code()) + }) +} \ No newline at end of file diff --git a/R/IDEAFilter_item.R b/R/IDEAFilter_item.R new file mode 100644 index 0000000..d44396a --- /dev/null +++ b/R/IDEAFilter_item.R @@ -0,0 +1,223 @@ +#' A single filter item as part of a IDEA filter module panel +#' +#' This is a wrapper for \code{\link{shiny_data_filter_item_ui}} created to +#' match up with the module server function \code{\link{IDEAFilter_item}}. +#' +#' @param id a module id name +#' +#' @return a shiny \code{\link[shiny]{wellPanel}} to house the filter +#' +#' @importFrom shiny NS uiOutput +#' @export +#' @keywords internal +#' +IDEAFilter_item_ui <- function(id) { + ns <- shiny::NS(id) + shiny::uiOutput(ns("ui"), + class = "list-group-item well", + style = "padding: 6px 14px 0px 14px; margin-bottom: 6px;", + `data-id` = id) +} + +#' The server function for the IDEA filter item module +#' +#' Serves as a wrapper for \code{\link{shiny_data_filter_item}} and utilizes +#' \code{moduleSever()} for a more modern implementation of the data item +#' filter. +#' +#' @param id a module id name +#' @param data a \code{reactive expression} returning a \code{data.frame} to use +#' as the input to the filter item module +#' @param column_name a value indicating the name of the column to be filtered +#' @param filters a \code{reactive expression} containing the a list of filters +#' passed as \code{language} types +#' @param ... placeholder for inclusion of additional parameters in future development +#' @param col_subset a \code{vector} containing the list of allowable columns to filter on +#' @param preselection a \code{list} that can be used to pre-populate the filter +#' @param verbose a \code{logical} value indicating whether or not to print log +#' statements out to the console +#' +#' @return a \code{\link[shiny]{reactiveValues}} list of four reactive elements; +#' (1) the code to filter a vector with the name of the specified data column, +#' (2) a flag indicating when to remove this filter, (3) the append list of +#' combining the `filters` argument with (1), and (4) the column name of the +#' `data` used to create the item. +#' +#' @importFrom shiny reactiveValues wellPanel fillRow selectInput h4 actionLink +#' icon uiOutput div HTML span textOutput eventReactive renderUI tag +#' renderText reactive observeEvent callModule +#' @export +#' @keywords internal +#' +IDEAFilter_item <- function(id, data, column_name = NULL, filters = list(), ..., col_subset = NULL, preselection = NULL, verbose = FALSE) { + filters <- if (is.reactive(filters)) filters else reactiveVal(filters) + moduleServer(id, function(input, output, session) { + ns <- session$ns + + datar <- if (is.reactive(data)) data else reactive(data) + col_subsetr <- if (is.reactive(col_subset)) col_subset else reactive(col_subset) + + filter_na <- reactiveVal(if ("filter_na" %in% names(preselection)) isTRUE(preselection[["filter_na"]]) else FALSE) + + module_return <- shiny::reactiveValues( + pre_filters = filters, + remove = FALSE, + filters = filters, + column_name = column_name) + + filter_logical <- reactive({ + req(datar()) + if (!length(module_return$pre_filters())) rep(TRUE, nrow(datar())) else Reduce("&", Map(function(x) with(datar(), eval(x)), module_return$pre_filters())) + }) + + + filter_log("calling filter item", verbose = verbose) + + # ui to show to select a new filter column + column_select_ui <- reactive(shiny::fillRow( + flex = c(NA, 1, NA), + height = "40px", + shiny::h4(style = 'margin-right: 8px;', + shiny::icon("grip-vertical", class = "sortableJS-handle")), + columnSelectInput( + ns("column_select"), + NULL, + data = datar, + col_subset = col_subsetr, + multiple = TRUE, + width = '100%'), + shiny::h4(style = 'float: right; margin: 8px 0px 0px 8px;', + shiny::actionLink( + ns('remove_filter_btn'), + NULL, + shiny::icon('times-circle'))))) + + # filter column-specific ui + column_filter_ui <- shiny::tagList( + shiny::h4( + shiny::icon("grip-vertical", class = "sortableJS-handle"), + shiny::uiOutput(ns("column_name"), inline = TRUE), + shiny::actionLink( + ns("column_select_edit_btn"), + NULL, + shiny::icon("edit")), + shiny::div(style = "display: inline-block; opacity: 0.3; font-style: italic;", + shiny::HTML(paste0( + shiny::span("("), + shiny::textOutput(ns("nrow"), inline = TRUE), + shiny::uiOutput(ns("filter_na_btn_ui"), inline = TRUE), + shiny::span(")")))), + shiny::actionLink(ns("remove_filter_btn"), NULL, + style = 'float: right;', + shiny::icon("times-circle")), + shiny::actionLink(ns("erase_filter_btn"), NULL, + style = 'float: right; margin-right: 10px;', + shiny::icon("eraser")) + ), + shiny::uiOutput(ns("vector_filter_ui"))) + + ui <- shiny::reactive({ + if (is.null(module_return$column_name)) column_select_ui() + else column_filter_ui + }) + + output$ui <- shiny::renderUI({ + filter_log("updating ui", verbose = verbose) + ui() + }) + + output$filter_na_btn_ui <- shiny::renderUI({ + if (nna() <= 0) return() + shiny::HTML(paste0( + shiny::span(", "), + shiny::actionLink(style = "text-decoration: none;", + ns("filter_na_btn"), + shiny::uiOutput(ns("nna_out"), inline = TRUE)))) + }) + + output$nna_out <- shiny::renderUI({ + shiny::span(class = if (filter_na()) "shinyDataFilterStrikeout" else c(), + shiny::HTML(paste0( + nna(), + shiny::tags$small( + style = "position: relative; bottom: 0.025em; left: 0.1em;", + "NA")))) + }) + + + output$vector_filter_ui <- shiny::renderUI({ + shiny_vector_filter_ui(vec(), ns("vector_filter")) + }) + + output$column_name <- shiny::renderUI({ + module_return$column_name + }) + + output$nrow <- shiny::renderText({ + out_log <- if (isTRUE(code())) filter_logical() else with(datar(), eval(code())) & filter_logical() + sum(out_log, na.rm = TRUE) + }) + + observeEvent(input$filter_na_btn, { + filter_na(!filter_na()) + }) + + x <- shiny::eventReactive(filter_na(), { filter_log("observing filter_na")}) + + nna <- shiny::reactive(sum(is.na(vec()))) + + vec <- shiny::reactive({ + if (is.null(module_return$column_name) || !(module_return$column_name %in% names(datar()))) NULL + else subset(datar(), filter_logical(), module_return$column_name, drop = TRUE) + }) + + shiny::observeEvent(input$column_select, { + module_return$column_name <- input$column_select + }) + + shiny::observeEvent(input$column_select_edit_btn, { + module_return$column_name <- NULL + preselection <<- NULL + remove_shiny_inputs("vector_filter", input, ns = ns) + try(session$userData$eraser_observer$destroy(), silent = TRUE) + }) + + shiny::observeEvent(input$remove_filter_btn, { + module_return$remove <- TRUE + remove_shiny_inputs("vector_filter", input, ns = ns) + try(session$userData$eraser_observer$destroy(), silent = TRUE) + }) + + observeEvent(input$erase_filter_btn, { + filter_na(FALSE) + }) + + vector_module_srv <- shiny::reactive(shiny_vector_filter(vec(), "vec")) + + vector_module_return <- shiny::reactive({ + shiny::callModule( + vector_module_srv(), + "vector_filter", + x = vec, + filter_na = filter_na, + filter_fn = preselection[["filter_fn"]], + erase_filters = reactive(input$erase_filter_btn), + verbose = verbose) + }) + + code <- shiny::reactive({ + if (is.null(module_return$column_name)) return(TRUE) + + do.call(substitute, list( + vector_module_return()$code(), + list(.x = as.name(module_return$column_name)))) + }) + + module_return$filters <- shiny::reactive({ + Filter(Negate(isTRUE), + append(module_return$pre_filters(), code())) + }) + + module_return + }) +} diff --git a/R/selectInput_column.R b/R/selectInput_column.R index 251ae5b..d7f5ada 100644 --- a/R/selectInput_column.R +++ b/R/selectInput_column.R @@ -5,6 +5,7 @@ #' @param data \code{data.frame} object from which fields should be populated #' @param selected default selection #' @param ... passed to \code{\link[shiny]{selectizeInput}} +#' @param col_subset a \code{vector} containing the list of allowable columns to select #' @param placeholder passed to \code{\link[shiny]{selectizeInput}} options #' @param onInitialize passed to \code{\link[shiny]{selectizeInput}} options #' @@ -14,9 +15,10 @@ #' @keywords internal #' columnSelectInput <- function(inputId, label, data, selected = "", ..., - placeholder = "", onInitialize) { + col_subset = NULL, placeholder = "", onInitialize) { datar <- if (is.reactive(data)) data else reactive(data) + col_subsetr <- if (is.reactive(col_subset)) col_subset else reactive(col_subset) labels <- Map(function(col) { json <- sprintf(strip_leading_ws(' @@ -30,6 +32,7 @@ columnSelectInput <- function(inputId, label, data, selected = "", ..., get_dataFilter_class(datar()[[col]])) }, col = names(datar())) choices <- setNames(names(datar()), labels) + choices <- choices[match(if (length(col_subsetr()) == 0 || isTRUE(col_subsetr() == "")) choices else col_subsetr(), choices)] shiny::selectizeInput( inputId = inputId, @@ -42,7 +45,7 @@ columnSelectInput <- function(inputId, label, data, selected = "", ..., // format the way that options are rendered option: function(item, escape) { item.data = JSON.parse(item.label); - return '
' + + return '
' + '
' + escape(item.data.name) + ' ' + ' ' + @@ -54,7 +57,7 @@ columnSelectInput <- function(inputId, label, data, selected = "", ..., }, // avoid data vomit splashing on screen when an option is selected - item: function(item, escape) { return ''; } + item: function(item, escape) { return ''; } }")), # fix for highlight persisting diff --git a/R/selectInput_proportion.R b/R/selectInput_proportion.R index f0162cf..ee0d8fa 100644 --- a/R/selectInput_proportion.R +++ b/R/selectInput_proportion.R @@ -53,7 +53,7 @@ proportionSelectInput <- function(inputId, label, vec, selected = "", ..., // format the way that options are rendered option: function(item, escape) { item.data = JSON.parse(item.label); - return '
' + + return '
' + '
' + '
' + escape(item.data.name) + ' ' + diff --git a/R/shiny_data_filter.R b/R/shiny_data_filter.R index 3bc65fe..5ee1b1c 100644 --- a/R/shiny_data_filter.R +++ b/R/shiny_data_filter.R @@ -13,6 +13,7 @@ #' @inherit shiny_data_filter examples #' shiny_data_filter_ui <- function(inputId) { + .Deprecated("IDEAFilter_ui") ns <- shiny::NS(inputId) shinyDataFilter_resourcePath() @@ -118,6 +119,7 @@ shiny_data_filter_ui <- function(inputId) { #' } #' shiny_data_filter <- function(input, output, session, data, verbose = FALSE) { + .Deprecated("IDEAFilter") ns <- session$ns filter_log("calling module", verbose = verbose) @@ -153,12 +155,17 @@ shiny_data_filter <- function(input, output, session, data, verbose = FALSE) { filter_returns[[fid]]$destroy } - filter_returns[[fid]] <<- callModule( - shiny_data_filter_item, - fid, - data = filter_returns[[in_fid]]$data, - column_name = column_name, - verbose = verbose) + filter_returns[[fid]] <<- withCallingHandlers(callModule( + shiny_data_filter_item, + fid, + data = filter_returns[[in_fid]]$data, + column_name = column_name, + verbose = verbose), + warning = function(w) { + if (inherits(w, "deprecatedWarning") && grepl("IDEAFilter_item", conditionMessage(w))) + invokeRestart("muffleWarning") + } + ) } output$add_filter_select_ui <- renderUI({ @@ -195,7 +202,14 @@ shiny_data_filter <- function(input, output, session, data, verbose = FALSE) { insertUI( selector = sprintf("#%s", ns("sortableList")), where = "beforeEnd", - ui = shiny_data_filter_item_ui(ns(fid), verbose = verbose)) + ui = withCallingHandlers( + shiny_data_filter_item_ui(ns(fid), verbose = verbose), + warning = function(w) { + if (inherits(w, "deprecatedWarning") && grepl("IDEAFilter_item", conditionMessage(w))) + invokeRestart("muffleWarning") + } + ) + ) }) observeEvent(input$add_filter_select, { @@ -208,7 +222,14 @@ shiny_data_filter <- function(input, output, session, data, verbose = FALSE) { insertUI( selector = sprintf("#%s", ns("sortableList")), where = "beforeEnd", - ui = shiny_data_filter_item_ui(ns(fid), verbose = verbose)) + ui = withCallingHandlers( + shiny_data_filter_item_ui(ns(fid), verbose = verbose), + warning = function(w) { + if (inherits(w, "deprecatedWarning") && grepl("IDEAFilter_item", conditionMessage(w))) + invokeRestart("muffleWarning") + } + ) + ) updateSelectInput(session, "add_filter_select", selected = "") }, ignoreInit = TRUE, ignoreNULL = TRUE) @@ -247,8 +268,8 @@ shiny_data_filter <- function(input, output, session, data, verbose = FALSE) { reactive({ filter_log("recalculating filtered data", verbose = verbose) structure( - d <- filter_returns[[utils::tail(filters(), 1)]]$data(), + d <- filter_returns[[utils::tail(filters(), 1)]]$data() %||% data.frame(), code = code(), class = c("shinyDataFilter_df", class(d))) }) -} \ No newline at end of file +} diff --git a/R/shiny_data_filter_item.R b/R/shiny_data_filter_item.R index 329e2ed..41a8f66 100644 --- a/R/shiny_data_filter_item.R +++ b/R/shiny_data_filter_item.R @@ -18,6 +18,7 @@ #' @keywords internal #' shiny_data_filter_item_ui <- function(inputId, verbose = FALSE) { + .Deprecated("IDEAFilter_item_ui") ns <- shiny::NS(inputId) shiny::uiOutput(ns("ui"), class = "list-group-item well", @@ -54,6 +55,7 @@ shiny_data_filter_item_ui <- function(inputId, verbose = FALSE) { #' shiny_data_filter_item <- function(input, output, session, data, column_name = NULL, verbose = FALSE) { + .Deprecated("IDEAFilter_item") ns <- session$ns @@ -163,10 +165,14 @@ shiny_data_filter_item <- function(input, output, session, data, shiny::observeEvent(input$column_select_edit_btn, { module_return$column_name <- NULL + remove_shiny_inputs("vector_filter", input, ns = ns) + try(session$userData$eraser_observer$destroy(), silent = TRUE) }) shiny::observeEvent(input$remove_filter_btn, { module_return$remove <- TRUE + remove_shiny_inputs("vector_filter", input, ns = ns) + try(session$userData$eraser_observer$destroy(), silent = TRUE) }) vector_module_srv <- shiny::reactive(shiny_vector_filter(vec(), "vec")) @@ -202,4 +208,4 @@ shiny_data_filter_item <- function(input, output, session, data, }) module_return -} \ No newline at end of file +} diff --git a/R/shiny_vector_filter.R b/R/shiny_vector_filter.R index f6d1307..6e57ed7 100644 --- a/R/shiny_vector_filter.R +++ b/R/shiny_vector_filter.R @@ -106,7 +106,8 @@ shiny_vector_filter <- function(data, inputId, global = FALSE) { #' @keywords internal shiny_vector_filter.default <- function(data, inputId, ...) { function(input, output, session, x = shiny::reactive(NULL), - filter_na = shiny::reactive(FALSE), verbose = FALSE) { + filter_na = shiny::reactive(FALSE), filter_fn = NULL, verbose = FALSE, + erase_filters = shiny::reactive(0)) { module_return <- shiny::reactiveValues(code = FALSE, mask = FALSE) module_return$code <- shiny::reactive(FALSE) @@ -125,7 +126,7 @@ shiny_vector_filter.default <- function(data, inputId, ...) { #' #' @return a pillar formatted class name #' -#' @importFrom pillar new_pillar_type +#' @importFrom pillar type_sum #' @keywords internal #' get_dataFilter_class <- function(obj) { @@ -139,5 +140,6 @@ get_dataFilter_class <- function(obj) { if (!length(vf_class)) return("unk") class(obj) <- vf_class - pillar::new_pillar_type(obj)[[1]][1] -} \ No newline at end of file + type <- pillar::type_sum(obj) + if (length(type) == 0L) "" else type +} diff --git a/R/shiny_vector_filter_NULL.R b/R/shiny_vector_filter_NULL.R index 10ea625..2eeb202 100644 --- a/R/shiny_vector_filter_NULL.R +++ b/R/shiny_vector_filter_NULL.R @@ -11,7 +11,8 @@ shiny_vector_filter_ui.NULL = function(data, inputId) { #' @keywords internal shiny_vector_filter.NULL <- function(data, inputId, ...) { function(input, output, session, x = shiny::reactive(NULL), - filter_na = shiny::reactive(FALSE), verbose = FALSE) { + filter_na = shiny::reactive(FALSE), filter_fn = NULL, verbose = FALSE, + erase_filters = shiny::reactive(0)) { module_return <- shiny::reactiveValues(code = TRUE, mask = TRUE) module_return$code <- shiny::reactive(TRUE) @@ -19,4 +20,4 @@ shiny_vector_filter.NULL <- function(data, inputId, ...) { module_return } -} \ No newline at end of file +} diff --git a/R/shiny_vector_filter_character.R b/R/shiny_vector_filter_character.R index 28447be..998a6c0 100644 --- a/R/shiny_vector_filter_character.R +++ b/R/shiny_vector_filter_character.R @@ -11,7 +11,8 @@ shiny_vector_filter_ui.character <- function(data, inputId) { #' @keywords internal shiny_vector_filter.character <- function(data, inputId, ...) { function(input, output, session, x = shiny::reactive(character()), - filter_na = shiny::reactive(FALSE), verbose = FALSE) { + filter_na = shiny::reactive(FALSE), filter_fn = NULL, verbose = FALSE, + erase_filters = shiny::reactive(0)) { ns <- session$ns @@ -19,12 +20,15 @@ shiny_vector_filter.character <- function(data, inputId, ...) { x_wo_NAs <- shiny::reactive(Filter(Negate(is.na), x())) module_return <- shiny::reactiveValues(code = TRUE, mask = TRUE) + fn <- if (is.null(filter_fn)) function(x) FALSE else purrr::possibly(filter_fn, otherwise = FALSE) + + x_filtered <- Filter(function(x) !is.na(x) & fn(x), x()) output$ui <- shiny::renderUI({ filter_log("updating ui", verbose = verbose) - if (purrr::reduce(purrr::map(x(), is.empty), `&`)) { + if (purrr::reduce(purrr::map(x(), is.empty), `&`, .init = TRUE)) { shiny::div(style = "opacity: 0.5;", p(width = "100%", align = "center", @@ -32,12 +36,18 @@ shiny_vector_filter.character <- function(data, inputId, ...) { } else { proportionSelectInput(ns("param"), NULL, vec = x, - selected = shiny::isolate(input$param) %||% c(), + selected = isolate(input$param) %||% x_filtered, multiple = TRUE, width = "100%") } }) + session$userData$eraser_observer <- + observeEvent( + erase_filters(), + updateSelectizeInput(session, "param", selected = ""), + ignoreInit = TRUE + ) module_return$code <- shiny::reactive({ if (length(input$param)) @@ -53,4 +63,4 @@ shiny_vector_filter.character <- function(data, inputId, ...) { }) module_return } -} \ No newline at end of file +} diff --git a/R/shiny_vector_filter_date.R b/R/shiny_vector_filter_date.R index a9d1396..d4e7704 100644 --- a/R/shiny_vector_filter_date.R +++ b/R/shiny_vector_filter_date.R @@ -12,10 +12,14 @@ shiny_vector_filter_ui.Date <- function(data, inputId) { #' @keywords internal shiny_vector_filter.Date <- function(data, inputId, ...) { function(input, output, session, x = shiny::reactive(Date()), - filter_na = shiny::reactive(FALSE), verbose = FALSE) { + filter_na = shiny::reactive(FALSE), filter_fn = NULL, verbose = FALSE, + erase_filters = shiny::reactive(0)) { ns <- session$ns module_return <- shiny::reactiveValues(code = TRUE, mask = TRUE) + fn <- if (is.null(filter_fn)) function(x) TRUE else purrr::possibly(filter_fn, otherwise = TRUE) + + x_filtered <- Filter(function(x) !is.na(x) & fn(x), x()) output$ui <- shiny::renderUI({ filter_log("updating ui", verbose = verbose) @@ -28,10 +32,11 @@ shiny_vector_filter.Date <- function(data, inputId, ...) { 0.5s ease-in 0s 1 shinyDataFilterFadeIn; transform-origin: bottom;"), if (any(!is.na(x()))) { + my_min_date <- if (is.null(isolate(input$param))) NULL else max(isolate(input$param[[1]]), min(x(), na.rm = TRUE)) + my_max_date <- if (is.null(isolate(input$param))) NULL else min(isolate(input$param[[2]]), max(x(), na.rm = TRUE)) shiny::dateRangeInput(ns("param"), NULL, - #value = shiny::isolate(input$param) %||% range(x(), na.rm = TRUE), - start = min(x(), na.rm = TRUE), - end = max(x(), na.rm = TRUE), + start = my_min_date %||% min(x_filtered), + end = my_max_date %||% max(x_filtered), min = min(x(), na.rm = TRUE), max = max(x(), na.rm = TRUE) ) @@ -41,6 +46,12 @@ shiny_vector_filter.Date <- function(data, inputId, ...) { shiny::tags$h5(shiny::tags$i("no numeric values"))) }) }) + session$userData$eraser_observer <- + observeEvent( + erase_filters(), + updateDateRangeInput(session, "param", start = min(x(), na.rm = TRUE), end = max(x(), na.rm = TRUE)), + ignoreInit = TRUE + ) module_return$code <- shiny::reactive({ exprs <- list() @@ -73,4 +84,4 @@ shiny_vector_filter.Date <- function(data, inputId, ...) { module_return } -} \ No newline at end of file +} diff --git a/R/shiny_vector_filter_datetime.R b/R/shiny_vector_filter_datetime.R index d16d388..29f7b9f 100644 --- a/R/shiny_vector_filter_datetime.R +++ b/R/shiny_vector_filter_datetime.R @@ -1,4 +1,4 @@ -#' @importFrom shinyTime timeInput +#' @importFrom shinyTime timeInput updateTimeInput #' @importFrom shiny NS uiOutput #' @export #' @keywords internal @@ -12,15 +12,17 @@ shiny_vector_filter_ui.POSIXct <- function(data, inputId) { #' @keywords internal shiny_vector_filter.POSIXct <- function(data, inputId, ...) { function(input, output, session, x = shiny::reactive(), - filter_na = shiny::reactive(FALSE), verbose = FALSE) { + filter_na = shiny::reactive(FALSE), filter_fn = NULL, verbose = FALSE, + erase_filters = shiny::reactive(0)) { ns <- session$ns module_return <- shiny::reactiveValues(code = TRUE, mask = TRUE) + fn <- if (is.null(filter_fn)) function(x) TRUE else purrr::possibly(filter_fn, otherwise = TRUE) - p <- reactive({ - as.POSIXct(x(), origin = "1970-01-01 00:00:00", tz = "GMT") - }) + x_filtered <- Filter(function(x) !is.na(x) & fn(x), x()) + tzone <- reactive(attr(x(), "tzone") %||% "") + output$ui <- shiny::renderUI({ filter_log("updating ui", verbose = verbose) shiny::div( @@ -32,18 +34,22 @@ shiny_vector_filter.POSIXct <- function(data, inputId, ...) { 0.5s ease-in 0s 1 shinyDataFilterFadeIn; transform-origin: bottom;"), if (any(!is.na(x()))) { - my_date <- as.Date(p()) + my_date <- as.Date(x()) + my_min_date <- if (is.null(isolate(input$st_date))) NULL else max(isolate(input$st_date), min(my_date, na.rm = TRUE)) + my_min_time <- if (is.null(isolate(input$st_time))) NULL else max(isolate(st_dt()), min(x(), na.rm = TRUE)) + my_max_date <- if (is.null(isolate(input$end_date))) NULL else min(isolate(input$end_date), max(my_date, na.rm = TRUE)) + my_max_time <- if (is.null(isolate(input$end_time))) NULL else min(isolate(end_dt()), max(x(), na.rm = TRUE)) div( div(style = "display: inline-block; vertical-align:middle;", - shiny::dateInput(ns("st_date"), "Start Date",value = min(my_date, na.rm = TRUE) + shiny::dateInput(ns("st_date"), "Start Date", value = my_min_date %||% min(as.Date(x_filtered)) , min = min(my_date, na.rm = TRUE), max = max(my_date, na.rm = TRUE)), - shinyTime::timeInput(ns("st_time"), "Start Time (HH:MM:SS)", value = min(p(), na.rm = TRUE))# automatically takes the time element + shinyTime::timeInput(ns("st_time"), "Start Time (HH:MM:SS)", value = my_min_time %||% min(x_filtered))# automatically takes the time element ), div(style = "display: inline-block; vertical-align:middle;", - shiny::dateInput(ns("end_date"), "End Date",value = max(my_date, na.rm = TRUE) + shiny::dateInput(ns("end_date"), "End Date", value = my_max_date %||% max(as.Date(x_filtered)) , min = min(my_date, na.rm = TRUE), max = max(my_date, na.rm = TRUE)), - shinyTime::timeInput(ns("end_time"), "End Time (HH:MM:SS)", value = max(p(), na.rm = TRUE)) # automatically takes the time element + shinyTime::timeInput(ns("end_time"), "End Time (HH:MM:SS)", value = my_max_time %||% max(x_filtered)) # automatically takes the time element ) ) } else { @@ -53,22 +59,31 @@ shiny_vector_filter.POSIXct <- function(data, inputId, ...) { }) }) + session$userData$eraser_observer <- + observeEvent(erase_filters(), { + my_date <- as.Date(x()) + updateDateInput(session, "st_date", value = min(my_date, na.rm = TRUE)) + shinyTime::updateTimeInput(session, "st_time", value = min(x(), na.rm = TRUE)) + updateDateInput(session, "end_date", value = max(my_date, na.rm = TRUE)) + shinyTime::updateTimeInput(session, "end_time", value = max(x(), na.rm = TRUE)) + }, ignoreInit = TRUE) + st_dt <- reactive({ - st <- substr(strftime(input$st_time, "%Y-%m-%d %H:%M:%S", tz = "GMT"),12,20) - as.POSIXct(paste(input$st_date, st), tz = "GMT") + st <- substr(strftime(input$st_time, "%Y-%m-%d %H:%M:%S", tz = tzone()),12,20) + as.POSIXct(paste(input$st_date, st), tz = tzone()) }) end_dt <- reactive({ - end <- substr(strftime(input$end_time, "%Y-%m-%d %H:%M:%S", tz = "GMT"),12,20) - as.POSIXct(paste(input$end_date, end), tz = "GMT") + end <- substr(strftime(input$end_time, "%Y-%m-%d %H:%M:%S", tz = tzone()),12,20) + as.POSIXct(paste(input$end_date, end), tz = tzone()) }) module_return$code <- shiny::reactive({ exprs <- list() - + if (!is.null(input$st_date) & !is.null(input$st_time) & !is.null(input$end_date) & !is.null(input$end_time)) { - if (st_dt() > min(p(), na.rm = TRUE)) + if (st_dt() > min(x(), na.rm = TRUE)) exprs <- append(exprs, bquote(.x >= .(st_dt()))) - if (end_dt() < max(p(), na.rm = TRUE)) + if (end_dt() < max(x(), na.rm = TRUE)) exprs <- append(exprs, bquote(.x <= .(end_dt()))) } @@ -93,4 +108,4 @@ shiny_vector_filter.POSIXct <- function(data, inputId, ...) { module_return } -} \ No newline at end of file +} diff --git a/R/shiny_vector_filter_factor_few.R b/R/shiny_vector_filter_factor_few.R index 5667353..db8c781 100644 --- a/R/shiny_vector_filter_factor_few.R +++ b/R/shiny_vector_filter_factor_few.R @@ -9,6 +9,10 @@ #' @param x a reactive expression resolving to the vector to filter #' @param filter_na a logical value indicating whether to filter \code{NA} #' values from the \code{x} vector +#' @param filter_fn A function to modify, specified in one of the following ways: +#' * A named function, e.g. `mean`. +#' * An anonymous function, e.g. `\(x) x + 1` or `function(x) x + 1`. +#' * A formula, e.g. `~ .x + 1`. #' @param verbose a \code{logical} value indicating whether or not to print log #' statements out to the console #' @@ -23,13 +27,17 @@ #' @importFrom grDevices rgb #' @keywords internal shiny_vector_filter_factor_few <- function(input, output, session, - x = shiny::reactive(factor()), filter_na = shiny::reactive(TRUE), - verbose = FALSE) { + x = shiny::reactive(factor()), filter_na = shiny::reactive(TRUE), filter_fn = NULL, + verbose = FALSE, + erase_filters = shiny::reactive(0)) { ns <- session$ns x_wo_NA <- shiny::reactive(Filter(Negate(is.na), x())) module_return <- shiny::reactiveValues(code = TRUE, mask = TRUE) + fn <- if (is.null(filter_fn)) function(x) FALSE else purrr::possibly(filter_fn, otherwise = FALSE) + + x_filtered <- Filter(function(x) !is.na(x) & fn(x), x()) choices <- shiny::reactive(unique(as.character(x_wo_NA()))) @@ -46,25 +54,15 @@ shiny_vector_filter_factor_few <- function(input, output, session, ), shiny::checkboxGroupInput(ns("param"), NULL, choices = choices(), - selected = shiny::isolate(input$param) %||% c(), + selected = isolate(input$param) %||% x_filtered, width = "100%")) }) - - # Normalized - # ggplot2::ggplot() + - # # sort factor so that it reflects checkbox order - # ggplot2::aes(x = factor( - # as.character(x_wo_NA()), - # levels = rev(choices()))) + - # ggplot2::geom_bar( - # width = 0.95, - # fill = grDevices::rgb(66/255, 139/255, 202/255), - # color = NA, - # alpha = 0.2) + - # ggplot2::coord_flip() + - # ggplot2::theme_void() + - # ggplot2::scale_x_discrete(expand = c(0, 0)) + - # ggplot2::scale_y_continuous(expand = c(0, 0)) + session$userData$eraser_observer <- + observeEvent( + erase_filters(), + updateCheckboxGroupInput(session, "param", selected = ""), + ignoreInit = TRUE + ) module_return$code <- shiny::reactive({ if (length(input$param)) @@ -80,4 +78,4 @@ shiny_vector_filter_factor_few <- function(input, output, session, }) module_return -} \ No newline at end of file +} diff --git a/R/shiny_vector_filter_factor_many.R b/R/shiny_vector_filter_factor_many.R index 9e47bca..37a2694 100644 --- a/R/shiny_vector_filter_factor_many.R +++ b/R/shiny_vector_filter_factor_many.R @@ -9,6 +9,10 @@ #' @param x a reactive expression resolving to the vector to filter #' @param filter_na a logical value indicating whether to filter \code{NA} #' values from the \code{x} vector +#' @param filter_fn A function to modify, specified in one of the following ways: +#' * A named function, e.g. `mean`. +#' * An anonymous function, e.g. `\(x) x + 1` or `function(x) x + 1`. +#' * A formula, e.g. `~ .x + 1`. #' @param verbose a \code{logical} value indicating whether or not to print log #' statements out to the console #' @@ -19,22 +23,31 @@ #' @importFrom shiny reactive reactiveValues renderUI selectInput isolate #' @keywords internal shiny_vector_filter_factor_many <- function(input, output, session, - x = shiny::reactive(factor()), filter_na = shiny::reactive(FALSE), - verbose = FALSE) { + x = shiny::reactive(factor()), filter_na = shiny::reactive(FALSE), filter_fn = NULL, + verbose = FALSE, + erase_filters = shiny::reactive(0)) { ns <- session$ns x_wo_NAs <- shiny::reactive(Filter(Negate(is.na), x())) module_return <- shiny::reactiveValues(code = TRUE, mask = TRUE) + fn <- if (is.null(filter_fn)) function(x) FALSE else purrr::possibly(filter_fn, otherwise = FALSE) + + x_filtered <- Filter(function(x) !is.na(x) & fn(x), x()) output$ui <- shiny::renderUI({ filter_log("updating ui", verbose = verbose) proportionSelectInput(ns("param"), NULL, vec = x, - selected = shiny::isolate(input$param) %||% c(), + selected = isolate(input$param) %||% x_filtered, multiple = TRUE, width = "100%") }) + session$userData$eraser_observer <- + observeEvent( + erase_filters(), updateSelectizeInput(session, "param", selected = ""), + ignoreInit = TRUE + ) module_return$code <- shiny::reactive({ if (length(input$param)) @@ -50,4 +63,4 @@ shiny_vector_filter_factor_many <- function(input, output, session, }) module_return -} \ No newline at end of file +} diff --git a/R/shiny_vector_filter_logical.R b/R/shiny_vector_filter_logical.R index 61005d9..31ddb3b 100644 --- a/R/shiny_vector_filter_logical.R +++ b/R/shiny_vector_filter_logical.R @@ -12,13 +12,18 @@ shiny_vector_filter_ui.logical <- function(data, inputId) { #' @keywords internal shiny_vector_filter.logical <- function(data, inputId, ...) { function(input, output, session, - x = shiny::reactive(logical()), filter_na = shiny::reactive(TRUE), - verbose = FALSE) { + x = shiny::reactive(logical()), filter_na = shiny::reactive(TRUE), filter_fn = NULL, + verbose = FALSE, + erase_filters = shiny::reactive(0)) { ns <- session$ns - x_wo_NA <- shiny::reactive(Filter(Negate(is.na), x())) module_return <- shiny::reactiveValues(code = TRUE, mask = TRUE) + fn <- if (is.null(filter_fn)) function(x) FALSE else purrr::possibly(filter_fn, otherwise = FALSE) + + x_filtered <- Filter(function(x) !is.na(x) & fn(x), x()) + filter_selected <- Filter(function(i) i %in% x_filtered, c("True" = TRUE, "False" = FALSE)) + choices <- shiny::reactive({ Filter(function(i) i %in% x(), c("True" = TRUE, "False" = FALSE)) }) @@ -36,9 +41,15 @@ shiny_vector_filter.logical <- function(data, inputId, ...) { shiny::plotOutput(ns("plot"), height = "100%")), shiny::checkboxGroupInput(ns("param"), NULL, choices = choices(), - selected = shiny::isolate(input$param) %||% c(), + selected = isolate(input$param) %||% filter_selected, width = "100%")) }) + session$userData$eraser_observer <- + observeEvent( + erase_filters(), + updateCheckboxGroupInput(session, "param", selected = ""), + ignoreInit = TRUE + ) module_return$code <- shiny::reactive({ exprs <- list() @@ -48,7 +59,7 @@ shiny_vector_filter.logical <- function(data, inputId, ...) { if (FALSE %in% input$param) exprs <- append(exprs, list(quote(!.x))) - if (length(input$param) == 2 && filter_na()) + if (length(input$param) %% 2 == 0 && filter_na()) exprs <- list(quote(!is.na(.x))) else if (length(input$param) && !filter_na()) exprs <- append(exprs, list(quote(is.na(.x)))) @@ -66,4 +77,4 @@ shiny_vector_filter.logical <- function(data, inputId, ...) { module_return } -} \ No newline at end of file +} diff --git a/R/shiny_vector_filter_numeric_few.R b/R/shiny_vector_filter_numeric_few.R index b3c790c..da730c9 100644 --- a/R/shiny_vector_filter_numeric_few.R +++ b/R/shiny_vector_filter_numeric_few.R @@ -8,6 +8,10 @@ #' session #' @param x The TODO #' @param filter_na The \code{logical} TODO +#' @param filter_fn A function to modify, specified in one of the following ways: +#' * A named function, e.g. `mean`. +#' * An anonymous function, e.g. `\(x) x + 1` or `function(x) x + 1`. +#' * A formula, e.g. `~ .x + 1`. #' @param verbose a \code{logical} value indicating whether or not to print log #' statements out to the console #' @@ -25,12 +29,16 @@ #' @keywords internal shiny_vector_filter_numeric_few <- function(input, output, session, x = shiny::reactive(factor()), #important: changed x to factor here - filter_na = shiny::reactive(FALSE), verbose = FALSE) { + filter_na = shiny::reactive(FALSE), filter_fn = NULL, verbose = FALSE, + erase_filters = shiny::reactive(0)) { ns <- session$ns x_wo_NA <- shiny::reactive(Filter(Negate(is.na), x())) module_return <- shiny::reactiveValues(code = TRUE, mask = TRUE) + fn <- if (is.null(filter_fn)) function(x) FALSE else purrr::possibly(filter_fn, otherwise = FALSE) + + x_filtered <- unique(as.character(Filter(function(x) !is.na(x) & fn(x), x()))) choices <- shiny::reactive(unique(as.character(sort(x_wo_NA())))) @@ -45,31 +53,21 @@ shiny_vector_filter_numeric_few <- function(input, output, session, 0.5s ease-in 0s 1 shinyDataFilterFadeIn; transform-origin: left;" #, ), - shiny::checkboxGroupInput(ns("param"), NULL, + shiny::checkboxGroupInput(ns("param_few"), NULL, choices = choices(), - selected = shiny::isolate(input$param) %||% c(), + selected = isolate(input$param_few) %||% x_filtered, width = "100%")) }) - - # Normalized - # ggplot2::ggplot() + - # # sort factor so that it reflects checkbox order - # ggplot2::aes(x = factor( - # as.character(x_wo_NA()), - # levels = rev(choices()))) + - # ggplot2::geom_bar( - # width = 0.95, - # fill = grDevices::rgb(66/255, 139/255, 202/255), - # color = NA, - # alpha = 0.2) + - # ggplot2::coord_flip() + - # ggplot2::theme_void() + - # ggplot2::scale_x_discrete(expand = c(0, 0)) + - # ggplot2::scale_y_continuous(expand = c(0, 0)) + session$userData$eraser_observer <- + observeEvent( + erase_filters(), + updateCheckboxGroupInput(session, "param_few", selected = ""), + ignoreInit = TRUE + ) module_return$code <- shiny::reactive({ - if (length(input$param)) - bquote(.x %in% .(c(if (filter_na()) c() else NA, input$param))) + if (length(input$param_few)) + bquote(.x %in% .(c(if (filter_na()) c() else NA, input$param_few))) else if (filter_na()) bquote(!is.na(.x)) else @@ -81,4 +79,4 @@ shiny_vector_filter_numeric_few <- function(input, output, session, }) module_return -} \ No newline at end of file +} diff --git a/R/shiny_vector_filter_numeric_many.R b/R/shiny_vector_filter_numeric_many.R index fc180a5..526da85 100644 --- a/R/shiny_vector_filter_numeric_many.R +++ b/R/shiny_vector_filter_numeric_many.R @@ -8,6 +8,10 @@ #' session #' @param x The TODO #' @param filter_na The \code{logical} TODO +#' @param filter_fn A function to modify, specified in one of the following ways: +#' * A named function, e.g. `mean`. +#' * An anonymous function, e.g. `\(x) x + 1` or `function(x) x + 1`. +#' * A formula, e.g. `~ .x + 1`. #' @param verbose a \code{logical} value indicating whether or not to print log #' statements out to the console #' @@ -17,6 +21,7 @@ #' scale_y_continuous #' @importFrom grDevices rgb #' @importFrom stats density +#' @importFrom purrr possibly #' #' @return a \code{\link[shiny]{reactiveValues}} list containing a logical #' vector called "mask" which can be used to filter the provided vector and an @@ -24,11 +29,14 @@ #' @export #' @keywords internal shiny_vector_filter_numeric_many <- function(input, output, session, x = shiny::reactive(numeric()), - filter_na = shiny::reactive(FALSE), verbose = FALSE) { + filter_na = shiny::reactive(FALSE), filter_fn = NULL, verbose = FALSE, + erase_filters = shiny::reactive(0)) { ns <- session$ns module_return <- shiny::reactiveValues(code = TRUE, mask = TRUE) + fn <- if (is.null(filter_fn)) function(x) TRUE else purrr::possibly(filter_fn, otherwise = TRUE) + x_filtered <- Filter(function(x) !is.na(x) & fn(x), x()) output$ui <- shiny::renderUI({ filter_log("updating ui", verbose = verbose) shiny::div( @@ -40,25 +48,36 @@ shiny_vector_filter_numeric_many <- function(input, output, session, x = shiny:: 0.5s ease-in 0s 1 shinyDataFilterFadeIn; transform-origin: bottom;"), if (any(!is.na(x()))) { - shiny::sliderInput(ns("param"), NULL, - value = shiny::isolate(input$param) %||% range(x(), na.rm = TRUE), - min = min(round(x(), 1), na.rm = TRUE), - max = max(round(x(), 1), na.rm = TRUE)) + value_range <- range(isolate(input$param_many) %||% x_filtered) + overall_range <- range(x(), na.rm = TRUE) + value_range[1] <- min(max(value_range[1], overall_range[1]), overall_range[2]) + value_range[2] <- max(min(value_range[2], overall_range[2]), overall_range[1]) + shiny::sliderInput(ns("param_many"), NULL, + value = value_range, + min = overall_range[1], + max = overall_range[2]) } else { shiny::div( style = "padding-top: 10px; opacity: 0.3; text-align: center;", shiny::tags$h5(shiny::tags$i("no numeric values"))) }) }) + session$userData$eraser_observer <- + observeEvent( + erase_filters(), + updateSliderInput(session, "param_many", value = range(x(), na.rm = TRUE)), + ignoreInit = TRUE + ) module_return$code <- shiny::reactive({ exprs <- list() + last_n <- length(input$param_many) - if (!is.null(input$param)) { - if (input$param[[1]] > min(x(), na.rm = TRUE)) - exprs <- append(exprs, bquote(.x >= .(as.numeric(input$param[[1]])))) - if (input$param[[2]] < max(x(), na.rm = TRUE)) - exprs <- append(exprs, bquote(.x <= .(as.numeric(input$param[[2]])))) + if (!is.null(input$param_many)) { + if (input$param_many[[1]] > min(x(), na.rm = TRUE)) + exprs <- append(exprs, bquote(.x >= .(as.numeric(input$param_many[[1]])))) + if (input$param_many[[last_n]] < max(x(), na.rm = TRUE)) + exprs <- append(exprs, bquote(.x <= .(as.numeric(input$param_many[[last_n]])))) } if (length(exprs) > 1) { @@ -81,4 +100,4 @@ shiny_vector_filter_numeric_many <- function(input, output, session, x = shiny:: }) module_return -} \ No newline at end of file +} diff --git a/R/sysdata.rda b/R/sysdata.rda new file mode 100644 index 0000000..150b810 Binary files /dev/null and b/R/sysdata.rda differ diff --git a/R/utils.R b/R/utils.R index 9bdeded..04a2c28 100644 --- a/R/utils.R +++ b/R/utils.R @@ -150,3 +150,12 @@ strip_leading_ws <- function(txt, simplify = TRUE) { is.empty <- function(x) { identical("", x) } + +remove_shiny_inputs <- function(id, .input, ns = NS(NULL)) { + invisible( + lapply(grep(id, names(.input), value = TRUE), function(i) { + .subset2(.input, "impl")$.values$remove(ns(i)) + }) + ) +} + diff --git a/README.Rmd b/README.Rmd index 7c24c26..34aeb65 100644 --- a/README.Rmd +++ b/README.Rmd @@ -7,7 +7,7 @@ output: "github_document" Agnostic, Idiomatic Data Filter Module for Shiny.
- + Demo example app that leverages the IDEAFilter shiny module
@@ -45,17 +45,16 @@ devtools::install_github("Biogen-Inc/IDEAFilter") After installation, you now have access to the`IDEAFilter` shiny module. On the UI side, you need only include the following line of code to place the filtering widget somewhere in your app: ```{r, eval=FALSE} -shiny_data_filter_ui(inputId = "data_filter") +IDEAFilter_ui(id = "data_filter") ``` -The server side logic needs to call the `shiny_data_filter` module, match the input ID from the UI, and provide a data source. The returned reactive data.frame (called "filtered_data") may used for downstream processes regardless on if the user chooses to apply filters or not. +The server side logic needs to call the `IDEAFilter` module, match the input ID from the UI, and provide a data source. The returned reactive data.frame (called "filtered_data") may used for downstream processes regardless on if the user chooses to apply filters or not. ```{r, eval=FALSE} filtered_data <- # name the returned reactive data frame - callModule( - shiny_data_filter, # call the module by name + IDEAFilter( "data_filter", # give the filter a name(space) - data = starwars2, # feed it raw data + data = starwars, # feed it raw data verbose = FALSE ) ``` @@ -65,7 +64,7 @@ filtered_data <- # name the returned reactive data frame Copy & paste the code below into a live R session to see the inner workings of the Star Wars app referenced above. Or click the button below to test drive the example app now!
- + Demo example app that leverages the IDEAFilter shiny module
@@ -98,18 +97,13 @@ ui <- fluidPage( dataTableOutput("data_summary"), h4("Generated Code"), verbatimTextOutput("data_filter_code")), - column(4, shiny_data_filter_ui("data_filter")))) + column(4, IDEAFilter_ui("data_filter")))) server <- function(input, output, session) { filtered_data <- # name the returned reactive data frame - callModule( - shiny_data_filter, # call the module - "data_filter", # give the filter a name(space) - data = starwars2, # feed it raw data - verbose = FALSE - ) + IDEAFilter("data_filter", data = starwars2,verbose = FALSE) # extract & display the "code" attribute to see dplyr::filter() # statements performed @@ -134,4 +128,4 @@ server <- function(input, output, session) { } shinyApp(ui = ui, server = server) -``` \ No newline at end of file +``` diff --git a/README.md b/README.md index 87c8feb..aa71899 100644 --- a/README.md +++ b/README.md @@ -4,7 +4,7 @@ Agnostic, Idiomatic Data Filter Module for Shiny.
- + Demo example app that leverages the IDEAFilter shiny module
@@ -61,20 +61,19 @@ On the UI side, you need only include the following line of code to place the filtering widget somewhere in your app: ``` r -shiny_data_filter_ui(inputId = "data_filter") +IDEAFilter_ui(id = "data_filter") ``` -The server side logic needs to call the `shiny_data_filter` module, -match the input ID from the UI, and provide a data source. The returned -reactive data.frame (called “filtered_data”) may used for downstream -processes regardless on if the user chooses to apply filters or not. +The server side logic needs to call the `IDEAFilter` module, match the +input ID from the UI, and provide a data source. The returned reactive +data.frame (called “filtered_data”) may used for downstream processes +regardless on if the user chooses to apply filters or not. ``` r filtered_data <- # name the returned reactive data frame - callModule( - shiny_data_filter, # call the module by name + IDEAFilter( "data_filter", # give the filter a name(space) - data = starwars2, # feed it raw data + data = starwars, # feed it raw data verbose = FALSE ) ``` @@ -86,7 +85,7 @@ workings of the Star Wars app referenced above. Or click the button below to test drive the example app now!
- + Demo example app that leverages the IDEAFilter shiny module
@@ -119,18 +118,13 @@ ui <- fluidPage( dataTableOutput("data_summary"), h4("Generated Code"), verbatimTextOutput("data_filter_code")), - column(4, shiny_data_filter_ui("data_filter")))) + column(4, IDEAFilter_ui("data_filter")))) server <- function(input, output, session) { filtered_data <- # name the returned reactive data frame - callModule( - shiny_data_filter, # call the module - "data_filter", # give the filter a name(space) - data = starwars2, # feed it raw data - verbose = FALSE - ) + IDEAFilter("data_filter", data = starwars2,verbose = FALSE) # extract & display the "code" attribute to see dplyr::filter() # statements performed diff --git a/cran-comments.md b/cran-comments.md index f3d5371..4993df8 100644 --- a/cran-comments.md +++ b/cran-comments.md @@ -1,75 +1,33 @@ -## Re-submission 2022-06-27 -This is a re-submission. In this version I have: +# CRAN v0.2.0 Re-submission -* Referenced package names using single quotes in the description field. Also, spelled out 'UI' to 'user interface'. +On April 10, 2024 -* Added appropriate `@return` roxygen comments for the following exported functions to generate `\value` statement in `.Rd` files: - - getInitializationCode.shinyDataFilter_df.Rd - - shiny_vector_filter_numeric_few.Rd - - shiny_vector_filter_numeric_many.Rd +### R CMD check results +0 errors | 0 warnings | 0 note -#### R CMD Check -0 errors | 0 warnings | 1 note -``` -checking CRAN incoming feasibility ... NOTE - Maintainer: 'Aaron Clark ' - - New submission -``` - -## Re-submission 2022-06-24 -This is a re-submission. In this version I have: +### Reverse dependency check -* Added more details about the package functionality in the Description field of the DESCRIPTION file. +One reverse dependency exists (`{tidyCDISC}`) and was tested by running R CMD Check using the development version of `IDEAFilter`. The changes have no negative impact on it's reverse dependency. -* Removed `@examples` section for unexported functions, which coincidentally also removed an instance where `:::` was used. +
-* Used `if(interactive())` and not `\dontrun` in `man/shiny_data_filter.Rd`'s `@examples` section since it is insufficient by itself. +# Initial CRAN v0.2.0 Submission +On April 3, 2024 -#### R CMD Check +### R CMD check results 0 errors | 0 warnings | 1 note ``` -checking CRAN incoming feasibility ... NOTE - Maintainer: 'Aaron Clark ' - - New submission +Found the following (possibly) invalid URLs: + URL: https://bit.ly/demo_IDEAFilter (moved to https://rinpharma.shinyapps.io/IDEAfilter/) + From: README.md + Status: 301 + Message: Moved Permanently + For content that is 'Moved Permanently', please change http to https, + add trailing slashes, or replace the old by the new URL. ``` +This is an intentional redirect that allows the package maintainer to monitor traffic to the demo application originating from the package README +### Reverse dependency check -## Re-submission 2022-06-11 -This is a re-submission. In this version I have: - -* Clearly identified the copyright holder in the DESCRIPTION file, and omitted the extra LICENSE file, per request, as it was not needed for AGPL-3. - -* Reduced the size of the package to be less than 5MB. - -#### R CMD Check -0 errors | 0 warnings | 1 note -``` -checking CRAN incoming feasibility ... NOTE - Maintainer: 'Aaron Clark ' - - New submission -``` -## Initial submission 2022-06-10 -#### R CMD Check -0 errors | 0 warnings | 1 note - -``` -checking CRAN incoming feasibility ... NOTE - Maintainer: 'Aaron Clark ' - - New submission - - License components with restrictions and base license permitting such: - AGPL-3 + file LICENSE - File 'LICENSE': - YEAR: 2020 - COPYRIGHT HOLDER: Biogen; - - Size of tarball: 5464618 bytes -``` -### Downstream dependencies - -There are none. +One reverse dependency exists (`{tidyCDISC}`) and was tested by running R CMD Check using the development version of `IDEAFilter`. The changes have no negative impact on it's reverse dependency. \ No newline at end of file diff --git a/data-raw/internal-data.R b/data-raw/internal-data.R new file mode 100644 index 0000000..f2ace27 --- /dev/null +++ b/data-raw/internal-data.R @@ -0,0 +1,17 @@ +## code to prepare `internal-data` dataset goes here +set.seed(5000) +vector_data <- + dplyr::tibble( + character = purrr::map_chr(1:50, ~ paste(sample(letters, 5, replace = TRUE), collapse = "")), + date = as.Date("2021-03-02") + floor(50*runif(50, min = -1)), + datetime = as.POSIXct("2021-02-02 11:54:56", format = "%Y-%m-%d %H:%M:%S") + floor((1:50*24*60*60 + runif(50, min = -1)*24*60*60)), + factor_few = as.factor(sample(LETTERS[1:4], 50, replace = TRUE)), + factor_many = as.factor(sample(LETTERS[1:10], 50, replace = TRUE)), + logical = runif(50, min = -1) > 0, + numeric_few = sample(1:5, 50, replace = TRUE), + numeric_many = floor(100*runif(50)), + unknown = purrr::map(1:50, ~ list(A = sample(letters, 5, replace = TRUE), B = sample(LETTERS, 5, replace = TRUE))) + ) +attr(vector_data$datetime, "tzone") <- "UTC" + +usethis::use_data(vector_data, overwrite = TRUE, internal = TRUE) diff --git a/inst/WORDLIST b/inst/WORDLIST index 267093f..952ca3c 100644 --- a/inst/WORDLIST +++ b/inst/WORDLIST @@ -1,5 +1,6 @@ Cheng Pharma +Pre UI df dplyr @@ -7,9 +8,11 @@ dropdown getInitializationCode ns pharma +pre reactiveValues readme scriptgloss +selectize selectizeInput shinyDataFilter shinytest diff --git a/inst/examples/iris_app/adsl.xpt b/inst/examples/iris_app/adsl.xpt deleted file mode 100644 index 56e04ac..0000000 Binary files a/inst/examples/iris_app/adsl.xpt and /dev/null differ diff --git a/inst/examples/iris_app/app.R b/inst/examples/iris_app/app.R index b12fdbd..5bba523 100644 --- a/inst/examples/iris_app/app.R +++ b/inst/examples/iris_app/app.R @@ -12,15 +12,11 @@ ui <- fluidPage( verbatimTextOutput("data_filter_code"), dataTableOutput("data_summary") ), - column(4, shiny_data_filter_ui("data_filter")))) + column(4, IDEAFilter_ui("data_filter")))) server <- function(input, output, session) { - filtered_data <- callModule( - IDEAFilter::shiny_data_filter, - "data_filter", - data = iris, - verbose = FALSE) + filtered_data <- IDEAFilter("data_filter", data = iris, verbose = FALSE) output$data_filter_code <- renderPrint({ cat(gsub("%>%", "%>% \n ", @@ -41,6 +37,4 @@ server <- function(input, output, session) { } -shinyApp(ui = ui, server = server) - - +shinyApp(ui = ui, server = server) \ No newline at end of file diff --git a/inst/examples/starwars_app/app.R b/inst/examples/starwars_app/app.R index 9d75234..c4afdcc 100644 --- a/inst/examples/starwars_app/app.R +++ b/inst/examples/starwars_app/app.R @@ -23,14 +23,39 @@ ui <- fluidPage( dataTableOutput("data_summary"), h4("Generated code:"), verbatimTextOutput("data_filter_code")), - column(4, shiny_data_filter_ui("data_filter")))) + column(4, + varSelectizeInput("col_subset", "Choose Column Subset", starwars2, multiple = TRUE), + div( + class = "form-group", + tags$label(class = "control-label", "Choose Pre-selection"), + div( + style = "display: flex", + actionButton("ex1", HTML("gender: feminine
height: >= 180cm"), width = "50%"), + actionButton("ex2", HTML("is_droid: TRUE; not NA
mass: < 50kg"), width = "50%") + ) + ), + hr(), + br(), + IDEAFilter_ui("data_filter")) + )) server <- function(input, output, session) { - filtered_data <- callModule( - shiny_data_filter, - "data_filter", - data = starwars2, - verbose = FALSE) + + preselection <- reactiveVal(NULL) + observeEvent(input$ex1, { + preselection( + list(gender = list(filter_fn = ~ .x == "feminine"), + height = list(filter_fn = ~ .x >= 180)) + ) + }) + observeEvent(input$ex2, { + preselection( + list(is_droid = list(filter_na = TRUE, filter_fn = ~ isTRUE(.x)), + mass = list(filter_fn = ~ .x < 50)) + ) + }) + + filtered_data <- IDEAFilter("data_filter", data = starwars2, col_subset = reactive(input$col_subset), preselection = preselection, verbose = FALSE) output$data_filter_code <- renderPrint({ cat(gsub("%>%", "%>% \n ", diff --git a/man/IDEAFilter.Rd b/man/IDEAFilter.Rd new file mode 100644 index 0000000..b27722e --- /dev/null +++ b/man/IDEAFilter.Rd @@ -0,0 +1,94 @@ +% Generated by roxygen2: do not edit by hand +% Please edit documentation in R/IDEAFilter.R +\name{IDEAFilter} +\alias{IDEAFilter} +\title{IDEA data filter module server function} +\usage{ +IDEAFilter( + id, + data, + ..., + col_subset = NULL, + preselection = NULL, + verbose = FALSE +) +} +\arguments{ +\item{id}{a module id name} + +\item{data}{a \code{data.frame} or \code{reactive expression} returning a +\code{data.frame} to use as the input to the filter module} + +\item{...}{placeholder for inclusion of additional parameters in future development} + +\item{col_subset}{a \code{vector} containing the list of allowable columns to filter on} + +\item{preselection}{a \code{list} that can be used to pre-populate the filter} + +\item{verbose}{a \code{logical} value indicating whether or not to print log +statements out to the console} +} +\value{ +a \code{reactive expression} which returns the filtered data wrapped + in an additional class, "shinyDataFilter_df". This structure also contains + a "code" field which represents the code needed to generate the filtered + data. +} +\description{ +Serves as a wrapper for \code{\link{shiny_data_filter}} and utilizes +\code{moduleSever()} for a more modern implementation of the data item +filter. +} +\examples{ +if(all(c(interactive(), require("dplyr"), require("IDEAFilter")))) { +library(shiny) +library(IDEAFilter) +library(dplyr) # for data pre-processing and example data + +# prep a new data.frame with more diverse data types +starwars2 <- starwars \%>\% + mutate_if(~is.numeric(.) && all(Filter(Negate(is.na), .) \%\% 1 == 0), as.integer) \%>\% + mutate_if(~is.character(.) && length(unique(.)) <= 25, as.factor) \%>\% + mutate(is_droid = species == "Droid") \%>\% + select(name, gender, height, mass, hair_color, eye_color, vehicles, is_droid) + +# create some labels to showcase column select input +attr(starwars2$name, "label") <- "name of character" +attr(starwars2$gender, "label") <- "gender of character" +attr(starwars2$height, "label") <- "height of character in centimeters" +attr(starwars2$mass, "label") <- "mass of character in kilograms" +attr(starwars2$is_droid, "label") <- "whether character is a droid" + +ui <- fluidPage( + titlePanel("Filter Data Example"), + fluidRow( + column(8, + verbatimTextOutput("data_summary"), + verbatimTextOutput("data_filter_code")), + column(4, IDEAFilter_ui("data_filter")))) + +server <- function(input, output, session) { + filtered_data <- IDEAFilter("data_filter", data = starwars2, verbose = FALSE) + + output$data_filter_code <- renderPrint({ + cat(gsub("\%>\%", "\%>\% \n ", + gsub("\\\\s{2,}", " ", + paste0( + capture.output(attr(filtered_data(), "code")), + collapse = " ")) + )) + }) + + output$data_summary <- renderPrint({ + if (nrow(filtered_data())) show(filtered_data()) + else "No data available" + }) +} + +shinyApp(ui = ui, server = server) +} + +} +\seealso{ +\link{IDEAFilter_ui}, \link{shiny_data_filter} +} diff --git a/man/IDEAFilter_item.Rd b/man/IDEAFilter_item.Rd new file mode 100644 index 0000000..b406262 --- /dev/null +++ b/man/IDEAFilter_item.Rd @@ -0,0 +1,50 @@ +% Generated by roxygen2: do not edit by hand +% Please edit documentation in R/IDEAFilter_item.R +\name{IDEAFilter_item} +\alias{IDEAFilter_item} +\title{The server function for the IDEA filter item module} +\usage{ +IDEAFilter_item( + id, + data, + column_name = NULL, + filters = list(), + ..., + col_subset = NULL, + preselection = NULL, + verbose = FALSE +) +} +\arguments{ +\item{id}{a module id name} + +\item{data}{a \code{reactive expression} returning a \code{data.frame} to use +as the input to the filter item module} + +\item{column_name}{a value indicating the name of the column to be filtered} + +\item{filters}{a \code{reactive expression} containing the a list of filters +passed as \code{language} types} + +\item{...}{placeholder for inclusion of additional parameters in future development} + +\item{col_subset}{a \code{vector} containing the list of allowable columns to filter on} + +\item{preselection}{a \code{list} that can be used to pre-populate the filter} + +\item{verbose}{a \code{logical} value indicating whether or not to print log +statements out to the console} +} +\value{ +a \code{\link[shiny]{reactiveValues}} list of four reactive elements; + (1) the code to filter a vector with the name of the specified data column, + (2) a flag indicating when to remove this filter, (3) the append list of + combining the `filters` argument with (1), and (4) the column name of the + `data` used to create the item. +} +\description{ +Serves as a wrapper for \code{\link{shiny_data_filter_item}} and utilizes +\code{moduleSever()} for a more modern implementation of the data item +filter. +} +\keyword{internal} diff --git a/man/IDEAFilter_item_ui.Rd b/man/IDEAFilter_item_ui.Rd new file mode 100644 index 0000000..ab7f6fb --- /dev/null +++ b/man/IDEAFilter_item_ui.Rd @@ -0,0 +1,19 @@ +% Generated by roxygen2: do not edit by hand +% Please edit documentation in R/IDEAFilter_item.R +\name{IDEAFilter_item_ui} +\alias{IDEAFilter_item_ui} +\title{A single filter item as part of a IDEA filter module panel} +\usage{ +IDEAFilter_item_ui(id) +} +\arguments{ +\item{id}{a module id name} +} +\value{ +a shiny \code{\link[shiny]{wellPanel}} to house the filter +} +\description{ +This is a wrapper for \code{\link{shiny_data_filter_item_ui}} created to +match up with the module server function \code{\link{IDEAFilter_item}}. +} +\keyword{internal} diff --git a/man/IDEAFilter_ui.Rd b/man/IDEAFilter_ui.Rd new file mode 100644 index 0000000..d8a258f --- /dev/null +++ b/man/IDEAFilter_ui.Rd @@ -0,0 +1,76 @@ +% Generated by roxygen2: do not edit by hand +% Please edit documentation in R/IDEAFilter.R +\name{IDEAFilter_ui} +\alias{IDEAFilter_ui} +\title{User interface function to add a data filter panel} +\usage{ +IDEAFilter_ui(id) +} +\arguments{ +\item{id}{a module id name} +} +\value{ +a shiny \code{\link[shiny]{tagList}} containing the filter ui +} +\description{ +This is a wrapper for \code{\link{shiny_data_filter_ui}} created to match up +with the module server function \code{\link{IDEAFilter}}. +} +\examples{ +if(all(c(interactive(), require("dplyr"), require("IDEAFilter")))) { +library(shiny) +library(IDEAFilter) +library(dplyr) # for data pre-processing and example data + +# prep a new data.frame with more diverse data types +starwars2 <- starwars \%>\% + mutate_if(~is.numeric(.) && all(Filter(Negate(is.na), .) \%\% 1 == 0), as.integer) \%>\% + mutate_if(~is.character(.) && length(unique(.)) <= 25, as.factor) \%>\% + mutate(is_droid = species == "Droid") \%>\% + select(name, gender, height, mass, hair_color, eye_color, vehicles, is_droid) + +# create some labels to showcase column select input +attr(starwars2$name, "label") <- "name of character" +attr(starwars2$gender, "label") <- "gender of character" +attr(starwars2$height, "label") <- "height of character in centimeters" +attr(starwars2$mass, "label") <- "mass of character in kilograms" +attr(starwars2$is_droid, "label") <- "whether character is a droid" + +ui <- fluidPage( + titlePanel("Filter Data Example"), + fluidRow( + column(8, + verbatimTextOutput("data_summary"), + verbatimTextOutput("data_filter_code")), + column(4, shiny_data_filter_ui("data_filter")))) + +server <- function(input, output, session) { + filtered_data <- callModule( + shiny_data_filter, + "data_filter", + data = starwars2, + verbose = FALSE) + + output$data_filter_code <- renderPrint({ + cat(gsub("\%>\%", "\%>\% \n ", + gsub("\\\\s{2,}", " ", + paste0( + capture.output(attr(filtered_data(), "code")), + collapse = " ")) + )) + }) + + output$data_summary <- renderPrint({ + if (nrow(filtered_data())) show(filtered_data()) + else "No data available" + }) +} + +shinyApp(ui = ui, server = server) +} + +} +\seealso{ +\link{shiny_data_filter_ui}, \link{IDEAFilter} +} +\keyword{internal} diff --git a/man/columnSelectInput.Rd b/man/columnSelectInput.Rd index 284f41b..ca7124d 100644 --- a/man/columnSelectInput.Rd +++ b/man/columnSelectInput.Rd @@ -10,6 +10,7 @@ columnSelectInput( data, selected = "", ..., + col_subset = NULL, placeholder = "", onInitialize ) @@ -25,6 +26,8 @@ columnSelectInput( \item{...}{passed to \code{\link[shiny]{selectizeInput}}} +\item{col_subset}{a \code{vector} containing the list of allowable columns to select} + \item{placeholder}{passed to \code{\link[shiny]{selectizeInput}} options} \item{onInitialize}{passed to \code{\link[shiny]{selectizeInput}} options} diff --git a/man/shiny_vector_filter_factor_few.Rd b/man/shiny_vector_filter_factor_few.Rd index ee8bf29..b02ff0b 100644 --- a/man/shiny_vector_filter_factor_few.Rd +++ b/man/shiny_vector_filter_factor_few.Rd @@ -10,7 +10,9 @@ shiny_vector_filter_factor_few( session, x = shiny::reactive(factor()), filter_na = shiny::reactive(TRUE), - verbose = FALSE + filter_fn = NULL, + verbose = FALSE, + erase_filters = shiny::reactive(0) ) } \arguments{ @@ -28,6 +30,11 @@ session} \item{filter_na}{a logical value indicating whether to filter \code{NA} values from the \code{x} vector} +\item{filter_fn}{A function to modify, specified in one of the following ways: +* A named function, e.g. `mean`. +* An anonymous function, e.g. `\(x) x + 1` or `function(x) x + 1`. +* A formula, e.g. `~ .x + 1`.} + \item{verbose}{a \code{logical} value indicating whether or not to print log statements out to the console} } diff --git a/man/shiny_vector_filter_factor_many.Rd b/man/shiny_vector_filter_factor_many.Rd index 3f6fea8..952ad80 100644 --- a/man/shiny_vector_filter_factor_many.Rd +++ b/man/shiny_vector_filter_factor_many.Rd @@ -10,7 +10,9 @@ shiny_vector_filter_factor_many( session, x = shiny::reactive(factor()), filter_na = shiny::reactive(FALSE), - verbose = FALSE + filter_fn = NULL, + verbose = FALSE, + erase_filters = shiny::reactive(0) ) } \arguments{ @@ -28,6 +30,11 @@ session} \item{filter_na}{a logical value indicating whether to filter \code{NA} values from the \code{x} vector} +\item{filter_fn}{A function to modify, specified in one of the following ways: +* A named function, e.g. `mean`. +* An anonymous function, e.g. `\(x) x + 1` or `function(x) x + 1`. +* A formula, e.g. `~ .x + 1`.} + \item{verbose}{a \code{logical} value indicating whether or not to print log statements out to the console} } diff --git a/man/shiny_vector_filter_numeric_few.Rd b/man/shiny_vector_filter_numeric_few.Rd index c2ccfd3..6c11fd8 100644 --- a/man/shiny_vector_filter_numeric_few.Rd +++ b/man/shiny_vector_filter_numeric_few.Rd @@ -10,7 +10,9 @@ shiny_vector_filter_numeric_few( session, x = shiny::reactive(factor()), filter_na = shiny::reactive(FALSE), - verbose = FALSE + filter_fn = NULL, + verbose = FALSE, + erase_filters = shiny::reactive(0) ) } \arguments{ @@ -27,6 +29,11 @@ session} \item{filter_na}{The \code{logical} TODO} +\item{filter_fn}{A function to modify, specified in one of the following ways: +* A named function, e.g. `mean`. +* An anonymous function, e.g. `\(x) x + 1` or `function(x) x + 1`. +* A formula, e.g. `~ .x + 1`.} + \item{verbose}{a \code{logical} value indicating whether or not to print log statements out to the console} } diff --git a/man/shiny_vector_filter_numeric_many.Rd b/man/shiny_vector_filter_numeric_many.Rd index 23fa394..8d8d169 100644 --- a/man/shiny_vector_filter_numeric_many.Rd +++ b/man/shiny_vector_filter_numeric_many.Rd @@ -10,7 +10,9 @@ shiny_vector_filter_numeric_many( session, x = shiny::reactive(numeric()), filter_na = shiny::reactive(FALSE), - verbose = FALSE + filter_fn = NULL, + verbose = FALSE, + erase_filters = shiny::reactive(0) ) } \arguments{ @@ -27,6 +29,11 @@ session} \item{filter_na}{The \code{logical} TODO} +\item{filter_fn}{A function to modify, specified in one of the following ways: +* A named function, e.g. `mean`. +* An anonymous function, e.g. `\(x) x + 1` or `function(x) x + 1`. +* A formula, e.g. `~ .x + 1`.} + \item{verbose}{a \code{logical} value indicating whether or not to print log statements out to the console} } diff --git a/tests/shinytest/shinytest_IDEAFilter/app.R b/tests/shinytest/shinytest_IDEAFilter/app.R new file mode 100644 index 0000000..d38af83 --- /dev/null +++ b/tests/shinytest/shinytest_IDEAFilter/app.R @@ -0,0 +1,30 @@ +ui <- fluidPage( + titlePanel("Filter Data Example"), + fluidRow( + column(8, + verbatimTextOutput("data_summary"), + verbatimTextOutput("data_filter_code")), + column(4, IDEAFilter::IDEAFilter_ui("data_filter")))) + +srv <- function(input, output, session) { + filtered_data <- IDEAFilter::IDEAFilter( + "data_filter", + data = airquality, + verbose = FALSE) + + output$data_filter_code <- renderPrint({ + cat(gsub("%>%", "%>% \n ", + gsub("\\s{2,}", " ", + paste0( + capture.output(attr(filtered_data(), "code")), + collapse = " ")) + )) + }) + + output$data_summary <- renderPrint({ + if (nrow(filtered_data())) show(filtered_data()) + else "No data available" + }) +} + +shinyApp(ui, srv) diff --git a/tests/shinytest/shinytest_IDEAFilter_item/app.R b/tests/shinytest/shinytest_IDEAFilter_item/app.R new file mode 100644 index 0000000..9434c83 --- /dev/null +++ b/tests/shinytest/shinytest_IDEAFilter_item/app.R @@ -0,0 +1,25 @@ +data <- mtcars +data[which((data * 0.987) %% 0.2 < 0.01, arr.ind = TRUE)] <- NA + +ui <- fluidPage( + mainPanel(verbatimTextOutput("data_display")), + sidebarPanel(IDEAFilter::IDEAFilter_item_ui("filter"))) + +srv <- function(input, output, session) { + filtered_data <- IDEAFilter::IDEAFilter_item( + "filter", + data = reactive(data)) + + filter_logical <- reactiveVal(TRUE) + observe({ + filter_exprs <- filtered_data$filters() + + filter_logical(if (!length(filter_exprs)) rep(TRUE,nrow(data)) else Reduce("&", Map(function(x) with(data, eval(x)), filter_exprs))) + }) + + output$data_display <- renderPrint({ + print(IDEAFilter:::`%||%`(subset(data, filter_logical()), data.frame())) + }) +} + +shinyApp(ui, srv) diff --git a/tests/shinytest/shinytest_data_types/app.R b/tests/shinytest/shinytest_data_types/app.R new file mode 100644 index 0000000..83a3c9d --- /dev/null +++ b/tests/shinytest/shinytest_data_types/app.R @@ -0,0 +1,30 @@ +ui <- fluidPage( + titlePanel("Filter Data Example"), + fluidRow( + column(8, + verbatimTextOutput("data_summary"), + verbatimTextOutput("data_filter_code")), + column(4, IDEAFilter_ui("data_filter")))) + +srv <- function(input, output, session) { + filtered_data <- IDEAFilter( + "data_filter", + data = vector_data, + verbose = FALSE) + + output$data_filter_code <- renderPrint({ + cat(gsub("%>%", "%>% \n ", + gsub("\\s{2,}", " ", + paste0( + capture.output(attr(filtered_data(), "code")), + collapse = " ")) + )) + }) + + output$data_summary <- renderPrint({ + if (nrow(filtered_data())) show(filtered_data()) + else "No data available" + }) +} + +shinyApp(ui, srv) \ No newline at end of file diff --git a/tests/shinytest/shinytest_preselection/app.R b/tests/shinytest/shinytest_preselection/app.R new file mode 100644 index 0000000..bed490f --- /dev/null +++ b/tests/shinytest/shinytest_preselection/app.R @@ -0,0 +1,47 @@ +ui <- fluidPage( + titlePanel("Filter Data Example"), + fluidRow( + column(8, + selectInput("filter_select", NULL, choices = c("filter_1", "filter_2")), + verbatimTextOutput("data_summary"), + verbatimTextOutput("data_filter_code")), + column(4, IDEAFilter::IDEAFilter_ui("data_filter")))) + +srv <- function(input, output, session) { + + preselection <- reactiveVal(list(Ozone = list(filter_na = TRUE, filter_fn = ~ .x >= 30), + Solar = list(filter_fn = ~ .x > 100), + Month = list(filter_fn = ~ .x == 9))) + + observeEvent(input$filter_select, { + if (input$filter_select == "filter_1") + preselection(list(Ozone = list(filter_na = TRUE, filter_fn = ~ .x >= 30), + Solar = list(filter_fn = ~ .x > 100), + Month = list(filter_fn = ~ .x == 9))) + else + preselection(list(Ozone = list(filter_fn = ~ .x >= 30 & .x <= 90), + Wind = list(filter_fn = ~.x >= 5 & .x <= 10))) + }) + +filtered_data <- IDEAFilter::IDEAFilter( + "data_filter", + data = airquality, + preselection = preselection, + verbose = FALSE) + + output$data_filter_code <- renderPrint({ + cat(gsub("%>%", "%>% \n ", + gsub("\\s{2,}", " ", + paste0( + capture.output(attr(filtered_data(), "code")), + collapse = " ")) + )) + }) + + output$data_summary <- renderPrint({ + if (nrow(filtered_data())) show(filtered_data()) + else "No data available" + }) +} + +shinyApp(ui, srv) diff --git a/tests/shinytest/shinytest_reactive_data/app.R b/tests/shinytest/shinytest_reactive_data/app.R new file mode 100644 index 0000000..2517856 --- /dev/null +++ b/tests/shinytest/shinytest_reactive_data/app.R @@ -0,0 +1,46 @@ +mtcars2 <- mtcars +mtcars2[which((mtcars2 * 0.987) %% 0.2 < 0.01, arr.ind = TRUE)] <- NA + +ui <- fluidPage( + fluidRow( + column(8, + selectInput("select_data", "Select Data", c("airquality", "mtcars"), selected = "airquality"), + verbatimTextOutput("data_summary"), + verbatimTextOutput("data_filter_code")), + column(4, IDEAFilter::IDEAFilter_ui("data_filter")))) + +srv <- function(input, output, session) { + data <- reactiveVal(airquality) + filtered_data <- IDEAFilter::IDEAFilter( + "data_filter", + data = data, + verbose = FALSE) + + exportTestValues( + filtered_data = filtered_data() + ) + + observeEvent(input$select_data, { + if (input$select_data == "airquality") + data(airquality) + else + data(mtcars2) + }) + + output$data_filter_code <- renderPrint({ + cat(gsub("%>%", "%>% \n ", + gsub("\\s{2,}", " ", + paste0( + capture.output(attr(filtered_data(), "code")), + collapse = " ")) + )) + }) + + output$data_summary <- renderPrint({ + if (nrow(filtered_data())) show(filtered_data()) + else "No data available" + }) + +} + +shinyApp(ui, srv) diff --git a/tests/spelling.R b/tests/spelling.R index 6713838..06a1204 100644 --- a/tests/spelling.R +++ b/tests/spelling.R @@ -1,3 +1,5 @@ if(requireNamespace('spelling', quietly = TRUE)) spelling::spell_check_test(vignettes = TRUE, error = FALSE, skip_on_cran = TRUE) +# spelling::spell_check_package() +# spelling::update_wordlist() \ No newline at end of file diff --git a/tests/testthat/test_IDEAFilter.R b/tests/testthat/test_IDEAFilter.R new file mode 100644 index 0000000..e36f126 --- /dev/null +++ b/tests/testthat/test_IDEAFilter.R @@ -0,0 +1,53 @@ +context("test_IDEAFilter") +skip_on_cran() + +app_path <- IDEAFilter:::shinytest_path("shinytest_IDEAFilter") +app <- shinytest2::AppDriver$new(app_path) + +app$set_inputs(`data_filter-add_filter_select` = "Wind") +app$wait_for_js('document.getElementById("data_filter-filter_1-remove_filter_btn")') +app$set_inputs(`data_filter-filter_1-remove_filter_btn` = "click") + +test_that("test that a new filter item has been added", { + expect_true(!"data_filter-filter_1-column_select" %in% lapply(app$get_values(), names)$input) +}) + + + +app$set_inputs(`data_filter-add_filter_select` = "Ozone") +app$wait_for_js('document.getElementById("data_filter-filter_2-vector_filter-param_many")') +app$set_inputs(`data_filter-filter_2-vector_filter-param_many` = c(30, 90)) + +test_that("test that a new filter item has been added", { + expect_equal( + app$get_value(output = "data_summary"), + renderPrint(subset(airquality, is.na(Ozone) | (Ozone >= 30 & Ozone <= 90)))()) +}) + + + +app$set_inputs(`data_filter-filter_2-filter_na_btn` = "click") + +test_that("test that a new filter item has been added", { + expect_equal( + app$get_value(output = "data_summary"), + renderPrint(subset(airquality, Ozone >= 30 & Ozone <= 90))()) +}) + + + + +app$set_inputs(`data_filter-add_filter_select` = "Wind") +app$wait_for_js('document.getElementById("data_filter-filter_3-vector_filter-param_many")') +app$set_inputs(`data_filter-filter_3-vector_filter-param_many` = c(5, 10)) + +test_that("test that nrow reactive value is accurate", { + expect_equal( + app$get_value(output = "data_summary"), + renderPrint(subset(airquality, + (Ozone >= 30 & Ozone <= 90) & + (is.na(Wind) | (Wind >= 5 & Wind <= 10)) + ))()) +}) + +app$stop() diff --git a/tests/testthat/test_IDEAFilter_item.R b/tests/testthat/test_IDEAFilter_item.R new file mode 100644 index 0000000..e1e6a4e --- /dev/null +++ b/tests/testthat/test_IDEAFilter_item.R @@ -0,0 +1,49 @@ +context("test_IDEAFilter_item") +skip_on_cran() + +# reflects data used in shinytest +data <- mtcars +data[which((data * 0.987) %% 0.2 < 0.01, arr.ind = TRUE)] <- NA + +app_path <- IDEAFilter:::shinytest_path("shinytest_IDEAFilter_item") +app <- shinytest2::AppDriver$new(app_path) + + +test_that("test that filter item initializes with column select", { + expect_true(!"filter-vector_filter-param" %in% lapply(app$get_values(), names)) +}) + + + +app$set_inputs(`filter-column_select` = "mpg") +app$wait_for_js('document.getElementById("filter-vector_filter-param_many")') +app$set_inputs(`filter-vector_filter-param_many` = c(20, 25)) + + + +test_that("test that nrow reactive value is accurate", { + expect_equal( + app$get_value(output = "filter-nrow"), + as.character(nrow(subset(data, is.na(mpg) | (mpg >= 20 & mpg <= 25))))) +}) + + + +app$set_inputs(`filter-filter_na_btn` = "click") + +test_that("test that filtering NAs works", { + expect_equal( + app$get_value(output = "filter-nrow"), + as.character(nrow(subset(data, mpg >= 20 & mpg <= 25)))) +}) + + + +app$set_inputs(`filter-column_select_edit_btn` = "click") + +test_that("test editing column removes vector filter", { + expect_true(!"filter-vector_filter-param" %in% lapply(app$get_values(), names)) +}) + + +app$stop() diff --git a/tests/testthat/test_preselection.R b/tests/testthat/test_preselection.R new file mode 100644 index 0000000..2eca1ab --- /dev/null +++ b/tests/testthat/test_preselection.R @@ -0,0 +1,31 @@ +context("test_preselection") +skip_on_cran() + +app_path <- IDEAFilter:::shinytest_path("shinytest_preselection") +app <- shinytest2::AppDriver$new(app_path) + +app$wait_for_idle() + +test_that("test that a new filter item has been added", { + expect_true(!"data_filter-filter_2-column_select" %in% lapply(app$get_values(), names)$input) +}) + +test_that("test that a new filter item has been added", { + expect_equal( + app$get_value(output = "data_summary"), + renderPrint(subset(airquality, Ozone >= 30 & Month == 9))()) +}) + +app$set_inputs(filter_select = "filter_2") +app$wait_for_idle() + +test_that("test that nrow reactive value is accurate", { + expect_equal( + app$get_value(output = "data_summary"), + renderPrint(subset(airquality, + (is.na(Ozone) | (Ozone >= 30 & Ozone <= 90)) & + (is.na(Wind) | (Wind >= 5 & Wind <= 10)) + ))()) +}) + +app$stop() diff --git a/tests/testthat/test_reactive_data.R b/tests/testthat/test_reactive_data.R new file mode 100644 index 0000000..5bdc2e4 --- /dev/null +++ b/tests/testthat/test_reactive_data.R @@ -0,0 +1,47 @@ +context("test_reactive_data") +skip_on_cran() + +# reflects data used in shinytest +mtcars2 <- mtcars +mtcars2[which((mtcars2 * 0.987) %% 0.2 < 0.01, arr.ind = TRUE)] <- NA + +app_path <- IDEAFilter:::shinytest_path("shinytest_reactive_data") +app <- shinytest2::AppDriver$new(app_path) + +app$set_inputs(`data_filter-add_filter_select` = "Ozone") +app$wait_for_js('document.getElementById("data_filter-filter_1-remove_filter_btn")') +app$wait_for_idle() +app$set_inputs(`data_filter-filter_1-vector_filter-param_many` = c(30, 90)) + +test_that("test that a new filter item has been added", { + expect_equivalent( + app$get_value(output = "data_summary"), + renderPrint(subset(airquality, is.na(Ozone) | (Ozone >= 30 & Ozone <= 90)))()) +}) + +app$set_inputs(select_data = "mtcars") + +test_that("test that a new filter item has been added", { + expect_equivalent( + app$get_value(output = "data_summary"), + renderPrint(mtcars2)()) +}) + +app$set_inputs(`data_filter-add_filter_select` = "mpg") +app$wait_for_js('document.getElementById("data_filter-filter_2-remove_filter_btn")') +app$wait_for_idle() +app$set_inputs(`data_filter-filter_2-vector_filter-param_many` = c(20, 25)) + +test_that("test that a new filter item has been added", { + expect_equivalent( + app$get_value(output = "data_summary"), + renderPrint(subset(mtcars2, is.na(mpg) | (mpg >= 20 & mpg <= 25)))()) +}) + +app$set_inputs(select_data = "airquality") + +test_that("test that a new filter item has been added", { + expect_equivalent( + app$get_value(output = "data_summary"), + renderPrint(subset(airquality, is.na(Ozone) | (Ozone >= 30 & Ozone <= 90)))()) +}) diff --git a/tests/testthat/test_shiny_data_filter.R b/tests/testthat/test_shiny_data_filter.R index 1c489e6..1add023 100644 --- a/tests/testthat/test_shiny_data_filter.R +++ b/tests/testthat/test_shiny_data_filter.R @@ -15,8 +15,8 @@ test_that("test that a new filter item has been added", { app$set_inputs(`data_filter-add_filter_select` = "Ozone") -app$wait_for_js('document.getElementById("data_filter-filter_2-vector_filter-param")') -app$set_inputs(`data_filter-filter_2-vector_filter-param` = c(30, 90)) +app$wait_for_js('document.getElementById("data_filter-filter_2-vector_filter-param_many")') +app$set_inputs(`data_filter-filter_2-vector_filter-param_many` = c(30, 90)) test_that("test that a new filter item has been added", { expect_equal( @@ -38,8 +38,8 @@ test_that("test that a new filter item has been added", { app$set_inputs(`data_filter-add_filter_select` = "Wind") -app$wait_for_js('document.getElementById("data_filter-filter_3-vector_filter-param")') -app$set_inputs(`data_filter-filter_3-vector_filter-param` = c(5, 10)) +app$wait_for_js('document.getElementById("data_filter-filter_3-vector_filter-param_many")') +app$set_inputs(`data_filter-filter_3-vector_filter-param_many` = c(5, 10)) test_that("test that nrow reactive value is accurate", { expect_equal( diff --git a/tests/testthat/test_shiny_data_filter_item.R b/tests/testthat/test_shiny_data_filter_item.R index b462d24..b26787e 100644 --- a/tests/testthat/test_shiny_data_filter_item.R +++ b/tests/testthat/test_shiny_data_filter_item.R @@ -16,8 +16,8 @@ test_that("test that filter item initializes with column select", { app$set_inputs(`filter-column_select` = "mpg") -app$wait_for_js('document.getElementById("filter-vector_filter-param")') -app$set_inputs(`filter-vector_filter-param` = c(20, 25)) +app$wait_for_js('document.getElementById("filter-vector_filter-param_many")') +app$set_inputs(`filter-vector_filter-param_many` = c(20, 25)) diff --git a/tests/testthat/test_shiny_vector_filter_numeric.R b/tests/testthat/test_shiny_vector_filter_numeric.R index 1394612..3428d32 100644 --- a/tests/testthat/test_shiny_vector_filter_numeric.R +++ b/tests/testthat/test_shiny_vector_filter_numeric.R @@ -6,11 +6,11 @@ app <- shinytest2::AppDriver$new(app_path) data <- c(1:9, NA) app$set_inputs(`data_dput` = paste(capture.output(dput(data)), paste = "\n")) -app$wait_for_js('document.getElementById("test_in-param")') +app$wait_for_js('document.getElementById("test_in-param_many")') test_that("testing that numeric vectors get filtered properly", { - app$set_inputs(`test_in-param` = c(3, 6)) + app$set_inputs(`test_in-param_many` = c(3, 6)) app$set_inputs(`filter_na` = TRUE) expect_equal( @@ -33,7 +33,7 @@ test_that("testing that numeric vectors get filtered properly", { test_that("testing that numeric vector filter code builds properly", { - app$set_inputs(`test_in-param` = c(5, 8)) + app$set_inputs(`test_in-param_many` = c(5, 8)) app$set_inputs(`filter_na` = TRUE) expect_equal( diff --git a/vignettes/.gitignore b/vignettes/.gitignore new file mode 100644 index 0000000..097b241 --- /dev/null +++ b/vignettes/.gitignore @@ -0,0 +1,2 @@ +*.html +*.R diff --git a/vignettes/IDEAFilter.Rmd b/vignettes/IDEAFilter.Rmd new file mode 100644 index 0000000..4a6fd9f --- /dev/null +++ b/vignettes/IDEAFilter.Rmd @@ -0,0 +1,80 @@ +--- +title: "Using IDEAFilter" +output: rmarkdown::html_vignette +vignette: > + %\VignetteIndexEntry{Using IDEAFilter} + %\VignetteEngine{knitr::rmarkdown} + %\VignetteEncoding{UTF-8} +--- + +```{r, include = FALSE} +knitr::opts_chunk$set( + collapse = TRUE, + comment = "#>" +) +``` + +# Minimal Example + +Here is a minimal example using `IDEAFilter_ui()` and `IDEAFilter()` to explore a data set: + +```{r, eval=FALSE} +library(shiny) +library(IDEAFilter) +library(dplyr) +shinyApp( + ui = fluidPage( + titlePanel("Filter Data Example"), + fluidRow( + column(8, dataTableOutput("data_summary")), + column(4, IDEAFilter_ui("data_filter")))), + server = function(input, output, session) { + filtered_data <- IDEAFilter("data_filter", data = iris, verbose = FALSE) + output$data_summary <- + renderDataTable(filtered_data(), + options = list(scrollX = TRUE, pageLength = 5)) + } +) +``` + +The server side of the module returns the reactive `ShinyDataFilter_df` object which includes the filtered data frame and the code used to filter it as an attribute. + +# A Larger Example + +With the release of `IDEAFilter()` to replace the deprecated `shiny_data_filter()`, a couple more arguments have been introduced to enhance the functionality of the filter. + +- Column Sub-setting: restricting the columns a user can add to the filter. +- Pre-selection: pre-specifying a collection of filters to either pre-load in the filter or for users to dynamically apply. + +To explore these features we can run the following example application: + +```{r, eval=FALSE} +library(shiny) +library(IDEAFilter) +app <- system.file("examples", "starwars_app", package = "IDEAFilter") +runApp(app) +``` + +## Column Sub-setting + +In the application you can freely select a subset of columns to include in the filter. The `col_subset` argument can be set in development of an application or can be a reactive variable in deployment. You should note these columns can still be set using pre-selection and will still be applied to the filter. For instance, you can see below that only `height` has been selected but `gender` is still being applied. + +![](images/colsubset.png){style="position:center; width:100%"} + +## Pre-selection + +The application comes with two choices to apply pre-selection: + +- Gender listed as feminine and height greater than 180 cm +- Character is a droid (excluding `NA`s) and has a mass less than 50 kg + +Looking at the second example is informative on how a developer can create their own pre-selections. + +```{r, eval=FALSE} +list( + is_droid = list(filter_na = TRUE, filter_fn = ~ isTRUE(.x)), + mass = list(filter_fn = ~ .x < 50)) +) +``` + +The argument `preselection` is a named list where the names correspond to column names in the data set and the elements are lists containing the elements `filter_na` and `filter_fn`. The missing values (i.e. NAs) will be filtered if `filter_na` is set to `TRUE`. The `filter_fn` element can either be a formula or a function. The filter will attempt to apply the function to the data set when populating the initial values. diff --git a/vignettes/images/colsubset.png b/vignettes/images/colsubset.png new file mode 100644 index 0000000..ecf1a89 Binary files /dev/null and b/vignettes/images/colsubset.png differ